Skip to content

Commit 8ba6f94

Browse files
committed
refactor/fix: format/sprite test
1 parent 5237c4c commit 8ba6f94

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

pokemon_v2/tests.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# pylint: disable=redefined-builtin
77

88
TEST_HOST = "http://testserver"
9-
MEDIA_HOST = "https://raw.githubusercontent.com/PokeAPI/sprites/master/"
109
API_V2 = "/api/v2"
1110

1211

@@ -313,7 +312,7 @@ def setup_item_category_name_data(cls, item_category, name="itm ctgry nm"):
313312

314313
@classmethod
315314
def setup_item_sprites_data(cls, item, default=True):
316-
sprite_path = "/media/sprites/items/%s.png"
315+
sprite_path = "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/%s.png"
317316

318317
sprites = {
319318
"default": sprite_path % item.id if default else None,
@@ -1516,7 +1515,7 @@ def setup_pokemon_form_sprites_data(
15161515
back_default=False,
15171516
back_shiny=False,
15181517
):
1519-
sprite_path = "/media/sprites/pokemon/%s.png"
1518+
sprite_path = "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/%s.png"
15201519

15211520
sprites = {
15221521
"front_default": sprite_path % pokemon_form.id if front_default else None,
@@ -1675,7 +1674,7 @@ def setup_pokemon_sprites_data(
16751674
back_shiny=False,
16761675
back_shiny_female=False,
16771676
):
1678-
sprite_path = "/media/sprites/pokemon/%s.png"
1677+
sprite_path = "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/%s.png"
16791678

16801679
sprites = {
16811680
"front_default": sprite_path % pokemon.id if front_default else None,
@@ -2712,7 +2711,7 @@ def test_item_api(self):
27122711
# sprites
27132712
self.assertEqual(
27142713
response.data["sprites"]["default"],
2715-
"{}{}".format(MEDIA_HOST, sprites_data["default"].replace("/media/", "")),
2714+
"{}".format(sprites_data["default"]),
27162715
)
27172716

27182717
# Berry Tests
@@ -5028,9 +5027,7 @@ def test_pokemon_api(self):
50285027
# sprite params
50295028
self.assertEqual(
50305029
response.data["sprites"]["front_default"],
5031-
"{}{}".format(
5032-
MEDIA_HOST, sprites_data["front_default"].replace("/media/", "")
5033-
),
5030+
"{}".format(sprites_data["front_default"]),
50345031
)
50355032
self.assertEqual(response.data["sprites"]["back_default"], None)
50365033

@@ -5080,9 +5077,7 @@ def test_pokemon_form_api(self):
50805077
# sprite params
50815078
self.assertEqual(
50825079
response.data["sprites"]["front_default"],
5083-
"{}{}".format(
5084-
MEDIA_HOST, sprites_data["front_default"].replace("/media/", "")
5085-
),
5080+
"{}".format(sprites_data["front_default"]),
50865081
)
50875082
self.assertEqual(response.data["sprites"]["back_default"], None)
50885083
# type params

0 commit comments

Comments
 (0)