Move effects

[aserra54]

Hello! The effect entries of many of the moves -- especially for the newer generations -- are either not set and/or are incorrect. In some cases as well, the effects are somewhat incomplete. Some examples:

• https://pokeapi.co/api/v2/move/aqua-step/
  • no effect defined
• https://pokeapi.co/api/v2/move/coaching/
  • indicates it does regular damage and nothing else, whereas it is a non-damaging buff move (Bulbapedia)
• https://pokeapi.co/api/v2/move/rapid-spin/
  • indicates that it breaks "wrap" and similar effects, but does not mention that it raises speed (Bulbapedia)
• https://pokeapi.co/api/v2/move/triple-axel/
  • indicates it does regular damage and nothing else. which, while not incorrect, does not really reflect the multi-hit nature of the move (Bulbapedia)

In other cases, the wording used to represent two moves which deal damage and have a secondary effect is inconsistent:

• https://pokeapi.co/api/v2/move/close-combat/
  • "Inflicts regular damage, then lowers the user's Defense and Special Defense by one stage each."
• https://pokeapi.co/api/v2/move/low-sweep/
  • "Lowers the target's Speed by one stage."

My question is: what should the standard, if any, be when specifying effect entries? Is it just best effort? Should contributors try and adhere to some given standard?

I'm preparing a PR to fix a number of these issues, but I'm also new to this repository and couldn't find any guidelines on how these entries should be worded. I don't want to arbitrarily decide in my own PR. Any guidance is appreciated! TIA.

[Naramsim]

Hi! We don't have any standards to follow. The best you can do is look up how data was previously defined and go along with it. Then you can submit a small pr just to have it reviewed. If everything is ok you can then proceed with a larger one