update spot tests (#111)

Author: sargunv

.github/workflows/ci.yml

@@ -2,7 +2,7 @@ name: CI
 
 on:
   push:
-    branches: [main]
+    branches: [ main ]
   pull_request:
   workflow_dispatch:
 
@@ -40,6 +40,7 @@ jobs:
       - uses: "actions/checkout@v4"
         with:
           fetch-depth: 0
+          submodules: recursive
       - uses: "./.github/actions/setup"
       - run: "just test-server-background"
       - run: "./gradlew ${{ matrix.target }}Test"

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "api-data"]
+	path = api-data
+	url = https://github.com/pokeapi/api-data

api-data

@@ -3,7 +3,7 @@ set windows-shell := ["C:\\Program Files\\Git\\bin\\sh.exe", "-c"]
 _default:
     just --list
 
-test-server-cmd := "npx -y http-server src/commonTest/resources/data -e json -p 8080 --cors"
+test-server-cmd := "npx -y http-server ./api-data/data -e json -p 8080 --cors"
 
 # Serve PokeAPI data from static files
 test-server:

justfile

@@ -115,7 +115,7 @@ class EvolutionTest {
           it.evolutionDetails.contains(
             EvolutionDetail(
               trigger = NamedApiResource("level-up", "evolution-trigger", 1),
-              minHappiness = 220,
+              minHappiness = 160,
               timeOfDay = "day",
             )
           )

src/commonTest/kotlin/dev/sargunv/pokekotlin/test/model/EvolutionTest.kt

@@ -74,7 +74,7 @@ class GameTest {
     LocalPokeApi.getVersionGroup(1).apply {
       assertEquals(1, id)
       assertEquals("red-blue", name)
-      assertEquals(1, order)
+      assertEquals(3, order)
       assertEquals(NamedApiResource("generation-i", "generation", 1), generation)
       assertContains(moveLearnMethods, NamedApiResource("machine", "move-learn-method", 4))
       assertContains(pokedexes, NamedApiResource("kanto", "pokedex", 2))

src/commonTest/kotlin/dev/sargunv/pokekotlin/test/model/GameTest.kt

@@ -25,7 +25,7 @@ class ItemTest {
     LocalPokeApi.getItem(20).apply {
       assertEquals(20, id)
       assertEquals("ice-heal", name)
-      assertEquals(100, cost)
+      assertEquals(200, cost)
       assertEquals(30, flingPower)
       assertContains(attributes, NamedApiResource("holdable", "item-attribute", 5))
       assertEquals(NamedApiResource("status-cures", "item-category", 30), category)
@@ -103,7 +103,7 @@ class ItemTest {
     LocalPokeApi.getItem(305).apply {
       assertNotNull(
         machines.find { machineVersionDetail ->
-          machineVersionDetail.machine == ApiResource("machine", 1) &&
+          machineVersionDetail.machine == ApiResource("machine", 2) &&
             machineVersionDetail.versionGroup == NamedApiResource("red-blue", "version-group", 1)
         }
       )

src/commonTest/kotlin/dev/sargunv/pokekotlin/test/model/ItemTest.kt

@@ -39,10 +39,16 @@ class LocationTest {
   fun getLocationArea() = runTest {
     LocalPokeApi.getLocationArea(20).apply {
       assertEquals(20, id)
-      assertEquals("mt-coronet-cave", name)
+      assertEquals("mt-coronet-1f-from-exterior", name)
       assertEquals(20, gameIndex)
       assertEquals(NamedApiResource("mt-coronet", "location", 10), location)
-      assertContains(names, Name(name = "cave", language = NamedApiResource("en", "language", 9)))
+      assertContains(
+        names,
+        Name(
+          name = "Mount Coronet (1F from exterior)",
+          language = NamedApiResource("en", "language", 9),
+        ),
+      )
       assertNotNull(
         encounterMethodRates.find {
           it.encounterMethod == NamedApiResource("walk", "encounter-method", 1) &&

src/commonTest/kotlin/dev/sargunv/pokekotlin/test/model/LocationTest.kt

@@ -14,7 +14,7 @@ class MachineTest {
       assertEquals(18, id)
       assertEquals(NamedApiResource("tm01", "item", 305), item)
       assertEquals(NamedApiResource("work-up", "move", 526), move)
-      assertEquals(NamedApiResource("ultra-sun-ultra-moon", "version-group", 18), versionGroup)
+      assertEquals(NamedApiResource("sun-moon", "version-group", 17), versionGroup)
     }
   }
 }

src/commonTest/kotlin/dev/sargunv/pokekotlin/test/model/MachineTest.kt

@@ -28,9 +28,8 @@ class MoveTest {
       assertContains(
         effectEntries,
         VerboseEffect(
-          effect =
-            "Inflicts regular damage.  Has a \$effect_chance% chance to paralyze" + " the target.",
-          shortEffect = "Has a \$effect_chance% chance to paralyze the target.",
+          effect = "Inflicts regular damage.  Has a 30% chance to paralyze the target.",
+          shortEffect = "Has a 30% chance to paralyze the target.",
           language = NamedApiResource("en", "language", 9),
         ),
       )
@@ -64,7 +63,7 @@ class MoveTest {
       assertContains(
         machines,
         MachineVersionDetail(
-          machine = ApiResource("machine", 127),
+          machine = ApiResource("machine", 142),
           versionGroup = NamedApiResource("red-blue", "version-group", 1),
         ),
       )