Optimizer does not operate

[RedViper9]

Looks like the board was wiped completely clean but I'm still having an issue with this sooooo repost!

Expected Behavior

PokemonOptimizer transfers pokemon that do not meet the criteria given in "rules"

"rules": [
                    {
                        "mode": "by_family",
                        "top": 2,
                        "sort": ["ivcp"],
                        "evolve": true,
                        "upgrade": false
                    },
                    {
                        "mode": "by_pokemon",
                        "top": 2,
                        "sort": ["attack_perfection"],
                        "evolve": false,
                        "upgrade": {"ivcp": 0.8}
                    },
                    {
                        "mode": "by_pokemon",
                        "top": 2,
                        "sort": ["defense_perfection"],
                        "evolve": false,
                        "upgrade": {"ivcp": 0.8}
                    }
                ]

Actual Behavior

No pokemon are being transferred.

Config

http://pastebin.com/rW7vStGC

Output

http://pastebin.com/GeFgfaqG

Other Information

OS: Mint 18

Branch: Dev

Git Commit: fbe0507
Python Version: 2.7.12

Workaround

Replacing attack_perfection and defense_perfection with dps_attack and dps_defense, respectively, lets the task run.

                "rules": [
                    {
                        "mode": "by_family",
                        "top": 2,
                        "sort": ["ivcp"],
                        "evolve": true,
                        "upgrade": false
                    },
                    {
                        "mode": "by_family",
                        "top": 1,
                        "sort": ["dps_attack"],
                        "evolve": false,
                        "upgrade": true
                    },
                    {
                        "mode": "by_family",
                        "top": 1,
                        "sort": ["dps_defense"],
                        "evolve": false,
                        "upgrade": true
                    }
                ]

[douglascamata]

People are contacting github staff to ask for the possibility of restoring all the issues and pull requested we had. (just saying)

[RedViper9]

@douglascamata No worries. If this gets thrown out, I'll just update my previous post.

[julienlavergne]

@RedViper9 Your configuration looks OK, but you are keeping up to 4 Pokemon of each name + 2 per family, which goes way over the 250 of your bag.

Maybe you do not need to keep the 2 best attack and defense of every Pokemon since they reroll their moves when they evolve. You might just want to target the evolved ones for that, or the one with a minimum cp.

[RedViper9]

@anakin5 I was concerned about the number of pokemon kept, but I believe Selection of Rule 1 and Selection of Rule 2 are allowed to overlap. That would mean that those top 2 by ivcp and those top 2 by attack_perfection may overlap? Prior to the update to the Optimizer, I was using a similar configuration and was keeping 1-2 per family (except for Eevee's).

The issue at present is that PokemonOptimizer will not use attack_perfection and defense_perfection sorting methods. When I changed these to dps_attack and dps_defense, respectively, the task started working just fine.

[julienlavergne]

Why is it an issue ?