Code Submission Rules

Follow these rules and suggestions if you want to submit code to this codebase, please.

Rules:

1. This is always subject to change. As the needs of the server change, this will be updated.
2. The Development and Server Staff have final say in what code gets merged, and what code does not.
3. Anyone is free to contribute to the codebase, unless specifically prohibited. The Server and Development Staff reserve the right to deny PRs from contributors who have repeatedly added bad or sneaky code.
4. Please make use of the information on the Wiki tab of our GitHub, it helps us help you fix whatever issues you may be having. (https://github.com/PolarisSS13/Polaris/wiki)
5. Most features will be not be merged for at least 24 hours after being posted. This is to allow time for discussion by the staff and community. Bugfixes may be merged before that time, at the Development Staff’s discretion.
6. Development Staff are not to merge their own PRs, excepting certain circumstances, such as critical bugfixes or permission from Head Staff.
7. List your changes in the first post of your PR. Modified sprites, especially, take a long time to review if you don’t specifically name them in your opening comment.
8. Compile, run, and test your code before committing. This will catch many of the most obvious bugs and runtimes that show up.
9. Never assume your code will be merged. We greatly appreciate the work our non-Developer coders do, but not everything will make it in.
10. If you are unwilling to correct your code, should it be merged and issues found, it will be removed.

Suggestions:

1. Discuss your ideas with the Staff before you begin coding. It’s much simpler for the staff to discuss and decide on ideas, rather than actual code, and it saves everybody time.
2. Keep your Pull Requests simple, specific, and serious, ie: adding one feature, fixing one bug, or changing a few minor things in the same general code. The more complicated your PR, the longer it takes to get reviewed and discussed.
3. Please make changes that have been requested by the Development Staff. If you are unable or unwilling to make these changes, the Development Staff may close your PR.
4. Please be patient. New features, especially those that have not been previously discussed, take time to assess and discuss. The Development Staff will attempt to keep the PR’s creator informed on the status of the decision.
5. Don’t be discouraged if your code isn’t merged. Not everything makes it in, but we really do appreciate the work that gets done.