feat: update azurerm to 4.23.0 (fixing problems)

lorenzocorallo · lorenzocorallo · commit 947379caa90c · 2025-03-20T15:35:27.000+01:00
diff --git a/.terraform.lock.hcl b/.terraform.lock.hcl
diff --git a/access_key.sh b/access_key.sh
@@ -1 +1,2 @@
+export ARM_SUBSCRIPTION_ID=$(az account show --query 'id' -o tsv)
 export ARM_ACCESS_KEY=$(az storage account keys list --resource-group rg-polinetwork --account-name polinetworksa --query '[0].value' -o tsv)
diff --git a/features.tf b/features.tf
@@ -1,5 +1,5 @@
 provider "azurerm" {
   features {}
-  skip_provider_registration = true
+  resource_provider_registrations = "core"
   use_oidc                   = true
 }
diff --git a/modules/aks/k8s.tf b/modules/aks/k8s.tf
@@ -15,7 +15,6 @@ resource "azurerm_kubernetes_cluster" "k8s" {
   }
 
   azure_active_directory_role_based_access_control {
-    managed            = true
     azure_rbac_enabled = true
     admin_group_object_ids = [
       "57561933-3873-400d-be92-cdad68d57c1f",
@@ -37,7 +36,7 @@ resource "azurerm_kubernetes_cluster" "k8s" {
     os_disk_type                = "Managed"
     os_disk_size_gb             = 30
     orchestrator_version        = var.kubernetes_orchestrator_version
-    enable_auto_scaling         = true
+    auto_scaling_enabled         = true
     max_count                   = 1
     min_count                   = 1
     node_count                  = 1
@@ -68,7 +67,7 @@ resource "azurerm_kubernetes_cluster_node_pool" "systempool" {
   mode                  = each.value.mode == null ? "User" : each.value.mode
   tags                  = each.value.tags
   orchestrator_version  = var.kubernetes_orchestrator_version
-  enable_auto_scaling   = each.value.enable_auto_scaling
+  auto_scaling_enabled  = each.value.enable_auto_scaling
   max_count             = each.value.max_count
   min_count             = each.value.min_count
 }
diff --git a/modules/aks/providers.tf b/modules/aks/providers.tf
@@ -7,7 +7,7 @@ terraform {
     }
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     helm = {
       source  = "hashicorp/helm"
diff --git a/modules/app/versions.tf b/modules/app/versions.tf
@@ -3,7 +3,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     kubernetes = {
       source  = "hashicorp/kubernetes"
diff --git a/modules/argocd/providers.tf b/modules/argocd/providers.tf
@@ -7,7 +7,7 @@ terraform {
     }
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     helm = {
       source  = "hashicorp/helm"
diff --git a/modules/bots-migration/bots.tf b/modules/bots-migration/bots.tf
@@ -2,6 +2,7 @@ resource "random_uuid" "volume" {
 }
 
 resource "kubernetes_namespace" "bot-namespace" {
+  
   metadata {
     name = var.bot_namespace
   }
diff --git a/modules/bots-migration/versions.tf b/modules/bots-migration/versions.tf
@@ -3,7 +3,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     random = {
       source  = "hashicorp/random"
diff --git a/modules/bots/versions.tf b/modules/bots/versions.tf
@@ -3,7 +3,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     random = {
       source  = "hashicorp/random"
diff --git a/modules/keyvault/providers.tf b/modules/keyvault/providers.tf
@@ -3,7 +3,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
   }
-}
+}
diff --git a/modules/mariadb/providers.tf b/modules/mariadb/providers.tf
@@ -7,7 +7,7 @@ terraform {
     }
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
   }
 }
diff --git a/modules/monitoring/providers.tf b/modules/monitoring/providers.tf
@@ -7,7 +7,7 @@ terraform {
     }
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     helm = {
       source  = "hashicorp/helm"
diff --git a/modules/storage/providers.tf b/modules/storage/providers.tf
@@ -3,7 +3,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
   }
-}
+}
diff --git a/providers.tf b/providers.tf
@@ -7,7 +7,7 @@ terraform {
     }
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.63.0"
+      version = "=4.23.0"
     }
     helm = {
       source  = "hashicorp/helm"

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+export ARM_SUBSCRIPTION_ID=$(az account show --query 'id' -o tsv)`
`1`	`2`	`export ARM_ACCESS_KEY=$(az storage account keys list --resource-group rg-polinetwork --account-name polinetworksa --query '[0].value' -o tsv)`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`provider "azurerm" {`
`2`	`2`	`features {}`
`3`		`- skip_provider_registration = true`
	`3`	`+ resource_provider_registrations = "core"`
`4`	`4`	`use_oidc = true`
`5`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ terraform {`
`7`	`7`	`}`
`8`	`8`	`azurerm = {`
`9`	`9`	`source = "hashicorp/azurerm"`
`10`		`- version = "3.63.0"`
	`10`	`+ version = "=4.23.0"`
`11`	`11`	`}`
`12`	`12`	`helm = {`
`13`	`13`	`source = "hashicorp/helm"`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ terraform {`
`3`	`3`	`required_providers {`
`4`	`4`	`azurerm = {`
`5`	`5`	`source = "hashicorp/azurerm"`
`6`		`- version = "3.63.0"`
	`6`	`+ version = "=4.23.0"`
`7`	`7`	`}`
`8`	`8`	`kubernetes = {`
`9`	`9`	`source = "hashicorp/kubernetes"`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ resource "random_uuid" "volume" {`
`2`	`2`	`}`
`3`	`3`
`4`	`4`	`resource "kubernetes_namespace" "bot-namespace" {`
	`5`	`+`
`5`	`6`	`metadata {`
`6`	`7`	`name = var.bot_namespace`
`7`	`8`	`}`