fix: Ensure that NYC still uses Pooled 3-Year CPS

Author: anth-volk

policyengine_api/services/economy_service.py

@@ -484,6 +484,10 @@ def _setup_data(
         if dataset == "enhanced_cps":
             return "gs://policyengine-us-data/enhanced_cps_2024.h5"
 
+        # NYC simulations must reference pooled CPS dataset
+        if region == "nyc":
+            return "gs://policyengine-us-data/pooled_3_year_cps_2023.h5"
+
         # All others (including US state-level simulations) receive no sim API 'data' arg
         return None
 

tests/unit/services/test_economy_service.py

@@ -733,6 +733,21 @@ def test__given_us_state_dataset__returns_none(self):
             # Assert the expected value
             assert result is None
 
+        def test__given_nyc_region__returns_pooled_cps(self):
+            # Test with NYC region - should return pooled CPS dataset
+            dataset = None
+            country_id = "us"
+            region = "nyc"
+
+            # Create an instance of the class
+            service = EconomyService()
+            # Call the method
+            result = service._setup_data(dataset, country_id, region)
+            # Assert the expected value
+            assert (
+                result == "gs://policyengine-us-data/pooled_3_year_cps_2023.h5"
+            )
+
         def test__given_us_nationwide_dataset__returns_none(self):
             # Test with US nationwide dataset
             dataset = "us_nationwide"