Skip to content

Conversation

@nikhilwoodruff
Copy link
Contributor

No description provided.

@nikhilwoodruff nikhilwoodruff added the enhancement New feature or request label Mar 31, 2025
@nikhilwoodruff nikhilwoodruff self-assigned this Mar 31, 2025
@nikhilwoodruff nikhilwoodruff marked this pull request as draft March 31, 2025 13:52
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review April 1, 2025 10:14
@nikhilwoodruff
Copy link
Contributor Author

Thanks @PavelMakarchuk for adding rent imputation back in- would you mind using the data generated locally from this and running a few reform tests locally with e.g. SALT/AMT/TCJA reforms you're focussing on? So we know it definitely fixes the issue and doesn't add weird results.

@PavelMakarchuk
Copy link
Collaborator

PavelMakarchuk commented Apr 1, 2025

The results are very similar to web app impacts of e.g. repealing different itemized deductions or extending the SALT cap

TCJA web app (2026): 372.2bn

TCJA locally w/ smaller dataset (2026): 373.1

We can run static simulations with the itemized branching (~8min local run time) but I am unable to run itemized branching in combination with behavioral responses - running out of memory every time

@nikhilwoodruff

@nikhilwoodruff
Copy link
Contributor Author

OK good enough to merge this then- let's keep thinking about the memory issue.

@nikhilwoodruff nikhilwoodruff merged commit fe4acf9 into main Apr 1, 2025
2 checks passed
@nikhilwoodruff nikhilwoodruff deleted the reweight-subsample branch April 1, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants