Fix get_menu_items in FAB auth manager (apache#47688)

Author: vincbeck

providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py

@@ -447,33 +447,27 @@ def get_menu_items(self, *, user: User) -> list[MenuItem]:
             {
                 "resource_type": "List Users",
                 "text": "Users",
-                "href": AUTH_MANAGER_FASTAPI_APP_PREFIX
-                + url_for(f"{self.security_manager.user_view.__class__.__name__}.list", _external=False),
+                "href": f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/users/list/",
             },
             {
                 "resource_type": "List Roles",
                 "text": "Roles",
-                "href": AUTH_MANAGER_FASTAPI_APP_PREFIX
-                + url_for("CustomRoleModelView.list", _external=False),
+                "href": f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/roles/list/",
             },
             {
                 "resource_type": "Actions",
                 "text": "Actions",
-                "href": AUTH_MANAGER_FASTAPI_APP_PREFIX + url_for("ActionModelView.list", _external=False),
+                "href": f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/actions/list/",
             },
             {
                 "resource_type": "Resources",
                 "text": "Resources",
-                "href": AUTH_MANAGER_FASTAPI_APP_PREFIX + url_for("ResourceModelView.list", _external=False),
+                "href": f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/resources/list/",
             },
             {
                 "resource_type": "Permission Pairs",
                 "text": "Permissions",
-                "href": AUTH_MANAGER_FASTAPI_APP_PREFIX
-                + url_for(
-                    "PermissionPairModelView.list",
-                    _external=False,
-                ),
+                "href": f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/permissions/list/",
             },
         ]
 

providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py

@@ -592,8 +592,7 @@ def test_logout(self, mock_logout_user, auth_manager_with_appbuilder):
 
     @mock.patch.object(FabAuthManager, "_is_authorized", return_value=True)
     def test_get_menu_items(self, _, auth_manager_with_appbuilder, flask_app):
-        with flask_app.app_context():
-            auth_manager_with_appbuilder.register_views()
-            result = auth_manager_with_appbuilder.get_menu_items(user=Mock())
-            assert len(result) == 5
-            assert all(item.href.startswith(AUTH_MANAGER_FASTAPI_APP_PREFIX) for item in result)
+        auth_manager_with_appbuilder.register_views()
+        result = auth_manager_with_appbuilder.get_menu_items(user=Mock())
+        assert len(result) == 5
+        assert all(item.href.startswith(AUTH_MANAGER_FASTAPI_APP_PREFIX) for item in result)