Skip to content

Commit 3e1b02a

Browse files
authored
Migrate remaining providers to common.compat compatibility layer in singularity (apache#57077)
* Migrate remaining providers to common.compat compatibility layer * remove extra modification
1 parent f781967 commit 3e1b02a

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

providers/singularity/pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ requires-python = ">=3.10"
5858
# After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
5959
dependencies = [
6060
"apache-airflow>=2.10.0",
61+
"apache-airflow-providers-common-compat>=1.7.4", # + TODO: bump to next version
6162
"spython>=0.0.56",
6263
]
6364

@@ -66,6 +67,7 @@ dev = [
6667
"apache-airflow",
6768
"apache-airflow-task-sdk",
6869
"apache-airflow-devel-common",
70+
"apache-airflow-providers-common-compat",
6971
# Additional devel dependencies (do not remove this line and add extra development dependencies)
7072
]
7173

providers/singularity/src/airflow/providers/singularity/operators/singularity.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
from spython.main import Client
2727

2828
from airflow.exceptions import AirflowException
29-
from airflow.providers.singularity.version_compat import BaseOperator
29+
from airflow.providers.common.compat.sdk import BaseOperator
3030

3131
if TYPE_CHECKING:
32-
from airflow.providers.singularity.version_compat import Context
32+
from airflow.providers.common.compat.sdk import Context
3333

3434

3535
class SingularityOperator(BaseOperator):

providers/singularity/src/airflow/providers/singularity/version_compat.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,4 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
2929

3030
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
3131

32-
if AIRFLOW_V_3_0_PLUS:
33-
from airflow.sdk import BaseOperator
34-
from airflow.sdk.definitions.context import Context
35-
else:
36-
from airflow.models import BaseOperator
37-
from airflow.utils.context import Context
38-
39-
__all__ = ["AIRFLOW_V_3_0_PLUS", "BaseOperator", "Context"]
32+
__all__ = ["AIRFLOW_V_3_0_PLUS"]

0 commit comments

Comments
 (0)