Skip to content

Commit febde14

Browse files
AIP-38 Fix dialog note state (apache#47071)
1 parent 2c13c18 commit febde14

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

airflow/ui/src/components/Clear/Run/ClearRunButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const ClearRunButton = ({ dagRun, withText = true }: Props) => {
4242
withText={withText}
4343
/>
4444

45-
<ClearRunDialog dagRun={dagRun} onClose={onClose} open={open} />
45+
{open ? <ClearRunDialog dagRun={dagRun} onClose={onClose} open={open} /> : undefined}
4646
</Box>
4747
);
4848
};

airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceButton.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ const ClearTaskInstanceButton = ({ taskInstance, withText = true }: Props) => {
4242
withText={withText}
4343
/>
4444

45-
<ClearTaskInstanceDialog onClose={onClose} open={open} taskInstance={taskInstance} />
45+
{open ? (
46+
<ClearTaskInstanceDialog onClose={onClose} open={open} taskInstance={taskInstance} />
47+
) : undefined}
4648
</Box>
4749
);
4850
};

airflow/ui/src/components/MarkAs/Run/MarkRunAsButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const MarkRunAsButton = ({ dagRun, withText = true }: Props) => {
7171
</Menu.Content>
7272
</Menu.Root>
7373

74-
<MarkRunAsDialog dagRun={dagRun} onClose={onClose} open={open} state={state} />
74+
{open ? <MarkRunAsDialog dagRun={dagRun} onClose={onClose} open={open} state={state} /> : undefined}
7575
</Box>
7676
);
7777
};

airflow/ui/src/components/MarkAs/TaskInstance/MarkTaskInstanceAsButton.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ const MarkTaskInstanceAsButton = ({ taskInstance, withText = true }: Props) => {
7272
</Menu.Content>
7373
</Menu.Root>
7474

75-
<MarkTaskInstanceAsDialog onClose={onClose} open={open} state={state} taskInstance={taskInstance} />
75+
{open ? (
76+
<MarkTaskInstanceAsDialog onClose={onClose} open={open} state={state} taskInstance={taskInstance} />
77+
) : undefined}
7678
</Box>
7779
);
7880
};

0 commit comments

Comments
 (0)