Skip to content

Commit 064ed60

Browse files
committed
Fix bug on copy of DataFrame
1 parent 7070f84 commit 064ed60

File tree

3 files changed

+52
-0
lines changed

3 files changed

+52
-0
lines changed

src/DataFrame-Tests/DataFrameTest.class.st

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,33 @@ DataFrameTest >> testColumnsSubset [
898898
self assert: actualDataFrame equals: expectedDataFrame
899899
]
900900

901+
{ #category : #tests }
902+
DataFrameTest >> testCopy [
903+
904+
| copy |
905+
copy := df copy.
906+
907+
self assert: copy equals: df.
908+
self deny: copy identicalTo: df.
909+
910+
df addRow: #( 'Paris' 7 false ) named: 'D'.
911+
912+
self assert: df size equals: 4.
913+
self assert: copy size equals: 3
914+
]
915+
916+
{ #category : #tests }
917+
DataFrameTest >> testCopy2 [
918+
919+
| copy |
920+
copy := df copy.
921+
922+
df addColumn: #( false true true ) named: 'Like it'.
923+
924+
self assert: df numberOfColumns equals: 4.
925+
self assert: copy numberOfColumns equals: 3
926+
]
927+
901928
{ #category : #tests }
902929
DataFrameTest >> testCreateDataFrameWith3ColumnsAndNoRows [
903930
| dataFrame |

src/DataFrame-Tests/DataSeriesTest.class.st

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -993,6 +993,21 @@ DataSeriesTest >> testCollectWithNotNils [
993993
self assert: actual equals: expected
994994
]
995995

996+
{ #category : #running }
997+
DataSeriesTest >> testCopy [
998+
999+
| copy |
1000+
copy := series copy.
1001+
1002+
self assert: copy equals: series.
1003+
self deny: copy identicalTo: series.
1004+
1005+
series add: $l -> 30.
1006+
1007+
self assert: series size equals: 12.
1008+
self assert: copy size equals: 11
1009+
]
1010+
9961011
{ #category : #'tests - copying' }
9971012
DataSeriesTest >> testCopyCanBeChanged [
9981013

src/DataFrame/DataFrame.class.st

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,6 +1412,16 @@ DataFrame >> outerJoin: aDataFrame onLeft: leftColumn onRight: rightColumn [
14121412
^ outputDf
14131413
]
14141414

1415+
{ #category : #copying }
1416+
DataFrame >> postCopy [
1417+
1418+
super postCopy.
1419+
contents := contents copy.
1420+
rowNames := rowNames copy.
1421+
columnNames := columnNames copy.
1422+
dataTypes := dataTypes copy
1423+
]
1424+
14151425
{ #category : #printing }
14161426
DataFrame >> printOn: aStream [
14171427

0 commit comments

Comments
 (0)