Skip to content

Commit 09ded47

Browse files
committed
Closed #87. Fixed the way how a name is chosen for a result of applying a binary operation to two series
1 parent 413e4bf commit 09ded47

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

src/DataFrame-Tests/DataSeriesTest.class.st

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ DataSeriesTest >> testArithmeticsAddSeriesToSeriesSameKeysDifferentName [
100100
firstSeries := DataSeries withKeys: #(a b c) values: #(1 2 3) name: #X.
101101
secondSeries := DataSeries withKeys: #(a b c) values: #(3 4 5) name: #Y.
102102

103-
expected := DataSeries withKeys: #(a b c) values: #(4 6 8) name: '(no name)'.
103+
expected := DataSeries withKeys: #(a b c) values: #(4 6 8) name: #X.
104104
actual := firstSeries + secondSeries.
105105

106106
self assert: actual equals: expected.
@@ -183,7 +183,7 @@ DataSeriesTest >> testArithmeticsDivideSeriesBySeriesSameKeysDifferentName [
183183
firstSeries := DataSeries withKeys: #(a b c) values: #(1 2 3) name: #X.
184184
secondSeries := DataSeries withKeys: #(a b c) values: #(3 4 5) name: #Y.
185185

186-
expected := DataSeries withKeys: #(a b c) values: { 1/3 . 1/2 . 3/5 } name: '(no name)'.
186+
expected := DataSeries withKeys: #(a b c) values: { 1/3 . 1/2 . 3/5 } name: #X.
187187
actual := firstSeries / secondSeries.
188188

189189
self assert: actual equals: expected.
@@ -277,7 +277,7 @@ DataSeriesTest >> testArithmeticsMultiplySeriesBySeriesSameKeysDifferentName [
277277
firstSeries := DataSeries withKeys: #(a b c) values: #(1 2 3) name: #X.
278278
secondSeries := DataSeries withKeys: #(a b c) values: #(3 4 5) name: #Y.
279279

280-
expected := DataSeries withKeys: #(a b c) values: #(3 8 15) name: '(no name)'.
280+
expected := DataSeries withKeys: #(a b c) values: #(3 8 15) name: #X.
281281
actual := firstSeries * secondSeries.
282282

283283
self assert: actual equals: expected.
@@ -371,7 +371,7 @@ DataSeriesTest >> testArithmeticsSubtractSeriesFromSeriesSameKeysDifferentName [
371371
firstSeries := DataSeries withKeys: #(a b c) values: #(1 2 3) name: #X.
372372
secondSeries := DataSeries withKeys: #(a b c) values: #(3 4 5) name: #Y.
373373

374-
expected := DataSeries withKeys: #(a b c) values: #(-2 -2 -2) name: '(no name)'.
374+
expected := DataSeries withKeys: #(a b c) values: #(-2 -2 -2) name: #X.
375375
actual := firstSeries - secondSeries.
376376

377377
self assert: actual equals: expected.

src/DataFrame/DataFrame.class.st

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -865,6 +865,14 @@ DataFrame >> initializeRows: anArrayOfArrays [
865865
self setDefaultRowColumnNames.
866866
]
867867

868+
{ #category : #enumerating }
869+
DataFrame >> inject: thisValue into: binaryBlock [
870+
| series |
871+
series := super inject: thisValue into: binaryBlock.
872+
series name: series defaultName.
873+
^ series
874+
]
875+
868876
{ #category : #statistics }
869877
DataFrame >> interquartileRange [
870878

src/DataFrame/DataSeries.class.st

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -617,10 +617,7 @@ DataSeries >> withSeries: otherDataSeries collect: twoArgBlock [
617617
otherDataSeries keys = self keys ifFalse: [ self errorKeysMismatch ].
618618

619619
result := self species new: self size.
620-
621-
result name: ((otherDataSeries name = self name)
622-
ifTrue: [ self name ]
623-
ifFalse: [ self defaultName ]).
620+
result name: self name.
624621

625622
self keysDo: [ :key |
626623
result at: key put:

0 commit comments

Comments
 (0)