Skip to content

Commit 8a1f547

Browse files
committed
Don't use #= in asserts
1 parent b91b104 commit 8a1f547

File tree

2 files changed

+13
-19
lines changed

2 files changed

+13
-19
lines changed

src/DataFrame-Tests/DataFrameInternalTest.class.st

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,10 @@ DataFrameInternalTest >> testCreateDataFrameInternalWithRows [
229229
DataFrameInternalTest >> testDeepCopy [
230230

231231
| dfCopy |
232-
233232
dfCopy := df deepCopy.
234-
233+
235234
self assert: df equals: dfCopy.
236-
self deny: df == dfCopy.
235+
self deny: df identicalTo: dfCopy
237236
]
238237

239238
{ #category : #tests }

src/DataFrame-Tests/DataFrameTest.class.st

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,12 +1543,11 @@ DataFrameTest >> testDoCanModifyRows [
15431543
DataFrameTest >> testEquality [
15441544

15451545
| df1 df2 |
1546-
1547-
df1 := DataFrame withRows: #((1 2)(3 4)).
1548-
df2 := DataFrame withRows: #((1 2)(3 4)).
1549-
1546+
df1 := DataFrame withRows: #( #( 1 2 ) #( 3 4 ) ).
1547+
df2 := DataFrame withRows: #( #( 1 2 ) #( 3 4 ) ).
1548+
15501549
self assert: df1 equals: df2.
1551-
self assert: (df1 = df2).
1550+
self assert: df1 equals: df2
15521551
]
15531552

15541553
{ #category : #'find-select' }
@@ -1597,22 +1596,18 @@ DataFrameTest >> testFindAllIndicesOfAtColumnFloat [
15971596
DataFrameTest >> testHasNils [
15981597

15991598
| df1 df2 |
1600-
df1 := DataFrame withRows:
1601-
#( #( nil 1.609 true ) #( Dubai 2.789 nil )
1602-
#( nil 8.788 false ) ).
1599+
df1 := DataFrame withRows: #( #( nil 1.609 true ) #( Dubai 2.789 nil ) #( nil 8.788 false ) ).
16031600
df1 rowNames: #( A B C ).
16041601
df1 columnNames: #( City Population BeenThere ).
16051602

16061603
self assert: df1 hasNils.
16071604

1608-
df2 := DataFrame withRows:
1609-
#( #( Barcelona 1.609 true ) #( Dubai 2.789 true )
1610-
#( London 8.788 false ) ).
1605+
df2 := DataFrame withRows: #( #( Barcelona 1.609 true ) #( Dubai 2.789 true ) #( London 8.788 false ) ).
16111606

16121607
df2 rowNames: #( A B C ).
16131608
df2 columnNames: #( City Population BeenThere ).
16141609

1615-
self assert: df2 hasNils equals: false
1610+
self deny: df2 hasNils
16161611
]
16171612

16181613
{ #category : #replacing }
@@ -1740,10 +1735,10 @@ DataFrameTest >> testInequality [
17401735
df5 := DataFrame withRows: #( #( 1 2 ) #( 3 5 ) ).
17411736
df5 rowNames: #( a b ).
17421737
df5 columnNames: #( x z ).
1743-
self deny: df2 = df1.
1744-
self deny: df3 = df1.
1745-
self deny: df4 = df1.
1746-
self deny: df5 = df1
1738+
self deny: df2 equals: df1.
1739+
self deny: df3 equals: df1.
1740+
self deny: df4 equals: df1.
1741+
self deny: df5 equals: df1
17471742
]
17481743

17491744
{ #category : #splitjoin }

0 commit comments

Comments
 (0)