Issue 154 Refactoring - Make The Test More Specific By Breaking It Up (#171)

* [issue-154] Extracted the actual object being asserted on to a better named local variable.

* [issue-154] Broke the tests up so that they#re more specific.

* [issue-154] Extracted the 'act' part to a role-revealing local variable.

* [issue-154] Extracted a method where the key is passed in explicitly, thereby avoiding magic.

* [issue-154] Improved the name of the variable.

Author: hemalvarambhia

src/Math-Tests-Accuracy/PMAccuracyTest.class.st

@@ -83,15 +83,29 @@ PMAccuracyTest >> testDecimalPlaces [
 ]
 
 { #category : #tests }
-PMAccuracyTest >> testExtractFromResultsWhichOnlyOne [
-	self
-		assert: (a extractFromResults: #('bla' 'blah') which: 2 onlyOne: false)
-		equals: 'blah'.
-	self assert: a testGetterAaa second equals: #(true).
-	self
-		assert: (a extractFromResults: #('bla' 'blah') which: 1 onlyOne: true)
-		equals: #('bla' 'blah').
-	self assert: a testGetterAaa second equals: #(#(false) #(true))
+PMAccuracyTest >> testExtractFromResultsReturnsAllElementsWhenOnlyOneIsTrue [
+	| argument results |
+	results := a
+		extractFromResults: #('bla' 'blah')
+		which: 1
+		onlyOne: true.
+	
+	self assert: results equals: #('bla' 'blah').
+	argument := a testGetterAaa second.
+	self assert: argument equals: #(#(false) #(true))
+]
+
+{ #category : #tests }
+PMAccuracyTest >> testExtractFromResultsReturnsTheCorrectIndexedElementWhenOnlyOneIsFalse [
+	| argument results |
+	results := a
+		extractFromResults: #('bla' 'blah')
+		which: 2
+		onlyOne: false.
+
+	self assert: results equals: 'blah'.
+	argument := a testGetterAaa second.
+	self assert: argument equals: #(true)
 ]
 
 { #category : #tests }

src/Math-Tests-Accuracy/PMAccuracyTestExample.class.st

@@ -13,6 +13,14 @@ Class {
 	#category : #'Math-Tests-Accuracy'
 }
 
+{ #category : #private }
+PMAccuracyTestExample >> argumentWith: key [ 
+	| theArgument |
+	theArgument := self argumentAt: key.
+	numberOfResults ifNotNil: [ :rn | theArgument := theArgument at: rn ].
+	^ theArgument
+]
+
 { #category : #tests }
 PMAccuracyTestExample >> checkAaa [
 	self argument first
@@ -146,7 +154,7 @@ PMAccuracyTestExample >> tearDown [
 PMAccuracyTestExample >> testGetterAaa [
 ^Array
 	with: self parameter
-	with: self argument
+	with: (self argumentWith: 'Aaa')
 	with: (self resultsAt: 'Aaa')
 	with: (self numberOfDifferentParametersAt: 'Aaa')
 	with: (self numberOfDifferentResultsAt: 'Aaa')
@@ -156,7 +164,7 @@ PMAccuracyTestExample >> testGetterAaa [
 PMAccuracyTestExample >> testGetterBbb [
 ^Array
 	with: self parameter
-	with: self argument
+	with: (self argumentWith: 'Bbb')
 	with: (self resultsAt: 'Bbb')
 	with: (self numberOfDifferentParametersAt: 'Bbb')
 	with: (self numberOfDifferentResultsAt: 'Bbb')