Removed some more references to random and cleaned up the code

Author: olekscode

src/Math-Core/PMVector.class.st

@@ -27,8 +27,12 @@ Class {
 PMVector class >> new: size random: maxRandomNumber [ 
 	"Answer an instance of me, with number of elements equal to size, each 
 	a randomNumber lower than maxRandomNumber ."
+	
+	| random |
+	random := Random new.
 
-	^self newFrom:  ( (1 to: size ) collect: [:e|maxRandomNumber random ]  )
+	^ self newFrom: ((1 to: size ) collect: [ :each |
+		random nextBetween: 0 and: maxRandomNumber ]).
 ]
 
 { #category : #private }
@@ -43,10 +47,14 @@ PMVector class >> ones: anInteger [
 { #category : #private }
 PMVector class >> randomSize: anInteger maxNumber: aMaxNumber [
 	"Creates a vector of rand numbers from 0 to aMaxNumber."
-	|a|
-	a := PMVector new: anInteger.
-	1 to: a size do: [ :n | a at: n put: (aMaxNumber random)].
-	^a
+	| random vector |
+	random := Random new.
+	
+	vector := PMVector new: anInteger.
+	1 to: vector size do: [ :i |
+		vector at: i put: (random nextBetween: 0 and: aMaxNumber)].
+	
+	^ vector
 ]
 
 { #category : #private }

src/Math-Matrix/PMMatrix.class.st

@@ -146,14 +146,16 @@ PMMatrix class >> rows: nRows columns: nCols  element: fillElement [
 ]
 
 { #category : #'as yet unclassified' }
-PMMatrix class >> rows: rows columns: columns random: aMaxNumber [
+PMMatrix class >> rows: aNumberOfRows columns: aNumberOfColumns random: aMaxNumber [
 	"Answer a new Matrix of the given dimensions filled with random numbers"
-	|a b|
-	a:=	(1 to: rows) collect: [:row |b:=PMVector new:columns .
-		1 to: columns do: [:column |
-			b  at: column put: (aMaxNumber random)].
-		b].
-	^PMMatrix rows: a
+	| random rows |
+	random := Random new.
+	
+	rows := (1 to: aNumberOfRows) collect: [ :i |
+		(1 to: aNumberOfColumns) collect: [ :j |
+			random nextBetween: 0 and: aMaxNumber ] ].
+	
+	^ self rows: rows
 ]
 
 { #category : #'instance creation' }

src/Math-Matrix/PMSymmetricMatrix.class.st

@@ -58,15 +58,21 @@ aBlock value: RowposRespectivelyColpos value: ColposRespectivelyRowpos"
 { #category : #'as yet unclassified' }
 PMSymmetricMatrix class >> new: dim random: aMaxNumber [
 	"Answer a new symmetric matrix of the given dimensions filled with random numbers"
-	|a aRow|
-	a:=self new:dim .
-	1 to: dim do:[:i|a rowAt: 1 columnAt: i put: (aMaxNumber random)].
-	2 to: dim do: [:rowPos|
+	| matrix random aRow |
+	
+	matrix := self new: dim.
+	random := Random new.
+	
+	1 to: dim do: [ :i |
+		matrix rowAt: 1 columnAt: i put: (random nextBetween: 0 and: aMaxNumber)].
+	
+	2 to: dim do: [ :j |
 		aRow :=PMVector new: dim .
-		1 to: rowPos -1 do:[:pos| aRow at: pos put: (a rowAt: pos columnAt: rowPos)  ] .
-		rowPos to: dim do:[:pos| aRow at: pos put: (aMaxNumber random) ]. 
-		(a rows) at: rowPos put: aRow ]  .    
-	^a 
+		
+		1 to: j - 1 do: [ :i | aRow at: i put: (matrix rowAt: i columnAt: j) ].
+		j to: dim do: [ :i | aRow at: i put: (random nextBetween: 0 and: aMaxNumber) ]. 
+		(matrix rows) at: j put: aRow ]  .    
+	^ matrix 
 ]
 
 { #category : #'as yet unclassified' }

src/Math-TSNE/PMTSNE.class.st

@@ -438,16 +438,17 @@ PMTSNE >> initializeYWithRandomValues [
 	"Answer a new Matrix Y with the number of rows of x and number of columns ndims filled with random numbers following a normal distribution (0,1)"
 	"We should add this to PMMatrix API later"
 
-	| a b rows columns d |
-	rows := x dimension x.
-	columns := outputDims.
-	d := PMNormalDistribution new:0 sigma: 1.
-	a := (1 to: rows)
-		collect: [ :row | 
-			b := PMVector new: columns.
-			1 to: columns do: [ :column | b at: column put: d random ].
-			b ].
-	y := PMMatrix rows: a
+	| numberOfRows numberOfColumns distribution rows |
+	
+	numberOfRows := x dimension x.
+	numberOfColumns := outputDims.
+	distribution := PMNormalDistribution new: 0 sigma: 1.
+	
+	rows := (1 to: numberOfRows) collect: [ :i | 
+		(1 to: numberOfColumns) collect: [ :j |
+			distribution random ] ].
+	
+	y := PMMatrix rows: rows
 ]
 
 { #category : #accessing }

src/Math-Tests-FastFourierTransform/PMFFTTest.class.st

@@ -66,16 +66,22 @@ PMFFTTest >> testFastFourierTransformCalculatesTheDiscreteFourierTransformWithou
 { #category : #tests }
 PMFFTTest >> testFrequencyDomainRepresentationMatchesRandomizedInputSignalClosely [
 
-	| cosineWaveSignal randomizedCosineWaveSignal f |
+	| random cosineWaveSignal randomizedCosineWaveSignal fourier |
+	
 	cosineWaveSignal := self generateCosineWaveSignal: 256.
-	randomizedCosineWaveSignal := cosineWaveSignal collect: [ :i | i + 0.001 random - 0.0005 ].
-	f := PMFastFourierTransform data: randomizedCosineWaveSignal.
-
-	f transform.
-	f chop: 0.01.
-	f inverseTransform.
-
-	self assert: (f realData - cosineWaveSignal) abs max < 4e-5
+	random := Random new.
+	
+	randomizedCosineWaveSignal := cosineWaveSignal collect: [ :i |
+		i + (random nextBetween: 0 and: 0.001) - 0.0005 ].
+	
+	fourier := PMFastFourierTransform data: randomizedCosineWaveSignal.
+
+	fourier transform.
+	fourier chop: 0.01.
+	fourier inverseTransform.
+	
+	fourier realData with: cosineWaveSignal do: [ :expected :actual |
+		self assert: actual closeTo: expected precision: 4e-5 ].
 ]
 
 { #category : #tests }

src/Math-Tests-KolmogorovSmirnov/PMKolmogorovSmirnov1SampleTest.class.st

@@ -2,51 +2,51 @@ Class {
 	#name : #PMKolmogorovSmirnov1SampleTest,
 	#superclass : #TestCase,
 	#instVars : [
-		'nd',
-		'ks'
+		'distribution',
+		'test'
 	],
 	#category : #'Math-Tests-KolmogorovSmirnov'
 }
 
 { #category : #running }
 PMKolmogorovSmirnov1SampleTest >> numberOfRejectionsFor: aDistribution [
 	| n |
-	ks populationDistribution: aDistribution.
+	test populationDistribution: aDistribution.
 	n := 0.
 	1 to: 100 do: [ :j | 
-		ks data: ((1 to: 300) collect: [ :i | nd random ]).
-		(ks rejectEqualityHypothesisWithAlpha: 0.05)
+		test data: ((1 to: 300) collect: [ :i | distribution random ]).
+		(test rejectEqualityHypothesisWithAlpha: 0.05)
 			ifTrue: [ n := n + 1 ] ].
 	^ n
 ]
 
 { #category : #running }
 PMKolmogorovSmirnov1SampleTest >> setUp [
 	super setUp .
-	nd := PMNormalDistribution new.
-	ks := PMKolmogorovSmirnov1Sample new
+	distribution := PMNormalDistribution new.
+	test := PMKolmogorovSmirnov1Sample new
 ]
 
 { #category : #tests }
 PMKolmogorovSmirnov1SampleTest >> testCorrectPopulationProbabilistic [
 	"is a probabilistic test that occasionally fails, but it should happen rarely"
 
-	| d |
-	d := self numberOfRejectionsFor: (PMNormalDistribution new: 0 sigma: 1).
-	self assert: d < 20
+	| numberOfRejections |
+	numberOfRejections := self numberOfRejectionsFor: (PMNormalDistribution new: 0 sigma: 1).
+	self assert: numberOfRejections < 20
 ]
 
 { #category : #tests }
 PMKolmogorovSmirnov1SampleTest >> testRejectOfEqualityHypothesesForSampleVersusDistribution [
 	| sample |
 	"The data below are taken from http://www.maths.qmul.ac.uk/~bb/CTS_Chapter3_Students.pdf"
 	sample := #(-1.2 0.2 -0.6 0.8 -1.0).
-	ks := PMKolmogorovSmirnov1Sample
+	test := PMKolmogorovSmirnov1Sample
 		compareData: sample
-		withDistribution: nd.
+		withDistribution: distribution.
 
 	self
-		assert: (ks rejectEqualityHypothesisWithAlpha: 0.05)
+		assert: (test rejectEqualityHypothesisWithAlpha: 0.05)
 		equals: false
 ]
 

src/Math-Tests-Matrix/PMAdditionalTest.class.st

@@ -5,7 +5,7 @@ here are tests that would be in Math-Tests-DHB-Numerical, if it could construct
 Class {
 	#name : #PMAdditionalTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #tests }
@@ -17,18 +17,18 @@ PMAdditionalTest >> testMatrixInversionSmall [
 	3
 		timesRepeat: [ [ m := PMSymmetricMatrix new: 5 random: 20.
 			m determinant = 0 ] whileTrue.	"singular matrix not allowed"
-			self assert: (i := m crlInverse) * m equals: c.
+			self assert: (i := m crlInverse) * m closeTo: c.
 			self assert: i class equals: PMSymmetricMatrix.
-			self assert: (i := m inversePureLUP) * m equals: c.
+			self assert: (i := m inversePureLUP) * m closeTo: c.
 			self assert: i class equals: PMSymmetricMatrix.
-			self assert: m * (i := m inversePureCRL) equals: c.
+			self assert: m * (i := m inversePureCRL) closeTo: c.
 			self assert: i class equals: PMSymmetricMatrix ].
 	3
 		timesRepeat: [ [ m := PMMatrix rows: 5 columns: 5 random: 20.
 			m determinant = 0 ] whileTrue.
-			self assert: m * (i := m inverse) equals: c.
+			self assert: m * (i := m inverse) closeTo: c.
 			self assert: i class equals: PMMatrix.
-			self assert: (i := m inversePureCRL) * m equals: c.
+			self assert: (i := m inversePureCRL) * m closeTo: c.
 			self assert: i class equals: PMMatrix ]
 ]
 

src/Math-Tests-Matrix/PMQRTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #PMQRTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #running }
@@ -84,16 +84,20 @@ PMQRTest >> testQRFactorization [
 
 { #category : #tests }
 PMQRTest >> testRank [
-	| a i |
-	i := 0.
-	[ a := PMMatrix rows: 5 columns: 7 random: 5.0.
-	a rank = 5
-		ifTrue: [ a atRow: 2 put: (a rowAt: 1) + (3.0 random * (a rowAt: 3)).
-			a atRow: 4 put: (0.5 + 3.0 random) * (a rowAt: 5).
-			i := i + 1.
-			self assert: a rank equals: 3.
-			self assert: a transpose rank equals: 3 ].
-	i < 10 ] whileTrue
+	| random randomNumber matrix |
+	random := Random new.
+	
+	10 timesRepeat: [
+		matrix := PMMatrix rows: 5 columns: 7 random: 5.0.
+		matrix rank = 5 ifTrue: [
+			randomNumber := random nextBetween: 0 and: 3.
+			matrix atRow: 2 put: (matrix rowAt: 1) + (randomNumber * (matrix rowAt: 3)).
+			
+			randomNumber := random nextBetween: 0 and: 3.
+			matrix atRow: 4 put: (0.5 + randomNumber) * (matrix rowAt: 5).
+			
+			self assert: matrix rank equals: 3.
+			self assert: matrix transpose rank equals: 3 ] ].
 ]
 
 { #category : #tests }

src/Math-Tests-Numerical/PMStatisticsBugs.class.st

@@ -51,7 +51,7 @@ PMStatisticsBugs >> testProbabilityDensity [
 
 	"testing this method usually produces (not always and not always the same) three different errors: 'zerodivide', ' 'Function''s derivative seems to be zero everywhere' and 'Supplied derivative is not correct', the latter happens in other cases than the documented one too, i just dont remember which ones they are and i was too lazy to construct them, one example is enough"
 
-	| a b |
+	| a b random |
 	a := PMNormalDistribution new: -20 sigma: 0.7.
 	self assert: (a inverseDistributionValue: 0.5) equals: -20.
 	"ocassionally 'Supplied derivative is not correct'"
@@ -354,7 +354,11 @@ self assert: ((a distributionValue: (a inverseDistributionValue: 0.9))equalsTo:
 	"self assert: ((a distributionValue: (a inverseDistributionValue: 1.0))equalsTo: 1)."
 	"zerod"
 	a := PMHistogram new.
-	20 timesRepeat: [ a accumulate: 7.0 random ].
+	random := Random new.
+	
+	20 timesRepeat: [
+		a accumulate: (random nextBetween: 0 and: 7) ].
+	
 	b := PMHistogrammedDistribution histogram: a.
 	self
 		assert: