Merge pull request #251 from olekscode/247-Add-complexConjugate-to-Number-and-remove-isComplexConjugateOf

Fixed #247. Added complexConjugate to Number and removed isCompleConjugateOf:

Author: olekscode

src/Math-Complex/Number.extension.st

@@ -15,7 +15,12 @@ Number >> asComplex [
 
 { #category : #'*Math-Complex' }
 Number >> complexConjugate [
-	^ self.
+	"The complex conjugate of a complex number (a + bi) is another complex number (a - bi).
+	Every real number x is also a complex number with imaginary part equal to 0.
+	In other words, x = x + 0i and x = x - 0i.
+	Therefore, the complex conjugate of a real number is the same real number"
+	
+	^ self
 ]
 
 { #category : #'*Math-Complex' }
@@ -37,13 +42,11 @@ Number >> i: aNumber [
 { #category : #'*Math-Complex' }
 Number >> isComplexConjugateOf: aNumber [
 	"A complex conjugate of a real number is same real number"
-	^ self = aNumber
-]
+	self
+		deprecated: 'This method is redundant. Just check the equality with complexConjugate'
+		transformWith: '`@rec isComplexConjugate: `@arg' -> '`@rec complexConjugate = `@arg'.
 
-{ #category : #'*Math-Complex' }
-Number >> isComplexConjugateOfAComplexNumber: aComplexNumber [
-	"A complex conjugate of a real number is same real number"
-	^ self isComplexConjugateOf: aComplexNumber
+	^ self complexConjugate = aNumber
 ]
 
 { #category : #'*Math-Complex' }

src/Math-Complex/PMComplex.class.st

@@ -537,13 +537,11 @@ PMComplex >> imaginary [
 { #category : #testing }
 PMComplex >> isComplexConjugateOf: aNumber [
 	"Answer true if self and aNumber are complex conjugates of each other. The complex conjugate of a complex number is the number with an equal real part and an imaginary part equal in magnitude but opposite in sign."
-	^ aNumber isComplexConjugateOfAComplexNumber: self
-]
+	self
+		deprecated: 'This method is redundant. Just check the equality with complexConjugate'
+		transformWith: '`@rec isComplexConjugate: `@arg' -> '`@rec complexConjugate = `@arg'.
 
-{ #category : #testing }
-PMComplex >> isComplexConjugateOfAComplexNumber: aComplexNumber [
-	"Answer true if self and aComplexNumber are complex conjugates of each other. The complex conjugate of a complex number is the number with an equal real part and an imaginary part equal in magnitude but opposite in sign."
-	^ (aComplexNumber real = real) and: [ aComplexNumber imaginary = (-1 * imaginary) ]
+	^ self complexConjugate = aNumber
 ]
 
 { #category : #testing }

src/Math-Matrix/PMMatrix.class.st

@@ -567,7 +567,7 @@ PMMatrix >> isHermitian [
 
 	1 to: self numberOfRows do: [ :i |
 		1 to: (i - 1) do: [ :j |
-			((self at: i at: j) isComplexConjugateOf: (self at: j at: i))
+			((self at: i at: j) complexConjugate = (self at: j at: i))
 				ifFalse: [ ^ false ] ] ].
 
 	^ true

src/Math-Tests-Complex/NumberTest.extension.st

@@ -0,0 +1,7 @@
+Extension { #name : #NumberTest }
+
+{ #category : #'*Math-Tests-Complex' }
+NumberTest >> testComplexConjugate [
+
+	self assert: 5 complexConjugate equals: 5
+]

src/Math-Tests-Complex/PMComplexTest.class.st

@@ -384,60 +384,6 @@ PMComplexTest >> testHash [
 	self assert: aComplex copy hash equals: aComplex hash
 ]
 
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfConjugateComplex [
-
-	self assert: ((3 + 2i) isComplexConjugateOf: (3 - 2i))
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfConjugateComplexAndReal [
-
-	self assert: ((5 + 0i) isComplexConjugateOf: 5)
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfConjugateRealAndComplex [
-
-	self assert: (5 isComplexConjugateOf: (5 - 0i))
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfDifferentReal [
-
-	self deny: (-5 isComplexConjugateOf: 5)
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfNonConjugateComplexAndReal [
-
-	self deny: ((5 + 3i) isComplexConjugateOf: 5)
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfNonConjugateDifferentComplex [
-
-	self deny: ((-0.5 - 1i) isComplexConjugateOf: (3 - 2i))
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfNonConjugateRealAndComplex [
-
-	self deny: (5 isComplexConjugateOf: (5 - 3i))
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfSameComplex [
-
-	self deny: ((3 - 2i) isComplexConjugateOf: (3 - 2i))
-]
-
-{ #category : #tests }
-PMComplexTest >> testIsComplexConjugateOfSameReal [
-
-	self assert: (5 isComplexConjugateOf: 5)
-]
-
 { #category : #tests }
 PMComplexTest >> testIsComplexNumberOnComplex [