Ensure super methods are called

jecisc · jecisc · commit 3f636af15130 · 2023-03-09T21:48:07.000+01:00
diff --git a/src/Math-Accuracy-Core/PMAccuracy.class.st b/src/Math-Accuracy-Core/PMAccuracy.class.st
@@ -269,6 +269,8 @@ PMAccuracy >> initSubclassSelectorNames [
 
 { #category : #initialization }
 PMAccuracy >> initialize [
+
+	super initialize.
 	parameters := Dictionary new.
 	arguments := Dictionary new.
 	results := Dictionary new.
diff --git a/src/Math-Accuracy-ODE/PMODEAccuracy.class.st b/src/Math-Accuracy-ODE/PMODEAccuracy.class.st
@@ -158,10 +158,12 @@ PMODEAccuracy >> checkTrapezoidAM2 [
 
 { #category : #initialization }
 PMODEAccuracy >> initialize [
-	dt :=0.09.
-	function :=  [:x :t | (t ** 4) * (t sin ** (2 * t cos)) * ( (2 * t negated) * (2 * t sin) * (t sin log) + t * (2 * t cos) * (t tan reciprocal) + 5)].
+
+	super initialize.
+	dt := 0.09.
+	function := [ :x :t | t ** 4 * (t sin ** (2 * t cos)) * (2 * t negated * (2 * t sin) * t sin log + t * (2 * t cos) * t tan reciprocal + 5) ].
 	startState := 0.
-	startTime := 0.3 .
+	startTime := 0.3.
 	endTime := Float halfPi
 ]
 
diff --git a/src/Math-Core-Process/PMIterativeProcess.class.st b/src/Math-Core-Process/PMIterativeProcess.class.st
@@ -79,9 +79,11 @@ PMIterativeProcess >> hasConverged [
 { #category : #initialization }
 PMIterativeProcess >> initialize [
 
+	super initialize.
+
 	desiredPrecision := self class defaultPrecision.
 	maximumIterations := self class defaultMaximumIterations.
-	^self
+	^ self
 ]
 
 { #category : #operation }
diff --git a/src/Math-Distributions/PMCongruentialRandomNumberGenerator.class.st b/src/Math-Distributions/PMCongruentialRandomNumberGenerator.class.st
@@ -47,6 +47,8 @@ PMCongruentialRandomNumberGenerator >> floatValue [
 { #category : #initialization }
 PMCongruentialRandomNumberGenerator >> initialize [
 
+	super initialize.
+
 	self initialize: 2718281829.0 multiplicator: 3141592653.0 modulus: 4294967296.0
 ]
 
diff --git a/src/Math-Distributions/PMErfApproximation.class.st b/src/Math-Distributions/PMErfApproximation.class.st
@@ -61,11 +61,11 @@ PMErfApproximation class >> reset [
 
 { #category : #initialization }
 PMErfApproximation >> initialize [
+
+	super initialize.
 	constant := 0.2316419.
 	norm := 1 / (Float pi * 2) sqrt.
-	series := PMPolynomial
-		coefficients:
-			#(0.31938153 -0.356563782 1.781477937 -1.821255978 1.330274429)
+	series := PMPolynomial coefficients: #( 0.31938153 -0.356563782 1.781477937 -1.821255978 1.330274429 )
 ]
 
 { #category : #information }
diff --git a/src/Math-KDTree/PMNNStore.class.st b/src/Math-KDTree/PMNNStore.class.st
@@ -78,9 +78,13 @@ PMNNStore >> hash [
 
 { #category : #initialization }
 PMNNStore >> initialize [
-"can also be used for resetting as eg in testEqual2"
-lastUsedIndex :=0.
-maxDistance := ((self size = 0) ifTrue: [ 0.0 - Float infinity ]ifFalse: [ Float infinity ]). "(self size = 0) ifTrue: is necessary here, ifEmpty wouldnt work"
+	"can also be used for resetting as eg in testEqual2"
+
+	super initialize.
+	lastUsedIndex := 0.
+	maxDistance := self size = 0
+		               ifTrue: [ 0.0 - Float infinity ]
+		               ifFalse: [ Float infinity ] "(self size = 0) ifTrue: is necessary here, ifEmpty wouldnt work"
 ]
 
 { #category : #testing }
diff --git a/src/Math-Numerical/PMLagrangeInterpolator.class.st b/src/Math-Numerical/PMLagrangeInterpolator.class.st
@@ -35,7 +35,9 @@ PMLagrangeInterpolator >> defaultSamplePoints [
 { #category : #initialization }
 PMLagrangeInterpolator >> initialize [
 
-	^self initialize: self defaultSamplePoints
+	super initialize.
+
+	^ self initialize: self defaultSamplePoints
 ]
 
 { #category : #initialization }
diff --git a/src/Math-Numerical/PMLanczosFormula.class.st b/src/Math-Numerical/PMLanczosFormula.class.st
@@ -47,8 +47,10 @@ PMLanczosFormula >> gamma: aNumber [
 PMLanczosFormula >> initialize [
 	"Private"
 
+	super initialize.
+
 	sqrt2Pi := (Float pi * 2) sqrt.
-	coefficients := #(76.18009172947146 -86.50532032941677 24.01409824083091 -1.231739572450155 0.1208650973866179e-2 -0.5395239384953e-5)
+	coefficients := #( 76.18009172947146 -86.50532032941677 24.01409824083091 -1.231739572450155 0.1208650973866179e-2 -0.5395239384953e-5 )
 ]
 
 { #category : #information }
diff --git a/src/Math-Numerical/PMPointSeries.class.st b/src/Math-Numerical/PMPointSeries.class.st
@@ -51,8 +51,10 @@ PMPointSeries >> firstPoint [
 { #category : #initialization }
 PMPointSeries >> initialize [
 	"Create the point collection"
+
+	super initialize.
 	points := SortedCollection sortBlock: self sortBlock.
-	^self
+	^ self
 ]
 
 { #category : #'public methods' }
diff --git a/src/Math-StatisticalMoments/PMHistogram.class.st b/src/Math-StatisticalMoments/PMHistogram.class.st
@@ -331,6 +331,8 @@ PMHistogram >> growPositiveContents: anInteger [
 PMHistogram >> initialize [
 	"Private - initializes the receiver with standard settings."
 
+	super initialize.
+
 	freeExtent := false.
 	cacheSize := self class defaultCacheSize.
 	desiredNumberOfBins := self class defaultNumberOfBins.
diff --git a/src/Math-TSNE/PMTSNE.class.st b/src/Math-TSNE/PMTSNE.class.st
@@ -394,6 +394,8 @@ PMTSNE >> initialMomentumDefaultValue [
 { #category : #initialization }
 PMTSNE >> initialize [
 	"These parameters rarely need to be modified"
+
+	super initialize.
 	maxIter := self maxIterDefaultValue.
 	initialMomentum := self initialMomentumDefaultValue.
 	finalMomentum := self finalMomentumDefaultValue.
diff --git a/src/Math-Tests-ArbitraryPrecisionFloat/PMArbitraryPrecisionFloatTest.class.st b/src/Math-Tests-ArbitraryPrecisionFloat/PMArbitraryPrecisionFloatTest.class.st
@@ -111,10 +111,12 @@ PMArbitraryPrecisionFloatTest >> largeTrigonometricSerie [
 
 { #category : #running }
 PMArbitraryPrecisionFloatTest >> setUp [
+
+	super setUp.
 	zero := 0 asArbitraryPrecisionFloatNumBits: 53.
 	one := 1 asArbitraryPrecisionFloatNumBits: 53.
 	two := 2 asArbitraryPrecisionFloatNumBits: 53.
-	half := 1/2 asArbitraryPrecisionFloatNumBits: 53.
+	half := 1 / 2 asArbitraryPrecisionFloatNumBits: 53.
 	minusOne := -1 asArbitraryPrecisionFloatNumBits: 53.
 	minusTwo := -2 asArbitraryPrecisionFloatNumBits: 53.
 	huge := (10 raisedTo: 100) asArbitraryPrecisionFloatNumBits: 53
diff --git a/src/Math-Tests-AutomaticDifferenciation/PMDualNumberTest.class.st b/src/Math-Tests-AutomaticDifferenciation/PMDualNumberTest.class.st
@@ -19,6 +19,8 @@ PMDualNumberTest >> assertEquality: aDualNumber and: anotherDualNumber [
 
 { #category : #running }
 PMDualNumberTest >> setUp [
+
+	super setUp.
 	zero := PMDualNumber value: 0 eps: 1.
 	zeroc := PMDualNumber value: 0 eps: 0.
 	one := PMDualNumber value: 1 eps: 1.
diff --git a/src/Math-Tests-Core-Process/PMFixpointTest.class.st b/src/Math-Tests-Core-Process/PMFixpointTest.class.st
@@ -9,8 +9,10 @@ Class {
 
 { #category : #running }
 PMFixpointTest >> setUp [
-fp:=PMFixpoint new.
-fp verbose: false
+
+	super setUp.
+	fp := PMFixpoint new.
+	fp verbose: false
 ]
 
 { #category : #tests }
diff --git a/src/Math-Tests-Distributions/PMSmoothedDensityTest.class.st b/src/Math-Tests-Distributions/PMSmoothedDensityTest.class.st
@@ -9,7 +9,9 @@ Class {
 
 { #category : #running }
 PMSmoothedDensityTest >> setUp [
-density:=PMKernelSmoothedDensity fromData: #(1 2 3 1 2.3 2.4)
+
+	super setUp.
+	density := PMKernelSmoothedDensity fromData: #( 1 2 3 1 2.3 2.4 )
 ]
 
 { #category : #tests }
diff --git a/src/Math-Tests-FunctionFit/PMAnotherChromosomeManagerTest.class.st b/src/Math-Tests-FunctionFit/PMAnotherChromosomeManagerTest.class.st
@@ -25,7 +25,9 @@ PMAnotherChromosomeManagerTest >> setHammersleyTest: aBoolean [
 
 { #category : #running }
 PMAnotherChromosomeManagerTest >> setUp [
-cm:=(PMAnotherChromosomeManager origin: #(0 1) range: #( 2 3))
+
+	super setUp.
+	cm := PMAnotherChromosomeManager origin: #( 0 1 ) range: #( 2 3 )
 ]
 
 { #category : #tests }
diff --git a/src/Math-Tests-FunctionFit/PMAnotherGeneticOptimizerTest.class.st b/src/Math-Tests-FunctionFit/PMAnotherGeneticOptimizerTest.class.st
@@ -11,15 +11,13 @@ Class {
 PMAnotherGeneticOptimizerTest >> setUp [
 
 	| origin f |
+	super setUp.
 	f := [ :x |
 	     | v |
 	     v := x asPMVector.
 	     v * v ].
 	origin := #( -5 -5 -5 ).
-	go := PMAnotherGeneticOptimizer
-		      function: f
-		      minimumValues: origin
-		      maximumValues: origin negated.
+	go := PMAnotherGeneticOptimizer function: f minimumValues: origin maximumValues: origin negated.
 	go maximumIterations: 50.
 	go chromosomeManager populationSize: 20
 ]
diff --git a/src/Math-Tests-FunctionFit/PMErrorAsParameterFunctionTest.class.st b/src/Math-Tests-FunctionFit/PMErrorAsParameterFunctionTest.class.st
@@ -11,10 +11,9 @@ Class {
 PMErrorAsParameterFunctionTest >> setUp [
 
 	| col |
-	f := PMErrorOfParameterFunction new function: [ :x :a :b |
-		     a * x / (b + x) ].
-	col := (1 to: 3) collect: [ :i |
-		       i @ (f function cull: i cull: 1 cull: 1) ].
+	super setUp.
+	f := PMErrorOfParameterFunction new function: [ :x :a :b | a * x / (b + x) ].
+	col := (1 to: 3) collect: [ :i | i @ (f function cull: i cull: 1 cull: 1) ].
 	f data: col.
 	f := PMErrorAsParameterFunction new function: f
 ]
diff --git a/src/Math-Tests-FunctionFit/PMErrorOfParameterFunctionTest.class.st b/src/Math-Tests-FunctionFit/PMErrorOfParameterFunctionTest.class.st
@@ -11,10 +11,10 @@ Class {
 { #category : #running }
 PMErrorOfParameterFunctionTest >> setUp [
 
-	f := PMErrorOfParameterFunction new function: [ :x :a :b |
-		     a * x / (b + x) ].
-	col := (1 to: 3) collect: [ :i |
-		       i @ (f function cull: i cull: 1 cull: 1) ]
+	super setUp.
+
+	f := PMErrorOfParameterFunction new function: [ :x :a :b | a * x / (b + x) ].
+	col := (1 to: 3) collect: [ :i | i @ (f function cull: i cull: 1 cull: 1) ]
 ]
 
 { #category : #tests }
diff --git a/src/Math-Tests-FunctionFit/PMFunctionFitTest.class.st b/src/Math-Tests-FunctionFit/PMFunctionFitTest.class.st
@@ -11,6 +11,8 @@ Class {
 { #category : #running }
 PMFunctionFitTest >> setUp [
 
+	super setUp.
+
 	f := [ :x :a :b | a * x / (b + x) ].
 	d := (1 to: 20) collect: [ :i | i @ (f cull: i cull: 2 cull: 0.4) ]
 ]
diff --git a/src/Math-Tests-FunctionFit/PMGeneralFunctionFitTest.class.st b/src/Math-Tests-FunctionFit/PMGeneralFunctionFitTest.class.st
@@ -13,6 +13,8 @@ Class {
 PMGeneralFunctionFitTest >> setUp [
 	"Reset the seed of the random numbers (to get consistent results)"
 
+	super setUp.
+
 	PMMitchellMooreGenerator reset: 0.
 	"Reset the FloatingPointMachine to make coverage consistent"
 	PMFloatingPointMachine reset.
diff --git a/src/Math-Tests-KDTree/PMKDTreeTest.class.st b/src/Math-Tests-KDTree/PMKDTreeTest.class.st
@@ -27,6 +27,8 @@ tree := simpleTree ifTrue: [ PMKDTree withAll: aCollection ] ifFalse: [PMIndexed
 
 { #category : #running }
 PMKDTreeTest >> setUp [
+
+	super setUp.
 	rand := Random new
 ]
 
diff --git a/src/Math-Tests-Numerical/PMGeneticOptimizerBugsTest.class.st b/src/Math-Tests-Numerical/PMGeneticOptimizerBugsTest.class.st
@@ -11,11 +11,13 @@ Class {
 
 { #category : #running }
 PMGeneticOptimizerBugsTest >> setUp [
-manager:= PMChromosomeManager new.
-manager populationSize:3.
-function:=[:x| (x*x)sum].
-optimizer:= PMGeneticOptimizer minimizingFunction: function.
-optimizer chromosomeManager: manager
+
+	super setUp.
+	manager := PMChromosomeManager new.
+	manager populationSize: 3.
+	function := [ :x | (x * x) sum ].
+	optimizer := PMGeneticOptimizer minimizingFunction: function.
+	optimizer chromosomeManager: manager
 ]
 
 { #category : #tests }
diff --git a/src/Math-Tests-Numerical/PMHistogramTestsAndBugs.class.st b/src/Math-Tests-Numerical/PMHistogramTestsAndBugs.class.st
@@ -14,9 +14,11 @@ PMHistogramTestsAndBugs >> readMe [
 
 { #category : #running }
 PMHistogramTestsAndBugs >> setUp [
-h:=PMHistogram new.
-h freeExtent: true.
-1to:3 do: [:i |h accumulate: i]
+
+	super setUp.
+	h := PMHistogram new.
+	h freeExtent: true.
+	1 to: 3 do: [ :i | h accumulate: i ]
 ]
 
 { #category : #tests }
diff --git a/src/Math-Tests-Numerical/PMNumericalMethodsTestCase.class.st b/src/Math-Tests-Numerical/PMNumericalMethodsTestCase.class.st
@@ -7,6 +7,8 @@ Class {
 { #category : #running }
 PMNumericalMethodsTestCase >> setUp [
 	"Reset the seed of the random numbers (to get consistent results)"
+
+	super setUp.
 	PMMitchellMooreGenerator reset: 0.
 	"Reset the FloatingPointMachine to make coverage consistent"
 	PMFloatingPointMachine reset
diff --git a/src/Math-Tests-ODE/PMODESystemTest.class.st b/src/Math-Tests-ODE/PMODESystemTest.class.st
@@ -13,6 +13,8 @@ Class {
 { #category : #running }
 PMODESystemTest >> setUp [
 	"create a dummy system"
+
+	super setUp.
 	sys := PMODESystem new
 ]
 
diff --git a/src/Math-Tests-PrincipalComponentAnalysis/PMPCAJacobiTransformationTest.class.st b/src/Math-Tests-PrincipalComponentAnalysis/PMPCAJacobiTransformationTest.class.st
@@ -9,6 +9,7 @@ Class {
 
 { #category : #running }
 PMPCAJacobiTransformationTest >> setUp [
-	pca := PMPrincipalComponentAnalyserJacobiTransformation new
-		componentsNumber: 2
+
+	super setUp.
+	pca := PMPrincipalComponentAnalyserJacobiTransformation new componentsNumber: 2
 ]
diff --git a/src/Math-Tests-PrincipalComponentAnalysis/PMPCASingularValueDecompositionTest.class.st b/src/Math-Tests-PrincipalComponentAnalysis/PMPCASingularValueDecompositionTest.class.st
@@ -9,6 +9,8 @@ Class {
 
 { #category : #running }
 PMPCASingularValueDecompositionTest >> setUp [
+
+	super setUp.
 	pca := PMPrincipalComponentAnalyserSVD new componentsNumber: 2
 ]
 
diff --git a/src/Math-Tests-PrincipalComponentAnalysis/PMSciKitLearnSVDFlipAlgorithmTest.class.st b/src/Math-Tests-PrincipalComponentAnalysis/PMSciKitLearnSVDFlipAlgorithmTest.class.st
@@ -15,7 +15,7 @@ Class {
 
 { #category : #running }
 PMSciKitLearnSVDFlipAlgorithmTest >> setUp [
-"  We compute a matrix of signs for U with which
+	"  We compute a matrix of signs for U with which
 	we perform a 'dot product' with the original
 	matrix V
 	(by 'dot product' we mean send the dot: message)
@@ -32,17 +32,13 @@ PMSciKitLearnSVDFlipAlgorithmTest >> setUp [
  		 [ 0.54491354 -0.83849224]]
 	"
 
+	super setUp.
 
-	u := PMMatrix rows: #(
-		#(-0.21956688 0.53396977)
-		#(-0.35264795 -0.45713538)
-		#(-0.57221483  0.07683439)
-		#( 0.21956688 -0.53396977)
-		#( 0.35264795  0.45713538)
-		#( 0.57221483 -0.07683439)).
-	v := PMMatrix rows: #(
-		#(0.83849224  0.54491354)
-		#(0.54491354 -0.83849224)).
+
+	u := PMMatrix rows:
+		     #( #( -0.21956688 0.53396977 ) #( -0.35264795 -0.45713538 ) #( -0.57221483 0.07683439 ) #( 0.21956688 -0.53396977 ) #( 0.35264795 0.45713538 )
+		        #( 0.57221483 -0.07683439 ) ).
+	v := PMMatrix rows: #( #( 0.83849224 0.54491354 ) #( 0.54491354 -0.83849224 ) ).
 
 	flipAlgorithm := PMSciKitLearnSVDFlipAlgorithm flipU: u andV: v
 ]
diff --git a/src/Math-Tests-PrincipalComponentAnalysis/PMScikitLearnSVDFlipAlgorithmSandiaTest.class.st b/src/Math-Tests-PrincipalComponentAnalysis/PMScikitLearnSVDFlipAlgorithmSandiaTest.class.st
@@ -22,19 +22,15 @@ Class {
 
 { #category : #running }
 PMScikitLearnSVDFlipAlgorithmSandiaTest >> setUp [
-	u:= PMMatrix rows: #(
-	 		 #(-3.37888092e-01  7.97390517e-01 -5.00000000e-01 -7.29361893e-17)
- 			 #(-6.39157626e-01 -5.84360787e-01 -5.00000000e-01 -6.37482349e-17)
- 			 #(4.88522859e-01 -1.06514865e-01 -5.00000000e-01 -7.07106781e-01)
- 			 #(4.88522859e-01 -1.06514865e-01 -5.00000000e-01  7.07106781e-01)
-		).
 
-	v := PMMatrix rows: #(
-  			 #(0.1480984   0.96040168  0.13728871  0.19195647)
- 			 #(0.43936626 -0.13130934 -0.54106008  0.70496038)
- 			 #(-0.42589859  0.24444267 -0.8129595  -0.31297767)
- 			 #(-0.77693921 -0.02518437  0.16583923  0.60681839)
-		  ).
+	super setUp.
+	u := PMMatrix rows:
+		     #( #( -3.37888092e-01 7.97390517e-01 -5.00000000e-01 -7.29361893e-17 ) #( -6.39157626e-01 -5.84360787e-01 -5.00000000e-01 -6.37482349e-17 )
+		        #( 4.88522859e-01 -1.06514865e-01 -5.00000000e-01 -7.07106781e-01 ) #( 4.88522859e-01 -1.06514865e-01 -5.00000000e-01 7.07106781e-01 ) ).
+
+	v := PMMatrix rows:
+		     #( #( 0.1480984 0.96040168 0.13728871 0.19195647 ) #( 0.43936626 -0.13130934 -0.54106008 0.70496038 ) #( -0.42589859 0.24444267 -0.8129595 -0.31297767 )
+		        #( -0.77693921 -0.02518437 0.16583923 0.60681839 ) ).
 
 	flipAlgorithm := PMSciKitLearnSVDFlipAlgorithm flipU: u andV: v
 ]
diff --git a/src/Math-Tests-Quantile/PMQuantileTest.class.st b/src/Math-Tests-Quantile/PMQuantileTest.class.st
diff --git a/src/Math-Tests-Quaternion/PMQuaternionTest.class.st b/src/Math-Tests-Quaternion/PMQuaternionTest.class.st

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ PMCongruentialRandomNumberGenerator >> floatValue [`
`47`	`47`	`{ #category : #initialization }`
`48`	`48`	`PMCongruentialRandomNumberGenerator >> initialize [`
`49`	`49`
	`50`	`+ super initialize.`
	`51`	`+`
`50`	`52`	`self initialize: 2718281829.0 multiplicator: 3141592653.0 modulus: 4294967296.0`
`51`	`53`	`]`
`52`	`54`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,9 @@ PMLagrangeInterpolator >> defaultSamplePoints [`
`35`	`35`	`{ #category : #initialization }`
`36`	`36`	`PMLagrangeInterpolator >> initialize [`
`37`	`37`
`38`		`- ^self initialize: self defaultSamplePoints`
	`38`	`+ super initialize.`
	`39`	`+`
	`40`	`+ ^ self initialize: self defaultSamplePoints`
`39`	`41`	`]`
`40`	`42`
`41`	`43`	`{ #category : #initialization }`