Use better assert for better error logs

Author: jecisc

src/Math-Tests-ArbitraryPrecisionFloat/PMArbitraryPrecisionFloatTest.class.st

@@ -99,16 +99,17 @@ PMDualNumberTest >> testConjugated [
 
 { #category : #tests }
 PMDualNumberTest >> testConverting [
+
 	| a |
-	self assert: zeroc asInteger == 0.
-	self assert: three asInteger == 3.
+	self assert: zeroc asInteger identicalTo: 0.
+	self assert: three asInteger identicalTo: 3.
 	self assert: onec asFloat isFloat.
 	self deny: onec isFloat.
 	self assert: onec asFloat equals: 1.
 	a := three negated asFloat.
 	self assert: a isFloat.
 	self assert: a equals: -3.
-	self assert: (PMDualNumber value: -3.7 eps: 2) asInteger == -3
+	self assert: (PMDualNumber value: -3.7 eps: 2) asInteger identicalTo: -3
 ]
 
 { #category : #'tests-mathematical functions' }

src/Math-Tests-AutomaticDifferenciation/PMDualNumberTest.class.st

@@ -48,13 +48,14 @@ PMHyperDualNumberTest >> testAbs [
 
 { #category : #tests }
 PMHyperDualNumberTest >> testAccessing [
+
 	self assert: three eps equals: 1.
 	self assert: three value equals: 3.
 	self assert: three eps2 equals: 1.
 	self assert: three eps1eps2 equals: 0.
 	three eps1eps2: 2.
 	three eps2: 2.
-	self assert: three eps2 == 2.
+	self assert: three eps2 identicalTo: 2.
 	self assert: three eps1eps2 equals: 2
 ]
 
@@ -124,16 +125,17 @@ PMHyperDualNumberTest >> testArcTan [
 
 { #category : #tests }
 PMHyperDualNumberTest >> testConverting [
+
 	| a |
-	self assert: zeroc asInteger == 0.
-	self assert: three asInteger == 3.
+	self assert: zeroc asInteger identicalTo: 0.
+	self assert: three asInteger identicalTo: 3.
 	self assert: onec asFloat isFloat.
 	self deny: onec isFloat.
 	self assert: onec asFloat equals: 1.
 	a := three negated asFloat.
 	self assert: a isFloat.
 	self assert: a equals: -3.
-	self assert: (PMDualNumber value: -3.7 eps: 2) asInteger == -3
+	self assert: (PMDualNumber value: -3.7 eps: 2) asInteger identicalTo: -3
 ]
 
 { #category : #'tests-mathematical functions' }

src/Math-Tests-AutomaticDifferenciation/PMHyperDualNumberTest.class.st

@@ -601,9 +601,9 @@ PMComplexNumberTest >> testProductWithVector [
 PMComplexNumberTest >> testPureImaginaryNumbersAreNotEqualToObjectsOfADifferentType [
 
 	self deny: 1 i isNil.
-	self deny: nil = 1 i.
-	self deny: 1 i = #( 1 2 3 ).
-	self deny: #( 1 2 3 ) = 1 i
+	self deny: nil equals: 1 i.
+	self deny: 1 i equals: #( 1 2 3 ).
+	self deny: #( 1 2 3 ) equals: 1 i
 ]
 
 { #category : #'testing - expressing complex numbers' }

src/Math-Tests-Complex/PMComplexNumberTest.class.st

@@ -38,16 +38,13 @@ PMKolmogorovSmirnov1SampleTest >> testCorrectPopulationProbabilistic [
 
 { #category : #tests }
 PMKolmogorovSmirnov1SampleTest >> testRejectOfEqualityHypothesesForSampleVersusDistribution [
+
 	| sample |
 	"The data below are taken from http://www.maths.qmul.ac.uk/~bb/CTS_Chapter3_Students.pdf"
-	sample := #(-1.2 0.2 -0.6 0.8 -1.0).
-	test := PMKolmogorovSmirnov1Sample
-		compareData: sample
-		withDistribution: distribution.
+	sample := #( -1.2 0.2 -0.6 0.8 -1.0 ).
+	test := PMKolmogorovSmirnov1Sample compareData: sample withDistribution: distribution.
 
-	self
-		assert: (test rejectEqualityHypothesisWithAlpha: 0.05)
-		equals: false
+	self deny: (test rejectEqualityHypothesisWithAlpha: 0.05)
 ]
 
 { #category : #tests }

src/Math-Tests-Distributions/PMKolmogorovSmirnov1SampleTest.class.st

@@ -20,13 +20,9 @@ PMKolmogorovSmirnov2SampleTest >> testRejectOfEqualityHypothesesForTwoSamples [
 	"
 
 	| ks |
-	ks := PMKolmogorovSmirnov2Sample
-		compareData: #(1.2 1.4 1.9 3.7 4.4 4.8 9.7 17.3 21.1 28.4)
-		withData: #(5.6 6.5 6.6 6.9 9.2 10.4 10.6 19.3).
+	ks := PMKolmogorovSmirnov2Sample compareData: #( 1.2 1.4 1.9 3.7 4.4 4.8 9.7 17.3 21.1 28.4 ) withData: #( 5.6 6.5 6.6 6.9 9.2 10.4 10.6 19.3 ).
 
-	self
-		assert: (ks rejectEqualityHypothesisWithAlpha: 0.05)
-		equals: true
+	self assert: (ks rejectEqualityHypothesisWithAlpha: 0.05)
 ]
 
 { #category : #tests }

src/Math-Tests-Distributions/PMKolmogorovSmirnov2SampleTest.class.st

@@ -37,18 +37,20 @@ PMAnotherChromosomeManagerTest >> testAccessing [
 
 { #category : #tests }
 PMAnotherChromosomeManagerTest >> testCrossOver [
-|a|
-1 to: 20 do: [:i| a:=cm crossover: #(1 2 3) and: #(4 5 6).
-	1 to:2 do:[:index|
-		self assert: (#(1 4) includes: ((a at: index) first)).
-		self assert: (#(2 5)includes:((a at: index) at: 2)).
-		self assert: (#(3 6) includes:((a at: index) at: 3)).].
-	self deny: (((a at: 1)at: 2)=((a at: 2)at: 2)).
-	self deny: (((a at: 1)at: 1)=((a at: 2)at: 1)).
-	self deny: (((a at: 1)at: 3)=((a at: 2)at: 3)).
-	a].
-a:= a collect: [:g|g first].
-self assert: ((a occurrencesOf: #(1 2 3))<20)
+
+	| a |
+	1 to: 20 do: [ :i |
+		a := cm crossover: #( 1 2 3 ) and: #( 4 5 6 ).
+		1 to: 2 do: [ :index |
+			self assert: (#( 1 4 ) includes: (a at: index) first).
+			self assert: (#( 2 5 ) includes: ((a at: index) at: 2)).
+			self assert: (#( 3 6 ) includes: ((a at: index) at: 3)) ].
+		self deny: ((a at: 1) at: 2) equals: ((a at: 2) at: 2).
+		self deny: ((a at: 1) at: 1) equals: ((a at: 2) at: 1).
+		self deny: ((a at: 1) at: 3) equals: ((a at: 2) at: 3).
+		a ].
+	a := a collect: [ :g | g first ].
+	self assert: (a occurrencesOf: #( 1 2 3 )) < 20
 ]
 
 { #category : #tests }
@@ -142,14 +144,15 @@ PMAnotherChromosomeManagerTest >> testProcessand [
 
 { #category : #tests }
 PMAnotherChromosomeManagerTest >> testRandomizePopulation [
-|g|
-self setHammersleyTest: true.
-g :=cm population first.
-self setHammersleyTest: false.
-self deny: (cm population first =g).
-g :=cm population first.
-self setHammersleyTest: false.
-self deny: (cm population first =g)
+
+	| g |
+	self setHammersleyTest: true.
+	g := cm population first.
+	self setHammersleyTest: false.
+	self deny: cm population first equals: g.
+	g := cm population first.
+	self setHammersleyTest: false.
+	self deny: cm population first equals: g
 ]
 
 { #category : #tests }

src/Math-Tests-FunctionFit/PMAnotherChromosomeManagerTest.class.st

@@ -13,104 +13,107 @@ PMNNStoreTest >> testCopy [
 	"a separate copy method is necessary because of this scenario"
 
 	| a b |
-	a := PMNNStore withAll: #(1 2 4).
+	a := PMNNStore withAll: #( 1 2 4 ).
 	b := a copy.
 	self assert: b equals: a.
 	self assert: b hash equals: a hash.
 	b sortFor: nil.
-	self deny: b = a.	"here is the problem"
-	self deny: b hash = a hash
+	self deny: b equals: a. "here is the problem"
+	self deny: b hash equals: a hash
 ]
 
 { #category : #tests }
 PMNNStoreTest >> testCopyEmpty [
+
 	| n m |
-	n := PMNNStore newFrom: #(#(1 $a) #(3 1.0) #(0 '2')).
+	n := PMNNStore newFrom: #( #( 1 $a ) #( 3 1.0 ) #( 0 '2' ) ).
 	n := n copyEmpty.
 	self assert: n isEmpty.
 	n
-		add: #(2 10);
-		add: #(1 100).
+		add: #( 2 10 );
+		add: #( 1 100 ).
 	self deny: n isEmpty.
-	self assert: n maxDistance equals: Float infinity.	"because it is not yet full"
-	self assert: n data equals: #(100 10).
+	self assert: n maxDistance equals: Float infinity. "because it is not yet full"
+	self assert: n data equals: #( 100 10 ).
 	m := n copyEmpty.
-	self assert: m size equals: 2.	"size is reduced now"
+	self assert: m size equals: 2. "size is reduced now"
 	m
-		add: #(2 10);
-		add: #(1 100).
-	self deny: m = n.
+		add: #( 2 10 );
+		add: #( 1 100 ).
+	self deny: m equals: n.
 	self assert: m completeData equals: n completeData
 ]
 
 { #category : #tests }
 PMNNStoreTest >> testEqual [
+
 	| a b |
-	b := #(#(1 $a) #(3 1.0) #(0 '2')).
+	b := #( #( 1 $a ) #( 3 1.0 ) #( 0 '2' ) ).
 	a := PMNNStore newFrom: b.
-	self deny: a = b.
-	b := PMNNStore newFrom: #(#(1 $a) #(3 1.0) #(0 2)).
-	self deny: a = b.
+	self deny: a equals: b.
+	b := PMNNStore newFrom: #( #( 1 $a ) #( 3 1.0 ) #( 0 2 ) ).
+	self deny: a equals: b.
 	b := a copyEmpty.
-	self deny: a = b.
-	b addAll: #(#(3 1.0) #(1 $a) #(4 true) #(0 '2')).
+	self deny: a equals: b.
+	b addAll: #( #( 3 1.0 ) #( 1 $a ) #( 4 true ) #( 0 '2' ) ).
 	self assert: a equals: b.
-	b add: #(2 nil).
-	self deny: a = b.
+	b add: #( 2 nil ).
+	self deny: a equals: b.
 	b := PMNNStore new: 3.
 	a := PMNNStore new: 2.
-	a add: #(2 nil).
-	b add: #(2 nil).
-	self deny: a = b.
-	self deny: b hash = a hash
+	a add: #( 2 nil ).
+	b add: #( 2 nil ).
+	self deny: a equals: b.
+	self deny: b hash equals: a hash
 ]
 
 { #category : #tests }
 PMNNStoreTest >> testExtremeCase [
+
 	| n |
 	n := PMNNStore new.
-	n sortFor: nil.	"this should indeed always be possible and shouldnt raise an error!"
+	n sortFor: nil. "this should indeed always be possible and shouldnt raise an error!"
 	self assert: n isFull.
-	n add: #(1 1).	"adding should also always be possible, although it will not be added in this case"
-	self deny: n maxDistance = 1.
-	n
-		add: (Array with: (0 - Float infinity) with: 1).	"and this extreme case too."
+	n add: #( 1 1 ). "adding should also always be possible, although it will not be added in this case"
+	self deny: n maxDistance equals: 1.
+	n add: (Array with: 0 - Float infinity with: 1). "and this extreme case too."
 	self assert: n isEmpty.
-	self assert: n data equals: #().
-	self should: [ n add: (Array with: nil with: 1) ] raise: Error	"but this should always raise an error (not only in NNStores with size 0), also in subclasses, otherwise one can have strange bugs"
+	self assert: n data equals: #(  ).
+	self should: [ n add: (Array with: nil with: 1) ] raise: Error "but this should always raise an error (not only in NNStores with size 0), also in subclasses, otherwise one can have strange bugs"
 ]
 
 { #category : #tests }
 PMNNStoreTest >> testInitialize [
+
 	| a b |
-	a := PMNNStore newFrom: #(#(4 $a) #(5 1.0) #(6 '2')).
-	b := (PMNNStore newFrom: #(#(4 $a) #(5 1.0) #(6 '2'))) initialize.
-	self deny: a = b.
+	a := PMNNStore newFrom: #( #( 4 $a ) #( 5 1.0 ) #( 6 '2' ) ).
+	b := (PMNNStore newFrom: #( #( 4 $a ) #( 5 1.0 ) #( 6 '2' ) )) initialize.
+	self deny: a equals: b.
 	a initialize.
 	self assert: a equals: b.
-	b add: #(4 $a).
-	self deny: a = b.
-	a add: #(4 $a).
+	b add: #( 4 $a ).
+	self deny: a equals: b.
+	a add: #( 4 $a ).
 	self assert: a equals: b.
-	a add: #(5 1.0).
-	self deny: a = b
+	a add: #( 5 1.0 ).
+	self deny: a equals: b
 ]
 
 { #category : #tests }
 PMNNStoreTest >> testInitialize2 [
 	"a separate = method is necessary because of this scenario with resetting"
 
 	| a b c |
-	a := (PMNNStore newFrom: #(#(1 $a) #(3 1.0) #(0 '2'))) initialize.	"initialize = resetting"
-	b := (PMNNStore newFrom: #(#(1 $a) #(3 false) #(0 '2'))) initialize.
-	self assert: a equals: b.	"first  problematic part"
-	c := #(#(3 true) #(2 1)).
+	a := (PMNNStore newFrom: #( #( 1 $a ) #( 3 1.0 ) #( 0 '2' ) )) initialize. "initialize = resetting"
+	b := (PMNNStore newFrom: #( #( 1 $a ) #( 3 false ) #( 0 '2' ) )) initialize.
+	self assert: a equals: b. "first  problematic part"
+	c := #( #( 3 true ) #( 2 1 ) ).
 	a addAll: c.
 	b addAll: c.
-	self assert: a equals: b.	"second problematic part"
-	c := #(2 nil).
+	self assert: a equals: b. "second problematic part"
+	c := #( 2 nil ).
 	a add: c.
-	self deny: a = b.
+	self deny: a equals: b.
 	b add: c.
 	self assert: a equals: b
 ]

src/Math-Tests-KDTree/PMNNStoreTest.class.st

@@ -6,7 +6,8 @@ Class {
 
 { #category : #tests }
 PMNumberExtensionsTest >> testArTanh [
-	self assert: 0 arTanh = 0.0 arTanh.
+
+	self assert: 0 arTanh equals: 0.0 arTanh.
 	self assert: 1 arTanh isFloat.
 	self assert: 1 arTanh equals: 1.0 arTanh
 ]

src/Math-Tests-Number-Extensions/PMNumberExtensionsTest.class.st

@@ -77,10 +77,11 @@ PMFloatingPointMachineTestCase >> testMachinePrecisionSmallestNumberNotZero [
 
 { #category : #precision }
 PMFloatingPointMachineTestCase >> testUniqueInstance [
+
 	| mach1 mach2 mach3 |
 	mach1 := PMFloatingPointMachine new.
 	mach2 := PMFloatingPointMachine new.
-	self assert: mach1 == mach2.
+	self assert: mach1 identicalTo: mach2.
 	PMFloatingPointMachine reset.
 	mach3 := PMFloatingPointMachine new.
 	self shouldnt: [ mach3 == mach2 ]