Rename decompose on PMMatrix as decomposeSV

Close #116

Author: SergeStinckwich

src/Math-Matrix/PMMatrix.class.st

@@ -15,7 +15,7 @@ Class {
 		'rows',
 		'lupDecomposition'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #example }
@@ -396,8 +396,7 @@ PMMatrix >> cumsum [
 ]
 
 { #category : #'as yet unclassified' }
-PMMatrix >> decompose [
-
+PMMatrix >> decomposeSV [
 	^ PMSingularValueDecomposition decompose: self
 ]
 

src/Math-PrincipalComponentAnalysis/PMPrincipalComponentAnalyserSVD.class.st

@@ -37,11 +37,10 @@ d1 scatterplotMatrix.
 
 { #category : #accessing }
 PMPrincipalComponentAnalyserSVD >> fit: aPMMatrix [
-	svd := aPMMatrix decompose.
+	svd := aPMMatrix decomposeSV.
 	u := svd leftSingularForm.
 	v := svd rightSingularForm.
 	self flipEigenvectorsSign
-	
 ]
 
 { #category : #accessing }

src/Math-Tests-Matrix/PMSingularValueDecompositionTest.class.st

@@ -35,7 +35,7 @@ Class {
 		'actualV',
 		'actualS'
 	],
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #'as yet unclassified' }
@@ -192,10 +192,8 @@ PMSingularValueDecompositionTest >> testIsOrthonormalU [
 	"Verifying that matrix U is orthonormal. That is, all columns of U are unit vectors and orthogonal to each other."
 
 	| u m identity |
-		
-	u := matrix decompose leftSingularForm.
+	u := matrix decomposeSV leftSingularForm.
 	m := u numberOfRows.
-	
 	identity := PMSymmetricMatrix identity: m.
 	self assert: u transpose * u closeTo: identity
 ]
@@ -205,10 +203,8 @@ PMSingularValueDecompositionTest >> testIsOrthonormalV [
 	"Verifying that matrix U is orthonormal. That is, all columns of U are unit vectors and orthogonal to each other."
 
 	| v n identity |
-		
-	v := matrix decompose rightSingularForm.
+	v := matrix decomposeSV rightSingularForm.
 	n := v numberOfRows.
-	
 	identity := PMSymmetricMatrix identity: n.
 	self assert: v transpose * v closeTo: identity
 ]
@@ -218,35 +214,26 @@ PMSingularValueDecompositionTest >> testIsSquareU [
 	"U should be a square matrix"
 
 	| u |
-		
-	u := matrix decompose leftSingularForm.
-	self
-		assert: u numberOfRows
-		equals: u numberOfColumns.
+	u := matrix decomposeSV leftSingularForm.
+	self assert: u numberOfRows equals: u numberOfColumns
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testIsSquareV [
 	"V should be a square matrix"
 
 	| v |
-		
-	v := matrix decompose rightSingularForm.
-	self
-		assert: v numberOfRows
-		equals: v numberOfColumns.
+	v := matrix decomposeSV rightSingularForm.
+	self assert: v numberOfRows equals: v numberOfColumns
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testReconstruction [
-
 	| svd u v s reconstructed |
-		
-	svd := matrix decompose.
+	svd := matrix decomposeSV.
 	u := svd leftSingularForm.
 	v := svd rightSingularForm.
 	s := svd sForm.
-	
 	reconstructed := u * s * v transpose.
 	self assert: reconstructed closeTo: matrix
 ]
@@ -256,64 +243,58 @@ PMSingularValueDecompositionTest >> testShapeS [
 	"If A is an (m x n) matrix, then S should be an (m x n) matrix"
 
 	| s m n |
-		
-	s := matrix decompose sForm.
+	s := matrix decomposeSV sForm.
 	m := matrix numberOfRows.
 	n := matrix numberOfColumns.
-	
 	self assert: s numberOfRows equals: m.
-	self assert: s numberOfColumns equals: n.
+	self assert: s numberOfColumns equals: n
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testShapeU [
 	"If A is an (m x n) matrix, then U should be an (m x m) matrix"
 
 	| u m |
-		
-	u := matrix decompose leftSingularForm.
+	u := matrix decomposeSV leftSingularForm.
 	m := matrix numberOfRows.
-	
 	self assert: u numberOfRows equals: m.
-	self assert: u numberOfColumns equals: m.
+	self assert: u numberOfColumns equals: m
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testShapeV [
 	"If A is an (m x n) matrix, then V should be an (n x n) matrix"
 
 	| v n |
-		
-	v := matrix decompose rightSingularForm.
+	v := matrix decomposeSV rightSingularForm.
 	n := matrix numberOfColumns.
-	
 	self assert: v numberOfRows equals: n.
-	self assert: v numberOfColumns equals: n.
+	self assert: v numberOfColumns equals: n
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testValueS [
 	"Comparing S to its known value"
 
 	| s |
-	s := matrix decompose sForm.
-	self assert: s closeTo: actualS.
+	s := matrix decomposeSV sForm.
+	self assert: s closeTo: actualS
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testValueU [
 	"Comparing U to its known value"
 
 	| u |
-	u := matrix decompose leftSingularForm.
-	self assert: u closeTo: actualU.
+	u := matrix decomposeSV leftSingularForm.
+	self assert: u closeTo: actualU
 ]
 
 { #category : #tests }
 PMSingularValueDecompositionTest >> testValueV [
 	"Comparing V to its known value"
 
 	| v |
-	v := matrix decompose rightSingularForm.
-	self assert: v closeTo: actualV.
+	v := matrix decomposeSV rightSingularForm.
+	self assert: v closeTo: actualV
 ]