Factorize code

Author: jecisc

src/Math-Tests-FunctionFit/PMGeneralFunctionFitTest.class.st

@@ -19,19 +19,20 @@ PMGeneralFunctionFitTest >> setUp [
 	"Reset the FloatingPointMachine to make coverage consistent"
 	PMFloatingPointMachine reset.
 	f := [ :x :a :b | (a * x) sin / (b + x squared) ].
-	col := (-4 to: 4 by: 0.1) collect: [ :i | i @ (f cull: i cull: 0.1 cull: 0.4) ]
+	col := (-4 to: 4 by: 0.1) collect: [ :i | i @ (f cull: i cull: 0.1 cull: 0.4) ].
+	fit := PMGeneralFunctionFit
+		       function: f
+		       data: col
+		       minimumValues: 0
+		       maximumValues: 5.
+
+	fit manager randomGenerator: (Random seed: 42)
 ]
 
 { #category : #tests }
 PMGeneralFunctionFitTest >> testBasic [
 
 	| d |
-	fit := PMGeneralFunctionFit
-		       function: f
-		       data: col
-		       minimumValues: 0
-		       maximumValues: 5.
-	fit manager randomGenerator: (Random seed: 42).
 	self assert: (fit evaluate closeTo: #( 0.1 0.4 )).
 	(fit result - #( 0.1 0.4 )) abs with: (fit secondaryResult - #( 0.1 0.4 )) abs do: [ :e :s | self assert: s - e > 0 ].
 	d := fit error: fit secondaryResult.
@@ -43,40 +44,24 @@ PMGeneralFunctionFitTest >> testBasic [
 PMGeneralFunctionFitTest >> testFunction [
 
 	| y |
-	fit := PMGeneralFunctionFit
-		       function: f
-		       data: col
-		       minimumValues: 0
-		       maximumValues: 5.
-	fit manager randomGenerator: (Random seed: 42).
 	y := fit function value: 3 value: 0.1 value: 0.4.
 	fit evaluate.
 	self assert: ((fit function value: 3) closeTo: y)
 ]
 
 { #category : #tests }
 PMGeneralFunctionFitTest >> testManager [
-	fit := PMGeneralFunctionFit
-		function: f
-		data: col
-		minimumValues: 0
-		maximumValues: 5.
+
 	self assert: fit manager class equals: PMAnotherChromosomeManager.
-	self assert: fit manager range equals: #(5 5)
+	self assert: fit manager range equals: #( 5 5 )
 ]
 
 { #category : #tests }
 PMGeneralFunctionFitTest >> testMaximumIterationsProbabilistic [
 
 	| r correct |
-	fit := PMGeneralFunctionFit
-		       function: f
-		       data: col
-		       minimumValues: 0
-		       maximumValues: 5.
 	correct := 0.
 	fit populationSize: 20.
-	fit manager randomGenerator: (Random seed: 42).
 	7 timesRepeat: [
 		fit resetBestPoints.
 		fit maximumIterations: 200.
@@ -92,11 +77,7 @@ PMGeneralFunctionFitTest >> testMaximumIterationsProbabilistic [
 
 { #category : #tests }
 PMGeneralFunctionFitTest >> testPopulationSize [
-	fit := PMGeneralFunctionFit
-		function: f
-		data: col
-		minimumValues: 0
-		maximumValues: 5.
+
 	self assert: fit manager populationSize equals: 50.
 	fit populationSize: 100.
 	self assert: fit manager populationSize equals: 100
@@ -105,12 +86,6 @@ PMGeneralFunctionFitTest >> testPopulationSize [
 { #category : #tests }
 PMGeneralFunctionFitTest >> testPrecision [
 
-	fit := PMGeneralFunctionFit
-		       function: f
-		       data: col
-		       minimumValues: 0
-		       maximumValues: 5.
-	fit manager randomGenerator: (Random seed: 42).
 	self assert: fit precision isNil.
 	fit evaluate.
 	self assert: fit precision < 1e-6
@@ -120,13 +95,6 @@ PMGeneralFunctionFitTest >> testPrecision [
 PMGeneralFunctionFitTest >> testPrint [
 
 	| aStream s |
-	fit := PMGeneralFunctionFit
-		       function: f
-		       data: col
-		       minimumValues: 0
-		       maximumValues: 5.
-
-	fit manager randomGenerator: (Random seed: 42).
 	aStream := ReadWriteStream with: ''.
 	fit printOn: aStream.
 	s := aStream contents.
@@ -150,8 +118,8 @@ PMGeneralFunctionFitTest >> testRelativeError [
 	fit := PMGeneralFunctionFit
 		       function: f
 		       data: col
-		       minimumValues: -6
-		       maximumValues: 6.
+		       minimumValues: 0
+		       maximumValues: 5.
 
 	fit manager randomGenerator: (Random seed: 42).
 	fit populationSize: 10.
@@ -170,13 +138,6 @@ PMGeneralFunctionFitTest >> testRelativeError [
 { #category : #tests }
 PMGeneralFunctionFitTest >> testResetBestPoints [
 
-	fit := PMGeneralFunctionFit
-		       function: f
-		       data: col
-		       minimumValues: 0
-		       maximumValues: 5.
-
-	fit manager randomGenerator: (Random seed: 42).
 	fit evaluate.
 	fit resetBestPoints.
 	self assertEmpty: fit optimizer bestPoints