Improved two tests and removed dependency on PMPolynomial

Author: olekscode

src/Math-Tests-Matrix/PMMatrixTest.class.st

@@ -157,34 +157,47 @@ PMMatrixTest >> testDimension [
 PMMatrixTest >> testEigenvalues [
 	"Code Example 8.15"
 
-	| m charPol roots eigenvalues finder |
-	m := PMMatrix rows: #(#(3 -2 0) #(-2 7 1) #(0 1 5)).
-	charPol := PMPolynomial coefficients: #(82 -66 15 -1).
-	roots := charPol roots asSortedCollection asArray reverse.
-	finder := PMJacobiTransformation matrix: m.
+	| matrix expectedEigenvalues eigenvalues finder |
+	
+	matrix := PMMatrix rows: #(
+		(3 -2 0) 
+		(-2 7 1)
+		(0 1 5)).
+		
+	expectedEigenvalues := #(8.105482616526306 4.776537928330764 2.1179794551429305).
+	
+	finder := PMJacobiTransformation matrix: matrix.
 	finder desiredPrecision: 1.0e-09.
+	
 	eigenvalues := finder evaluate.
-	self assert: eigenvalues size equals: 3.
-	self assert: ((roots at: 1) - (eigenvalues at: 1)) abs < 1.0e-09.
-	self assert: ((roots at: 2) - (eigenvalues at: 2)) abs < 1.0e-09.
-	self assert: ((roots at: 3) - (eigenvalues at: 3)) abs < 1.0e-09
+	
+	eigenvalues with: expectedEigenvalues do: [ :actual :expected |
+		self assert: actual closeTo: expected ].
 ]
 
 { #category : #'linear algebra' }
 PMMatrixTest >> testEigenvaluesLargest [
 	"Code Example 8.13"
 
-	| m charPol roots eigenvalue finder |
-	m := PMMatrix rows: #(#(3 -2 0) #(-2 7 1) #(0 1 5)).
-	charPol := PMPolynomial coefficients: #(82 -66 15 -1).
-	roots := charPol roots asSortedCollection asArray reverse.
-	finder := PMLargestEigenValueFinder matrix: m.
+	| matrix expectedEigenvalues firstEigenvalue secondEigenvalue finder |
+	
+	matrix := PMMatrix rows: #(
+		(3 -2 0)
+		(-2 7 1)
+		(0 1 5)).
+		
+	expectedEigenvalues := #(8.105482616526306 4.776537928330764 2.1179794551429305).
+	
+	finder := PMLargestEigenValueFinder matrix: matrix.
 	finder desiredPrecision: 1.0e-08.
-	eigenvalue := finder evaluate.
-	self assert: ((roots at: 1) - eigenvalue) abs < 1.0e-08.
+	
+	firstEigenvalue := finder evaluate.
+	
 	finder := finder nextLargestEigenValueFinder.
-	eigenvalue := finder evaluate.
-	self assert: ((roots at: 2) - eigenvalue) abs < 1.0e-08
+	secondEigenvalue := finder evaluate.
+	
+	self assert: firstEigenvalue closeTo: expectedEigenvalues first.
+	self assert: secondEigenvalue closeTo: expectedEigenvalues second.
 ]
 
 { #category : #tests }