Skip to content

Commit d1f4bf1

Browse files
committed
chore: Clean up code
1 parent 1af97a3 commit d1f4bf1

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

apps/oneclient/frontend/src/components/overlay/DownloadingMods.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ export function DownloadingMods({ mods, setOpen, nextPath }: { mods: Array<ModDa
4949
};
5050

5151
downloadAll();
52-
}, [mods]);
52+
}, [download, mods]);
5353

5454
useEffect(() => {
5555
if (downloadedMods >= mods.length) {
5656
setOpen(false);
5757
navigate({ to: nextPath });
5858
}
59-
}, [downloadedMods, mods]);
59+
}, [downloadedMods, mods, navigate, nextPath, setOpen]);
6060

6161
return (
6262
<Overlay.Dialog isDismissable={false}>

apps/oneclient/frontend/src/routes/onboarding/preferences/versionCategory.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { createFileRoute } from '@tanstack/react-router';
1313
import { DotsVerticalIcon } from '@untitled-theme/icons-react';
1414
import { OverlayScrollbarsComponent } from 'overlayscrollbars-react';
1515
import { useMemo, useRef, useState } from 'react';
16-
import { Button as AriaButton, DialogTrigger } from 'react-aria-components';
16+
import { Button as AriaButton } from 'react-aria-components';
1717
import { twMerge } from 'tailwind-merge';
1818
import { OnboardingNavigation } from '../route';
1919

@@ -139,18 +139,15 @@ function ModCategoryCard({ art, fullVersionName, bundle, mods, setMods, clusterI
139139
</div>
140140

141141
<ModCardContext.Provider value={context}>
142-
<DialogTrigger>
142+
<Overlay.Trigger>
143143
<Button className="absolute bottom-3 right-3 p-1 transition-colors" color="ghost" size="icon">
144144
<DotsVerticalIcon className="w-4 h-4 text-white" />
145145
</Button>
146146

147147
<Overlay>
148-
<BundleModListModal
149-
clusterId={clusterId}
150-
name={fullVersionName}
151-
/>
148+
<BundleModListModal clusterId={clusterId} name={fullVersionName} />
152149
</Overlay>
153-
</DialogTrigger>
150+
</Overlay.Trigger>
154151
</ModCardContext.Provider>
155152

156153
<div className="absolute bottom-3 left-3">

0 commit comments

Comments
 (0)