pipe all Starscript compilation through one helper that logs if the resulting script is big (>150bytes) (and an additional message if it's very big (>500bytes))

Author: GreemDev

src/Bot/Systems/Commands/Interaction/Modules/Utility/MathCommand.cs

@@ -16,12 +16,12 @@ public Task<RuntimeResult> MathAsync(
     {
         try
         {
-            var expr = expression.Replace("{", string.Empty).Replace("}", string.Empty);
+            expression = expression.Replace("{", string.Empty).Replace("}", string.Empty);
 
-            var result = VolteStarscript.RunExpression(expr);
+            var result = VolteStarscript.RunExpression(expression, Context.Guild);
 
             return Ok(Context.CreateEmbedBuilder()
-                    .AddField("Input", Format.Code(expr))
+                    .AddField("Input", Format.Code(expression))
                     .AddField("Output", Format.Code(result.ToString())),
                 ephemeral: !publicResult
             );

src/Bot/Systems/Commands/Text/Modules/UserFilterModule.cs

@@ -160,7 +160,7 @@ await Context.CreateEmbed("Are you sure you want to run the user filter on every
             {
                 try
                 {
-                    compiledEntries.Add((entry, entry.Starscript.Compile()));
+                    compiledEntries.Add((entry, entry.Starscript.Compile(Context.Guild)));
                 }
                 catch (ParseException)
                 {

src/Bot/Systems/Commands/Text/Modules/Utility/MathCommand.cs

@@ -1,5 +1,4 @@
 using Starscript;
-using Volte.Systems.Starscript;
 
 namespace Volte.Systems.Commands.Text.Modules;
 
@@ -11,12 +10,12 @@ public Task<ActionResult> MathAsync([Remainder, Description("The expression.")]
     {
         try
         {
-            var expr = expression.Replace("{", string.Empty).Replace("}", string.Empty);
-            
-            var result = VolteStarscript.RunExpression(expr);
+            expression = expression.Replace("{", string.Empty).Replace("}", string.Empty);
+
+            var result = Context.RunStarscriptMath(expression);
 
             return Ok(Context.CreateEmbedBuilder()
-                .AddField("Input", Format.Code(expr))
+                .AddField("Input", Format.Code(expression))
                 .AddField("Output", Format.Code(result.ToString())));
         }
         catch (ParseException pe)

src/Bot/Systems/Commands/Text/VolteContext.cs

@@ -127,9 +127,12 @@ public void Modify(DataEditor modifier)
             db.Save(GuildData);
     }
 
-    public StringSegment RunStarscript(string source) => VolteStarscript.Run(source, this);
+    public StringSegment RunStarscript(string source) => Guild.Run(source, this);
     public StringSegment RunStarscriptExpression(string expression) 
         => RunStarscript($"{{{expression.Replace("{", string.Empty).Replace("}", string.Empty)}}}");
+    
+    public StringSegment RunStarscriptMath(string expression) 
+        => VolteStarscript.CompileExpression(expression, Guild).Execute(VolteStarscript.MathHypervisor);
 
     public ValueMap ToStarscript() => new ValueMap()
         .Set("message", StarscriptHelper.Wrap(Message))

src/Bot/Systems/Database/Entities/StarscriptTables/StarscriptSrc.cs

@@ -9,10 +9,10 @@ public class StarscriptSrc
 
     public string CodeInput { get; set; }
 
-    public Script Compile() =>
+    public Script Compile(IGuild guild) =>
         Type is StarscriptType.SingleExpression
-            ? VolteStarscript.CompileExpression(CodeInput)
-            : VolteStarscript.Compile(CodeInput);
+            ? VolteStarscript.CompileExpression(CodeInput, guild)
+            : VolteStarscript.Compile(CodeInput, guild);
 
     public override string ToString()
         => $"{{ Type: {Type}, Source: {CodeInput} }}";

src/Bot/Systems/Database/EntitiesV2/StarscriptTables/StarscriptSrc.cs

@@ -9,10 +9,10 @@ public class StarscriptSrc
 
     public string CodeInput { get; set; }
 
-    public Script Compile() =>
+    public Script Compile(IGuild guild) =>
         Type is StarscriptType.SingleExpression
-            ? VolteStarscript.CompileExpression(CodeInput)
-            : VolteStarscript.Compile(CodeInput);
+            ? VolteStarscript.CompileExpression(CodeInput, guild)
+            : VolteStarscript.Compile(CodeInput, guild);
 
     public override string ToString()
         => $"{{ Type: {Type}, Source: {CodeInput} }}";

src/Bot/Systems/Database/EntitiesV2/WelcomeSettings.cs

@@ -38,7 +38,7 @@ public async ValueTask<string> FormatJoinMessageAsync(SocketGuildUser user)
 
         try
         {
-            return VolteStarscript.Run(msg, await StarscriptHelper.WrapAsync(user.Guild, user)).ToString();
+            return user.Guild.Run(msg, await StarscriptHelper.WrapAsync(user.Guild, user)).ToString();
         }
         catch
         {
@@ -59,7 +59,7 @@ public async ValueTask<string> FormatLeftMessageAsync(SocketGuild guild, SocketU
 
         try
         {
-            return VolteStarscript.Run(msg, await StarscriptHelper.WrapAsync(guild, user)).ToString();
+            return guild.Run(msg, await StarscriptHelper.WrapAsync(guild, user)).ToString();
         }
         catch
         {
@@ -80,7 +80,7 @@ public async ValueTask<string> FormatJoinDmMessageAsync(SocketGuildUser user)
 
         try
         {
-            return VolteStarscript.Run(msg, await StarscriptHelper.WrapAsync(user.Guild, user)).ToString();
+            return user.Guild.Run(msg, await StarscriptHelper.WrapAsync(user.Guild, user)).ToString();
         }
         catch
         {

src/Bot/Systems/Starscript/VolteStarscript.cs

@@ -14,28 +14,40 @@ public static bool GetBooleanValue(this StringSegment segment)
     public static readonly StarscriptHypervisor MathHypervisor = StarscriptHypervisor.Create().WithStandardLibraryMath();
 
 
-    public static StringSegment Run(string source, IStarscriptObject environment) 
-        => Run(source, environment.ToStarscript());
+    public static StringSegment Run(this IGuild currentGuild, string source, IStarscriptObject environment) 
+        => currentGuild.Run(source, environment.ToStarscript());
 
     public static StringSegment Run(Script script, IStarscriptObject environment) 
         => Run(script, environment.ToStarscript());
 
-    public static StringSegment Run(string source, ValueMap environment) 
-        => Run(Compile(source), environment);
+    public static StringSegment Run(this IGuild currentGuild, string source, ValueMap environment) 
+        => Run(Compile(source, currentGuild), environment);
 
     public static StringSegment Run(Script script, ValueMap environment) 
         => Hypervisor.ReplaceLocals(environment).Run(script, environment);
 
-    public static StringSegment RunExpression(string expression)
-        => CompileExpression(expression).Execute(MathHypervisor);
+    public static StringSegment RunExpression(string expression, IGuild guild)
+        => CompileExpression(expression, guild).Execute(MathHypervisor);
 
-    public static Script Compile(string source)
+    public static Script Compile(string source, IGuild guild)
     {
         if (!Parser.TryParse(source, out var result))
             throw new ParseException(result.Errors.First());
 
-        return Compiler.SingleCompile(result);
+        var script = Compiler.SingleCompile(result);
+        
+        if (script.Code.Length > 150)
+        {
+            Warn(LogSource.Service, 
+                $"Large compiled Starscript (>150 bytes): {{ Guild: \"{guild.Name}\" ({guild.Id})," +
+                $"CodeLength: {script.Code.Length}, ConstantsCount: {script.Constants.Length} }}");
+            
+            if (script.Code.Length > 500)
+                Warn(LogSource.Service, "It's over 500 bytes, should probably take a look!");
+        }
+
+        return script;
     }
 
-    public static Script CompileExpression(string source) => Compile($"{{{source}}}");
+    public static Script CompileExpression(string source, IGuild guild) => Compile($"{{{source}}}", guild);
 }

src/Bot/Systems/UserFilter/UserFilterTable.cs

@@ -56,7 +56,7 @@ public async Task<bool> HandleAsync(IGuild guild, IGuildUser user)
 
         try
         {
-            using (var script = Starscript.Compile())
+            using (var script = Starscript.Compile(guild))
             {
                 returnVal = VolteStarscript.Hypervisor.Run(script, StarscriptHelper.Wrap(user));
             }