Merge pull request #9 from PolyhedraZK/fix/withdraw-amount-in-relayer-request

fix(ops): send net recipient amount as burn_amount in withdraw request

Author: niconiconi

src/ops/ops.ts

@@ -500,7 +500,7 @@ export class Ops implements OpsApi {
           array_hash_index: arrayHashIndex,
           relayer: typedPlan.relayer,
           recipient: input.recipient,
-          withdraw_amount: burnAmount,
+          withdraw_amount: BigInt(typedPlan.requestedAmount),
           relayer_fee: relayerFee,
           gas_drop_value: gasDropValue,
           extra_data: extraData,

tests/opsPrepare.test.ts

@@ -378,7 +378,10 @@ describe('Ops.prepareTransfer / Ops.prepareWithdraw', () => {
 
     expect(planner.plan).toHaveBeenCalled();
     expect(merkle.getProofByCids).toHaveBeenCalledWith({ chainId, cids: [10], totalElements: 5n });
-    expect(zkp.proveWithdraw).toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ recipient, withdraw_amount: burnAmount }));
+    // withdraw_amount in the proof context must be the net recipient amount (requestedAmount),
+    // NOT burnAmount. The contract computes amountWithFee = inp.amount + protocolFee + relayerFee,
+    // which equals burnAmount only when inp.amount = requestedAmount (net).
+    expect(zkp.proveWithdraw).toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ recipient, withdraw_amount: plan.requestedAmount }));
 
     expect(res.meta.arrayHashIndex).toBe(4);
     expect(res.meta.merkleRootIndex).toBe(1);
@@ -388,7 +391,7 @@ describe('Ops.prepareTransfer / Ops.prepareWithdraw', () => {
     expect(res.witness.asset_policy.viewer_pk).toMatchObject({ EncryptionKey: { Key: { X: 1n, Y: 2n } } });
     expect(res.witness.asset_policy.freezer_pk).toMatchObject({ Point: { X: 3n, Y: 4n } });
     expect(res.request.path).toBe('/api/v1/burn');
-    expect((res.request.body as any).burn_amount).toBe(burnAmount.toString());
+    expect((res.request.body as any).burn_amount).toBe(plan.requestedAmount.toString());
     expect((res.request.body as any).gas_drop_value).toBe(gasDropValue.toString());
     expect((res.request.body as any).relayer_fee).toBe(relayerFee.toString());
   });