Fixed issue where default parser/serializer stripped out legit/existing html/head/body tags. (#20)

usergenic · web-flow · commit 6781d26181cf · 2019-06-25T14:18:14.000-07:00
* Fixed issue where default parser/serializer stripped out legit/existing html/head/body tags.
* Added a &lt;!DOCTYPE html&gt; to the test document to ensure it is preserved too.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ## Unreleased
 - Fixed issue where `nodeResolve()` did not properly effect the level of the provided `logger` where individual specifier transform logging was concerned.
 - Fix `Module '@babel/generator' resolves to an untyped module` error for TypeScript users.
+- Fix issue where html/head/body tags were stripped out by default parser/serializer.
 <!-- Add new unreleased items here -->
 
 ## [1.0.0-pre.4] - 2019-06-07
diff --git a/src/koa-module-specifier-transform.ts b/src/koa-module-specifier-transform.ts
@@ -50,7 +50,7 @@ export type ModuleSpecifierTransformOptions = {
 };
 
 const defaultHTMLParser = (html: string): Parse5Node =>
-    parse5Parse(html) as Parse5Node;
+    parse5Parse(html, {sourceCodeLocationInfo: true}) as Parse5Node;
 
 const defaultHTMLSerializer = (ast: Parse5Node): string => {
   removeFakeRootElements(ast);
diff --git a/src/test/koa-module-specifier-transform.test.ts b/src/test/koa-module-specifier-transform.test.ts
@@ -18,6 +18,51 @@ import {moduleSpecifierTransform} from '../koa-module-specifier-transform';
 
 import {createAndServe, squeeze, testLogger} from './test-utils';
 
+test(
+    'moduleSpecifierTransform default parse/serialize preserves tags',
+    async (t) => {
+      t.plan(1);
+      const logger = testLogger();
+      createAndServe(
+          {
+            middleware:
+                [moduleSpecifierTransform((_, __, ___) => './x.js', {logger})],
+            routes: {
+              '/my-page.html': `
+                <!DOCTYPE html>
+                <html>
+                  <head>
+                    <script type="module">
+                    import * as x from 'x';
+                    </script>
+                  </head>
+                  <body>
+                    Cool
+                  </body>
+                </html>
+              `,
+            },
+          },
+          async (server) => {
+            t.equal(
+                squeeze((await request(server).get('/my-page.html')).text),
+                squeeze(`
+                  <!DOCTYPE html>
+                  <html>
+                    <head>
+                      <script type="module">
+                      import * as x from './x.js';
+                      </script>
+                    </head>
+                    <body>
+                      Cool
+                    </body>
+                  </html>
+                `),
+                `should preserve existing html/head/body elements`);
+          });
+    });
+
 test('moduleSpecifierTransform callback returns undefined to noop', async (t) => {
   t.plan(3);
   const logger = testLogger();
