Skip to content

Commit 8e6366c

Browse files
committed
Merge pull request #1 from Polymer/ie
Fix shop-select default values in IE
2 parents 212f8c5 + 4f0f496 commit 8e6366c

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

src/shop-cart-item.html

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -179,18 +179,18 @@
179179
<label prefix>Qty:</label>
180180
<select id="quantitySelect" aria-label="Change quantity" value="[[entry.quantity]]"
181181
on-change="_quantityChange">
182-
<option>1</option>
183-
<option>2</option>
184-
<option>3</option>
185-
<option>4</option>
186-
<option>5</option>
187-
<option>6</option>
188-
<option>7</option>
189-
<option>8</option>
190-
<option>9</option>
191-
<option>10</option>
192-
<option>11</option>
193-
<option>12</option>
182+
<option value="1">1</option>
183+
<option value="2">2</option>
184+
<option value="3">3</option>
185+
<option value="4">4</option>
186+
<option value="5">5</option>
187+
<option value="6">6</option>
188+
<option value="7">7</option>
189+
<option value="8">8</option>
190+
<option value="9">9</option>
191+
<option value="10">10</option>
192+
<option value="11">11</option>
193+
<option value="12">12</option>
194194
</select>
195195
<shop-md-decorator aria-hidden="true"></shop-md-decorator>
196196
</shop-select>

src/shop-detail.html

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,11 @@ <h1>[[item.title]]</h1>
162162
<shop-select>
163163
<label id="sizeLabel" prefix>Size</label>
164164
<select id="sizeSelect" aria-labelledby="sizeLabel">
165-
<option>XS</option>
166-
<option>S</option>
167-
<option>M</option>
168-
<option>L</option>
169-
<option>XL</option>
165+
<option value="XS">XS</option>
166+
<option value="S">S</option>
167+
<option value="M" selected>M</option>
168+
<option value="L">L</option>
169+
<option value="XL">XL</option>
170170
</select>
171171
<shop-md-decorator aria-hidden="true">
172172
<shop-underline></shop-underline>
@@ -175,11 +175,11 @@ <h1>[[item.title]]</h1>
175175
<shop-select>
176176
<label id="quantityLabel" prefix>Quantity</label>
177177
<select id="quantitySelect" aria-labelledby="quantityLabel">
178-
<option>1</option>
179-
<option>2</option>
180-
<option>3</option>
181-
<option>4</option>
182-
<option>5</option>
178+
<option value="1" selected>1</option>
179+
<option value="2">2</option>
180+
<option value="3">3</option>
181+
<option value="4">4</option>
182+
<option value="5">5</option>
183183
</select>
184184
<shop-md-decorator aria-hidden="true">
185185
<shop-underline></shop-underline>

0 commit comments

Comments
 (0)