Modify InternalPropertyAdditionOps to use GraphWriter

Author: fabubaker

db4-storage/src/segments/graph/segment.rs

@@ -43,7 +43,7 @@ impl MemGraphSegment {
     pub fn new() -> Self {
         // Technically, these aren't used since there is always only one graph segment.
         let segment_id = 0;
-        let max_page_len = 0;
+        let max_page_len = 1;
         let meta = Arc::new(Meta::new_for_graph());
 
         Self {

raphtory-storage/src/mutation/property_addition_ops.rs

@@ -59,26 +59,35 @@ impl InternalPropertyAdditionOps for db4_graph::TemporalGraph<Extension> {
         t: TimeIndexEntry,
         props: &[(usize, Prop)],
     ) -> Result<(), Self::Error> {
-        // FIXME: check atomicity
-        for (id, prop) in props {
-            self.graph_meta().add_prop(t, *id, prop.clone())?;
-        }
+        let mut writer = self.storage().graph().writer();
+
+        // TODO: props should be passed as a vec instead of cloning
+        let props: Vec<_> = props.iter().map(|(id, prop)| (*id, prop.clone())).collect();
+
+        writer.add_properties(t, props);
+
         Ok(())
     }
 
     fn internal_add_metadata(&self, props: &[(usize, Prop)]) -> Result<(), Self::Error> {
-        // FIXME: check atomicity
-        for (id, prop) in props {
-            self.graph_meta().add_metadata(*id, prop.clone())?;
-        }
+        let mut writer = self.storage().graph().writer();
+
+        // TODO: props should be passed as a vec instead of cloning
+        let props: Vec<_> = props.iter().map(|(id, prop)| (*id, prop.clone())).collect();
+
+        writer.add_metadata(props);
+
         Ok(())
     }
 
     fn internal_update_metadata(&self, props: &[(usize, Prop)]) -> Result<(), Self::Error> {
-        // FIXME: check atomicity
-        for (id, prop) in props {
-            self.graph_meta().update_metadata(*id, prop.clone());
-        }
+        let mut writer = self.storage().graph().writer();
+
+        // TODO: props should be passed as a vec instead of cloning
+        let props: Vec<_> = props.iter().map(|(id, prop)| (*id, prop.clone())).collect();
+
+        writer.update_metadata(props);
+
         Ok(())
     }
 

raphtory/tests/db_tests.rs

@@ -1993,7 +1993,7 @@ fn test_graph_metadata() {
             .map(|(name, value)| (name, Prop::U64(value)))
             .collect::<Vec<_>>();
 
-    g.add_metadata(as_props.clone()).unwrap();
+        g.add_metadata(as_props.clone()).unwrap();
 
         let props_map = as_props.into_iter().collect::<HashMap<_, _>>();