Use &Path wherever possible

Author: fabubaker

db4-storage/src/api/graph.rs

@@ -5,15 +5,14 @@ use raphtory_api::core::entities::properties::prop::Prop;
 use parking_lot::{RwLockReadGuard, RwLockWriteGuard};
 use crate::segments::graph::segment::MemGraphSegment;
 use raphtory_api::core::entities::properties::tprop::TPropOps;
-use std::path::PathBuf;
 
 pub trait GraphSegmentOps: Send + Sync + Debug + 'static
 where
     Self: Sized,
 {
     type Entry<'a>: GraphEntryOps<'a>;
 
-    fn new(path: Option<PathBuf>) -> Self;
+    fn new(path: Option<&Path>) -> Self;
 
     fn load(path: impl AsRef<Path>) -> Result<Self, StorageError>;
 

db4-storage/src/pages/graph_store.rs

@@ -23,24 +23,24 @@ pub struct GraphStorageInner<GS, EXT> {
 }
 
 impl<GS: GraphSegmentOps, EXT: Config> GraphStorageInner<GS, EXT> {
-    pub fn new(path: Option<PathBuf>, ext: EXT) -> Self {
-        let page = Arc::new(GS::new(path.clone()));
+    pub fn new(path: Option<&Path>, ext: EXT) -> Self {
+        let page = Arc::new(GS::new(path));
         let graph_meta = Arc::new(GraphMeta::new());
 
         Self {
             page,
-            path,
+            path: path.map(|p| p.to_path_buf()),
             graph_meta,
             ext,
         }
     }
 
-    pub fn new_with_meta(path: Option<PathBuf>, graph_meta: Arc<GraphMeta>, ext: EXT) -> Self {
-        let page = Arc::new(GS::new(path.clone()));
+    pub fn new_with_meta(path: Option<&Path>, graph_meta: Arc<GraphMeta>, ext: EXT) -> Self {
+        let page = Arc::new(GS::new(path));
 
         Self {
             page,
-            path,
+            path: path.map(|p| p.to_path_buf()),
             graph_meta,
             ext,
         }

db4-storage/src/pages/mod.rs

@@ -182,7 +182,7 @@ impl<
             ext.clone(),
         ));
         let graph_storage = Arc::new(GraphStorageInner::new_with_meta(
-            graph_path,
+            graph_path.as_deref(),
             graph_meta,
             ext.clone(),
         ));

db4-storage/src/segments/graph/mod.rs

@@ -10,7 +10,6 @@ use crate::error::StorageError;
 use crate::segments::graph::segment::MemGraphSegment;
 use crate::segments::graph::entry::MemGraphEntry;
 use parking_lot::{RwLockReadGuard, RwLockWriteGuard};
-use std::path::PathBuf;
 
 /// `GraphSegmentView` manages graph temporal properties and graph metadata
 /// (constant properties). Reads / writes are always served from the in-memory segment.
@@ -27,7 +26,7 @@ pub struct GraphSegmentView {
 impl GraphSegmentOps for GraphSegmentView {
     type Entry<'a> = MemGraphEntry<'a>;
 
-    fn new(path: Option<PathBuf>) -> Self {
+    fn new(_path: Option<&Path>) -> Self {
         Self {
             head: Arc::new(RwLock::new(MemGraphSegment::new())),
             est_size: AtomicUsize::new(0),