make the proto feature actually protbuf specific

Author: ljeub-pometry

python/Cargo.toml

@@ -22,7 +22,6 @@ pyo3 = { workspace = true }
 raphtory = { workspace = true, features = [
     "python",
     "vectors",
-    "proto",
 ] }
 raphtory-graphql = { workspace = true, features = [
     "python",
@@ -31,6 +30,7 @@ raphtory-graphql = { workspace = true, features = [
 [features]
 extension-module = ["pyo3/extension-module"]
 search = ["raphtory/search", "raphtory-graphql/search"]
+proto = ["raphtory/proto"]
 
 [build-dependencies]
 pyo3-build-config = { workspace = true }

raphtory-benchmark/Cargo.toml

@@ -9,7 +9,6 @@ edition = "2021"
 criterion = { workspace = true }
 raphtory = { workspace = true, features = [
     "io",
-    "proto",
     "vectors",
 ] }
 raphtory-api = { workspace = true }
@@ -61,10 +60,12 @@ harness = false
 [[bench]]
 name = "proto_encode"
 harness = false
+required-features = ["proto"]
 
 [[bench]]
 name = "proto_decode"
 harness = false
+required-features = ["proto"]
 
 [[bench]]
 name = "search_bench"
@@ -82,3 +83,4 @@ required-features = ["search"]
 
 [features]
 search = ["raphtory/search"]
+proto = ["raphtory/proto"]

raphtory/Cargo.toml

@@ -123,6 +123,7 @@ io = [
     "dep:tokio",
     "dep:parquet",
     "dep:tempfile",
+    "dep:zip",
     "kdam",
 ]
 
@@ -168,7 +169,6 @@ arrow = [
 proto = [
     "dep:prost",
     "dep:prost-types",
-    "dep:zip",
     "dep:prost-build",
     "dep:memmap2",
     "arrow",

raphtory/src/errors.rs

@@ -255,7 +255,7 @@ pub enum GraphError {
     #[error("The path {0} does not contain a vector DB")]
     VectorDbDoesntExist(String),
 
-    #[cfg(feature = "proto")]
+    #[cfg(feature = "io")]
     #[error("zip operation failed")]
     ZipError {
         #[from]
@@ -327,7 +327,7 @@ pub enum GraphError {
     #[error("Protobuf decode error{0}")]
     EncodeError(#[from] prost::EncodeError),
 
-    #[cfg(feature = "proto")]
+    #[cfg(feature = "io")]
     #[error("Cannot write graph into non empty folder {0}")]
     NonEmptyGraphFolder(PathBuf),
 

raphtory/src/lib.rs

@@ -106,7 +106,7 @@ pub mod io;
 pub mod api;
 pub mod core;
 pub mod errors;
-#[cfg(feature = "proto")]
+#[cfg(feature = "io")]
 pub mod serialise;
 pub mod storage;
 
@@ -149,7 +149,7 @@ pub mod prelude {
         },
     };
 
-    #[cfg(feature = "proto")]
+    #[cfg(all(feature = "io", feature = "arrow"))]
     pub use crate::serialise::{
         parquet::{ParquetDecoder, ParquetEncoder},
         StableDecode, StableEncode,

raphtory/src/serialise/mod.rs

@@ -1,9 +1,14 @@
 mod graph_folder;
 pub mod metadata;
+#[cfg(feature = "arrow")]
 pub(crate) mod parquet;
+
+#[cfg(feature = "proto")]
 pub mod proto;
 mod serialise;
 
 pub use graph_folder::{GraphFolder, GRAPH_PATH, INDEX_PATH, META_PATH, VECTORS_PATH};
-pub use proto::proto_generated::Graph as ProtoGraph;
 pub use serialise::{StableDecode, StableEncode};
+
+#[cfg(feature = "proto")]
+pub use proto::proto_generated::Graph as ProtoGraph;

raphtory/src/serialise/parquet/model.rs

@@ -55,7 +55,7 @@ impl<'a> Serialize for ParquetProp<'a> {
             }
             Prop::Decimal(dec) => serializer.serialize_str(&dec.to_string()),
             Prop::Array(_) => {
-                todo!("Serializer not implemented for Array (TODO: ")
+                todo!("Serializer not implemented for Array (TODO: #2377)")
             }
         }
     }

raphtory/tests/serialise_test.rs

@@ -237,6 +237,7 @@ mod serialise_test {
     }
 
     #[test]
+    #[ignore = "TODO: #2377"]
     fn test_all_the_metadata_on_edge() {
         let mut props = vec![];
         write_props_to_vec(&mut props);