handle falsy check in vertex parameter mapping

narengogi · narengogi · commit dcd1a6a99011 · 2025-11-13T14:58:58.000+05:30
diff --git a/src/providers/google-vertex-ai/transformGenerationConfig.ts b/src/providers/google-vertex-ai/transformGenerationConfig.ts
@@ -10,19 +10,22 @@ import { EmbedInstancesData } from './types';
  */
 export function transformGenerationConfig(params: Params) {
   const generationConfig: Record<string, any> = {};
-  if (params['temperature']) {
+  if (params['temperature'] != null && params['temperature'] != undefined) {
     generationConfig['temperature'] = params['temperature'];
   }
-  if (params['top_p']) {
+  if (params['top_p'] != null && params['top_p'] != undefined) {
     generationConfig['topP'] = params['top_p'];
   }
-  if (params['top_k']) {
+  if (params['top_k'] != null && params['top_k'] != undefined) {
     generationConfig['topK'] = params['top_k'];
   }
-  if (params['max_tokens']) {
+  if (params['max_tokens'] != null && params['max_tokens'] != undefined) {
     generationConfig['maxOutputTokens'] = params['max_tokens'];
   }
-  if (params['max_completion_tokens']) {
+  if (
+    params['max_completion_tokens'] != null &&
+    params['max_completion_tokens'] != undefined
+  ) {
     generationConfig['maxOutputTokens'] = params['max_completion_tokens'];
   }
   if (params['stop']) {
@@ -34,10 +37,10 @@ export function transformGenerationConfig(params: Params) {
   if (params['logprobs']) {
     generationConfig['responseLogprobs'] = params['logprobs'];
   }
-  if (params['top_logprobs']) {
+  if (params['top_logprobs'] != null && params['top_logprobs'] != undefined) {
     generationConfig['logprobs'] = params['top_logprobs']; // range 1-5, openai supports 1-20
   }
-  if (params['seed']) {
+  if (params['seed'] != null && params['seed'] != undefined) {
     generationConfig['seed'] = params['seed'];
   }
   if (params?.response_format?.type === 'json_schema') {
diff --git a/src/providers/google/chatComplete.ts b/src/providers/google/chatComplete.ts
@@ -35,19 +35,22 @@ import { GOOGLE_GENERATE_CONTENT_FINISH_REASON } from './types';
 
 const transformGenerationConfig = (params: Params) => {
   const generationConfig: Record<string, any> = {};
-  if (params['temperature']) {
+  if (params['temperature'] != null && params['temperature'] != undefined) {
     generationConfig['temperature'] = params['temperature'];
   }
-  if (params['top_p']) {
+  if (params['top_p'] != null && params['top_p'] != undefined) {
     generationConfig['topP'] = params['top_p'];
   }
-  if (params['top_k']) {
+  if (params['top_k'] != null && params['top_k'] != undefined) {
     generationConfig['topK'] = params['top_k'];
   }
-  if (params['max_tokens']) {
+  if (params['max_tokens'] != null && params['max_tokens'] != undefined) {
     generationConfig['maxOutputTokens'] = params['max_tokens'];
   }
-  if (params['max_completion_tokens']) {
+  if (
+    params['max_completion_tokens'] != null &&
+    params['max_completion_tokens'] != undefined
+  ) {
     generationConfig['maxOutputTokens'] = params['max_completion_tokens'];
   }
   if (params['stop']) {
@@ -59,10 +62,10 @@ const transformGenerationConfig = (params: Params) => {
   if (params['logprobs']) {
     generationConfig['responseLogprobs'] = params['logprobs'];
   }
-  if (params['top_logprobs']) {
+  if (params['top_logprobs'] != null && params['top_logprobs'] != undefined) {
     generationConfig['logprobs'] = params['top_logprobs']; // range 1-5, openai supports 1-20
   }
-  if (params['seed']) {
+  if (params['seed'] != null && params['seed'] != undefined) {
     generationConfig['seed'] = params['seed'];
   }
   if (params?.response_format?.type === 'json_schema') {

Original file line number	Diff line number	Diff line change
`@@ -10,19 +10,22 @@ import { EmbedInstancesData } from './types';`
`10`	`10`	`*/`
`11`	`11`	`export function transformGenerationConfig(params: Params) {`
`12`	`12`	`const generationConfig: Record<string, any> = {};`
`13`		`- if (params['temperature']) {`
	`13`	`+ if (params['temperature'] != null && params['temperature'] != undefined) {`
`14`	`14`	`generationConfig['temperature'] = params['temperature'];`
`15`	`15`	`}`
`16`		`- if (params['top_p']) {`
	`16`	`+ if (params['top_p'] != null && params['top_p'] != undefined) {`
`17`	`17`	`generationConfig['topP'] = params['top_p'];`
`18`	`18`	`}`
`19`		`- if (params['top_k']) {`
	`19`	`+ if (params['top_k'] != null && params['top_k'] != undefined) {`
`20`	`20`	`generationConfig['topK'] = params['top_k'];`
`21`	`21`	`}`
`22`		`- if (params['max_tokens']) {`
	`22`	`+ if (params['max_tokens'] != null && params['max_tokens'] != undefined) {`
`23`	`23`	`generationConfig['maxOutputTokens'] = params['max_tokens'];`
`24`	`24`	`}`
`25`		`- if (params['max_completion_tokens']) {`
	`25`	`+ if (`
	`26`	`+ params['max_completion_tokens'] != null &&`
	`27`	`+ params['max_completion_tokens'] != undefined`
	`28`	`+ ) {`
`26`	`29`	`generationConfig['maxOutputTokens'] = params['max_completion_tokens'];`
`27`	`30`	`}`
`28`	`31`	`if (params['stop']) {`
`@@ -34,10 +37,10 @@ export function transformGenerationConfig(params: Params) {`
`34`	`37`	`if (params['logprobs']) {`
`35`	`38`	`generationConfig['responseLogprobs'] = params['logprobs'];`
`36`	`39`	`}`
`37`		`- if (params['top_logprobs']) {`
	`40`	`+ if (params['top_logprobs'] != null && params['top_logprobs'] != undefined) {`
`38`	`41`	`generationConfig['logprobs'] = params['top_logprobs']; // range 1-5, openai supports 1-20`
`39`	`42`	`}`
`40`		`- if (params['seed']) {`
	`43`	`+ if (params['seed'] != null && params['seed'] != undefined) {`
`41`	`44`	`generationConfig['seed'] = params['seed'];`
`42`	`45`	`}`
`43`	`46`	`if (params?.response_format?.type === 'json_schema') {`
Original file line number	Diff line number	Diff line change
`@@ -35,19 +35,22 @@ import { GOOGLE_GENERATE_CONTENT_FINISH_REASON } from './types';`
`35`	`35`
`36`	`36`	`const transformGenerationConfig = (params: Params) => {`
`37`	`37`	`const generationConfig: Record<string, any> = {};`
`38`		`- if (params['temperature']) {`
	`38`	`+ if (params['temperature'] != null && params['temperature'] != undefined) {`
`39`	`39`	`generationConfig['temperature'] = params['temperature'];`
`40`	`40`	`}`
`41`		`- if (params['top_p']) {`
	`41`	`+ if (params['top_p'] != null && params['top_p'] != undefined) {`
`42`	`42`	`generationConfig['topP'] = params['top_p'];`
`43`	`43`	`}`
`44`		`- if (params['top_k']) {`
	`44`	`+ if (params['top_k'] != null && params['top_k'] != undefined) {`
`45`	`45`	`generationConfig['topK'] = params['top_k'];`
`46`	`46`	`}`
`47`		`- if (params['max_tokens']) {`
	`47`	`+ if (params['max_tokens'] != null && params['max_tokens'] != undefined) {`
`48`	`48`	`generationConfig['maxOutputTokens'] = params['max_tokens'];`
`49`	`49`	`}`
`50`		`- if (params['max_completion_tokens']) {`
	`50`	`+ if (`
	`51`	`+ params['max_completion_tokens'] != null &&`
	`52`	`+ params['max_completion_tokens'] != undefined`
	`53`	`+ ) {`
`51`	`54`	`generationConfig['maxOutputTokens'] = params['max_completion_tokens'];`
`52`	`55`	`}`
`53`	`56`	`if (params['stop']) {`
`@@ -59,10 +62,10 @@ const transformGenerationConfig = (params: Params) => {`
`59`	`62`	`if (params['logprobs']) {`
`60`	`63`	`generationConfig['responseLogprobs'] = params['logprobs'];`
`61`	`64`	`}`
`62`		`- if (params['top_logprobs']) {`
	`65`	`+ if (params['top_logprobs'] != null && params['top_logprobs'] != undefined) {`
`63`	`66`	`generationConfig['logprobs'] = params['top_logprobs']; // range 1-5, openai supports 1-20`
`64`	`67`	`}`
`65`		`- if (params['seed']) {`
	`68`	`+ if (params['seed'] != null && params['seed'] != undefined) {`
`66`	`69`	`generationConfig['seed'] = params['seed'];`
`67`	`70`	`}`
`68`	`71`	`if (params?.response_format?.type === 'json_schema') {`