minor changes

Author: narengogi

portkey_ai/api_resources/instrumentation/crewai/patch.py

@@ -26,10 +26,14 @@ def traced_func(wrapped, instance, args, kwargs):
                 span.set_attribute("kwargs", serialize_kwargs(**kwargs))
 
                 result = wrapped(*args, **kwargs)
-                set_span_attribute(span, "result", result)
                 span.set_status(Status(StatusCode.OK))
 
-                set_members(span, instance, module_name, class_name)
+                try:
+                    set_members(span, instance, module_name, class_name)
+                except Exception as e:
+                    span.record_exception(e)
+
+                set_span_attribute(span, "result", result)
 
                 if class_name == "Crew":
                     for attr in ["tasks_output", "token_usage", "usage_metrics"]:

portkey_ai/api_resources/instrumentation/langgraph/patch.py

@@ -32,7 +32,11 @@ def traced_func(wrapped, instance, args, kwargs):
 
                 span.set_status(Status(StatusCode.OK))
 
-                set_members(span, instance, module_name, class_name)
+                try:
+                    set_members(span, instance, module_name, class_name)
+                except Exception as e:
+                    span.record_exception(e)
+
             except Exception as e:
                 span.record_exception(e)
                 span.set_status(Status(StatusCode.ERROR, str(e)))

portkey_ai/api_resources/instrumentation/litellm/patch.py

@@ -43,8 +43,8 @@ def traced_func(wrapped, instance, args, kwargs):
 
                 try:
                     set_members(span, instance, module_name, class_name)
-                except Exception:
-                    span.set_attribute(f"{module_name}.{class_name}.error", instance)
+                except Exception as e:
+                    span.record_exception(e)
 
                 set_span_attribute(span, "result", result)
 

portkey_ai/api_resources/instrumentation/utils.py

@@ -22,7 +22,7 @@ def set_span_attribute(span: Span, key: str, value: Any, _processed=None, depth=
         else:
             _processed.add(obj_id)
             for child_key, child_value in value.__dict__.items():
-                if child_key.startswith("_"):
+                if child_key.startswith("_") or child_value is None:
                     continue
                 set_span_attribute(
                     span, f"{key}.{child_key}", child_value, _processed, depth + 1
@@ -32,5 +32,7 @@ def set_span_attribute(span: Span, key: str, value: Any, _processed=None, depth=
 
 
 def set_members(span: Span, instance: Any, module_name: str, class_name: str):
+    if instance is None:
+        return
     for key, value in instance.__dict__.items():
         set_span_attribute(span, f"{module_name}.{class_name}.{key}", value)