Remove the base class EmailModel.

GillesTourreau · GillesTourreau · commit e4d66f8bb92a · 2025-11-16T11:47:05.000+01:00
diff --git a/src/Emailing.Templates.Razor/README.md b/src/Emailing.Templates.Razor/README.md
@@ -43,7 +43,7 @@ Example model used by the templates:
 ```csharp
 using PosInformatique.Foundations.Emailing;
 
-public sealed class InvitationEmailTemplateModel : EmailModel
+public sealed class InvitationEmailTemplateModel
 {
     public string FirstName { get; set; } = string.Empty;
     public string InvitationLink { get; set; } = string.Empty;
diff --git a/src/Emailing.Templates.Razor/RazorEmailTemplate.cs b/src/Emailing.Templates.Razor/RazorEmailTemplate.cs
@@ -13,7 +13,6 @@ namespace PosInformatique.Foundations.Emailing.Templates.Razor
     /// </summary>
     /// <typeparam name="TModel">Type of the model used to generate the subject and body of the e-mail.</typeparam>
     public static class RazorEmailTemplate<TModel>
-        where TModel : EmailModel
     {
         /// <summary>
         /// Creates an <see cref="EmailTemplate{TModel}"/> using the specified Razor components as text templating for the subject and body.
diff --git a/src/Emailing.Templates.Razor/RazorEmailTemplateBody.cs b/src/Emailing.Templates.Razor/RazorEmailTemplateBody.cs
@@ -13,7 +13,6 @@ namespace PosInformatique.Foundations.Emailing.Templates.Razor
     /// </summary>
     /// <typeparam name="TModel">Type of the <see cref="Model"/> used to generate the body of the e-mail.</typeparam>
     public abstract class RazorEmailTemplateBody<TModel> : ComponentBase
-        where TModel : EmailModel
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="RazorEmailTemplateBody{TModel}"/> class.
diff --git a/src/Emailing.Templates.Razor/RazorEmailTemplateSubject.cs b/src/Emailing.Templates.Razor/RazorEmailTemplateSubject.cs
@@ -13,7 +13,6 @@ namespace PosInformatique.Foundations.Emailing.Templates.Razor
     /// </summary>
     /// <typeparam name="TModel">Type of the <see cref="Model"/> used to generate the subject of the e-mail.</typeparam>
     public abstract class RazorEmailTemplateSubject<TModel> : ComponentBase
-        where TModel : EmailModel
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="RazorEmailTemplateSubject{TModel}"/> class.
diff --git a/src/Emailing/Email.cs b/src/Emailing/Email.cs
@@ -11,7 +11,6 @@ namespace PosInformatique.Foundations.Emailing
     /// </summary>
     /// <typeparam name="TModel">Type of data model injected to the <see cref="Template"/> to generate the e-mail.</typeparam>
     public sealed class Email<TModel>
-        where TModel : EmailModel
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="Email{TModel}"/> class
diff --git a/src/Emailing/EmailManager.cs b/src/Emailing/EmailManager.cs
@@ -30,7 +30,6 @@ public EmailManager(IOptions<EmailingOptions> options, IEmailProvider provider,
         }
 
         public Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier)
-            where TModel : EmailModel
         {
             ArgumentNullException.ThrowIfNull(identifier);
 
@@ -45,7 +44,6 @@ public Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier)
         }
 
         public async Task SendAsync<TModel>(Email<TModel> email, CancellationToken cancellationToken = default)
-            where TModel : EmailModel
         {
             ArgumentNullException.ThrowIfNull(email);
 
diff --git a/src/Emailing/EmailModel.cs b/src/Emailing/EmailModel.cs
diff --git a/src/Emailing/EmailRecipientCollection.cs b/src/Emailing/EmailRecipientCollection.cs
@@ -14,7 +14,6 @@ namespace PosInformatique.Foundations.Emailing
     /// </summary>
     /// <typeparam name="TModel">Data model injected to the <see cref="EmailTemplate{TModel}"/> to generate the e-mail for each recipient.</typeparam>
     public class EmailRecipientCollection<TModel> : Collection<EmailRecipient<TModel>>
-        where TModel : EmailModel
     {
         /// <summary>
         /// Creates and add new <see cref="EmailRecipient{TModel}"/> in the <see cref="EmailRecipientCollection{TModel}"/>.
diff --git a/src/Emailing/EmailTemplate.cs b/src/Emailing/EmailTemplate.cs
@@ -13,7 +13,6 @@ namespace PosInformatique.Foundations.Emailing
     /// </summary>
     /// <typeparam name="TModel">Type of data model injected to the <see cref="Subject"/> and <see cref="HtmlBody"/> to generate the e-mail.</typeparam>
     public class EmailTemplate<TModel>
-        where TModel : EmailModel
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="EmailTemplate{TModel}"/> class.
diff --git a/src/Emailing/EmailTemplateIdentifier.cs b/src/Emailing/EmailTemplateIdentifier.cs
@@ -11,7 +11,6 @@ namespace PosInformatique.Foundations.Emailing
     /// </summary>
     /// <typeparam name="TModel">Data model injected to the <see cref="EmailTemplate{TModel}"/> to generate the e-mail.</typeparam>
     public sealed class EmailTemplateIdentifier<TModel>
-        where TModel : EmailModel
     {
         private EmailTemplateIdentifier()
         {
diff --git a/src/Emailing/EmailingOptions.cs b/src/Emailing/EmailingOptions.cs
@@ -38,7 +38,6 @@ public EmailingOptions()
         /// <exception cref="ArgumentNullException">Thrown when the <paramref name="template"/> argument is <see langword="null"/>.</exception>
         /// <exception cref="ArgumentException">If a <see cref="EmailTemplate{TModel}"/> has already been registered with the specified <paramref name="identifier"/>.</exception>
         public void RegisterTemplate<TModel>(EmailTemplateIdentifier<TModel> identifier, EmailTemplate<TModel> template)
-            where TModel : EmailModel
         {
             ArgumentNullException.ThrowIfNull(identifier);
             ArgumentNullException.ThrowIfNull(template);
@@ -52,7 +51,6 @@ public void RegisterTemplate<TModel>(EmailTemplateIdentifier<TModel> identifier,
         }
 
         internal EmailTemplate<TModel>? GetTemplate<TModel>(EmailTemplateIdentifier<TModel> identifier)
-            where TModel : EmailModel
         {
             if (!this.templates.TryGetValue(identifier, out var templateFound))
             {
diff --git a/src/Emailing/IEmailManager.cs b/src/Emailing/IEmailManager.cs
@@ -25,8 +25,7 @@ public interface IEmailManager
         /// associated to the <paramref name="identifier"/>.</returns>
         /// <exception cref="ArgumentNullException">Thrown when the <paramref name="identifier"/> argument is <see langword="null"/>.</exception>
         /// <exception cref="ArgumentException">Thrown if no <see cref="EmailTemplate{TModel}"/> has been registered with the specified <paramref name="identifier"/>.</exception>
-        Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier)
-            where TModel : EmailModel;
+        Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier);
 
         /// <summary>
         /// Sends the specified <paramref name="email"/>.
@@ -36,7 +35,6 @@ Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier)
         /// <param name="cancellationToken"><see cref="CancellationToken"/> which allows to cancel the send process.</param>
         /// <returns>An instance of the <see cref="Task"/> class which represents the asynchronous operation.</returns>
         /// <exception cref="ArgumentNullException">Thrown when the <paramref name="email"/> argument is <see langword="null"/>.</exception>
-        Task SendAsync<TModel>(Email<TModel> email, CancellationToken cancellationToken = default)
-            where TModel : EmailModel;
+        Task SendAsync<TModel>(Email<TModel> email, CancellationToken cancellationToken = default);
     }
 }
diff --git a/src/Emailing/README.md b/src/Emailing/README.md
@@ -38,27 +38,27 @@ and one of its concrete implementations (for example
 
 - Registration of email templates through `AddEmailing(...)` and `EmailingOptions.RegisterTemplate(...)`.
 - Strongly-typed template identifiers via `EmailTemplateIdentifier<TModel>`.
-- Data models for templates based on an abstract `EmailModel` base class.
+- Data models for templates based on any custom class.
 - Template-based subject and HTML body using `TextTemplate<TModel>` (e.g. Razor or Scriban).
-- Per-recipient data injection using a `EmailModel` with `EmailRecipient<TModel>`.
+- Per-recipient data injection using a model with `EmailRecipient<TModel>`.
 - Central `IEmailManager` to create and send emails.
 - Pluggable `IEmailProvider` to send the final `EmailMessage` (transport-agnostic design).
 
 ## Basic concepts
 
 ### Email models
 
-Each email template is associated with a data model that derives from `EmailModel`.
+Each email template is associated with a data model.
 This model is injected into the subject and HTML body templates when generating the email content for a recipient.
 
 ```csharp
-public sealed class InvitationEmailTemplateModel : EmailModel
+public sealed class InvitationEmailTemplateModel
 {
     public string FirstName { get; set; } = string.Empty;
     public string InvitationLink { get; set; } = string.Empty;
 }
 
-public sealed class AccountDeletionEmailTemplateModel : EmailModel
+public sealed class AccountDeletionEmailTemplateModel
 {
     public string FirstName { get; set; } = string.Empty;
     public DateTime DeletionDate { get; set; }
@@ -226,7 +226,7 @@ The typical flow is:
    - Register templates and sender via `AddEmailing(...)`.
    - Register an `IEmailProvider` implementation.
 2. Define and centralize template identifiers using `EmailTemplateIdentifier<TModel>`.
-3. Define data models by inheriting from `EmailModel`.
+3. Define data models by creating custom data class.
 4. At runtime, use `IEmailManager.Create(...)` to instantiate a strongly-typed email.
 5. Add recipients and models through `EmailRecipientCollection<TModel>`.
 6. Call `IEmailManager.SendAsync()` to generate and send emails through the `IEmailProvider`.
diff --git a/tests/Emailing.Templates.Razor.Tests/RazorEmailTemplateBodyTest.cs b/tests/Emailing.Templates.Razor.Tests/RazorEmailTemplateBodyTest.cs
@@ -20,7 +20,7 @@ public void Constructor()
             template.Model.Should().BeSameAs(model);
         }
 
-        internal sealed class Model : EmailModel
+        internal sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Templates.Razor.Tests/RazorEmailTemplateSubjectTest.cs b/tests/Emailing.Templates.Razor.Tests/RazorEmailTemplateSubjectTest.cs
@@ -20,7 +20,7 @@ public void Constructor()
             template.Model.Should().BeSameAs(model);
         }
 
-        internal sealed class Model : EmailModel
+        internal sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Templates.Razor.Tests/RazorEmailTemplateTest.cs b/tests/Emailing.Templates.Razor.Tests/RazorEmailTemplateTest.cs
@@ -19,7 +19,7 @@ public void Create()
             template.Subject.Should().BeOfType<RazorTextTemplate<Model>>();
         }
 
-        private sealed class Model : EmailModel
+        private sealed class Model
         {
         }
 
diff --git a/tests/Emailing.Tests/EmailManagerTest.cs b/tests/Emailing.Tests/EmailManagerTest.cs
@@ -186,7 +186,7 @@ await manager.Invoking(m => m.SendAsync<Model>(null, default))
                 .WithParameterName("email");
         }
 
-        internal sealed class Model : EmailModel
+        internal sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Tests/EmailRecipientCollectionTest.cs b/tests/Emailing.Tests/EmailRecipientCollectionTest.cs
@@ -68,7 +68,7 @@ public void Add_WithNullModel()
                 .WithParameterName("model");
         }
 
-        private sealed class Model : EmailModel
+        private sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Tests/EmailRecipientTest.cs b/tests/Emailing.Tests/EmailRecipientTest.cs
@@ -63,7 +63,7 @@ public void Constructor_WithNullModel()
                 .WithParameterName("model");
         }
 
-        private class Model : EmailModel
+        private class Model
         {
         }
     }
diff --git a/tests/Emailing.Tests/EmailTemplateIdentifierTest.cs b/tests/Emailing.Tests/EmailTemplateIdentifierTest.cs
@@ -17,7 +17,7 @@ public void Constructor()
             identifier.Should().NotBeSameAs(otherIdentifier);
         }
 
-        private sealed class Model : EmailModel
+        private sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Tests/EmailTemplateTest.cs b/tests/Emailing.Tests/EmailTemplateTest.cs
@@ -48,7 +48,7 @@ public void Constructor_WithNullHtmlBody()
                 .WithParameterName("htmlBody");
         }
 
-        internal sealed class Model : EmailModel
+        internal sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Tests/EmailTest.cs b/tests/Emailing.Tests/EmailTest.cs
@@ -36,7 +36,7 @@ public void Constructor_WithNullTemplate()
                 .WithParameterName("template");
         }
 
-        internal sealed class Model : EmailModel
+        internal sealed class Model
         {
         }
     }
diff --git a/tests/Emailing.Tests/EmailingOptionsTest.cs b/tests/Emailing.Tests/EmailingOptionsTest.cs
@@ -92,7 +92,7 @@ public void GetTemplate_NotRegistered()
             options.GetTemplate(identifier).Should().BeNull();
         }
 
-        public sealed class Model : EmailModel
+        public sealed class Model
         {
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ Example model used by the templates:`
`43`	`43`	```csharp
`44`	`44`	`using PosInformatique.Foundations.Emailing;`
`45`	`45`
`46`		`-public sealed class InvitationEmailTemplateModel : EmailModel`
	`46`	`+public sealed class InvitationEmailTemplateModel`
`47`	`47`	`{`
`48`	`48`	`public string FirstName { get; set; } = string.Empty;`
`49`	`49`	`public string InvitationLink { get; set; } = string.Empty;`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@ namespace PosInformatique.Foundations.Emailing.Templates.Razor`
`13`	`13`	`/// </summary>`
`14`	`14`	`/// <typeparam name="TModel">Type of the model used to generate the subject and body of the e-mail.</typeparam>`
`15`	`15`	`public static class RazorEmailTemplate<TModel>`
`16`		`- where TModel : EmailModel`
`17`	`16`	`{`
`18`	`17`	`/// <summary>`
`19`	`18`	`/// Creates an <see cref="EmailTemplate{TModel}"/> using the specified Razor components as text templating for the subject and body.`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ namespace PosInformatique.Foundations.Emailing`
`11`	`11`	`/// </summary>`
`12`	`12`	`/// <typeparam name="TModel">Type of data model injected to the <see cref="Template"/> to generate the e-mail.</typeparam>`
`13`	`13`	`public sealed class Email<TModel>`
`14`		`- where TModel : EmailModel`
`15`	`14`	`{`
`16`	`15`	`/// <summary>`
`17`	`16`	`/// Initializes a new instance of the <see cref="Email{TModel}"/> class`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ public EmailManager(IOptions<EmailingOptions> options, IEmailProvider provider,`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`public Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier)`
`33`		`- where TModel : EmailModel`
`34`	`33`	`{`
`35`	`34`	`ArgumentNullException.ThrowIfNull(identifier);`
`36`	`35`
`@@ -45,7 +44,6 @@ public Email<TModel> Create<TModel>(EmailTemplateIdentifier<TModel> identifier)`
`45`	`44`	`}`
`46`	`45`
`47`	`46`	`public async Task SendAsync<TModel>(Email<TModel> email, CancellationToken cancellationToken = default)`
`48`		`- where TModel : EmailModel`
`49`	`47`	`{`
`50`	`48`	`ArgumentNullException.ThrowIfNull(email);`
`51`	`49`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ namespace PosInformatique.Foundations.Emailing`
`14`	`14`	`/// </summary>`
`15`	`15`	`/// <typeparam name="TModel">Data model injected to the <see cref="EmailTemplate{TModel}"/> to generate the e-mail for each recipient.</typeparam>`
`16`	`16`	`public class EmailRecipientCollection<TModel> : Collection<EmailRecipient<TModel>>`
`17`		`- where TModel : EmailModel`
`18`	`17`	`{`
`19`	`18`	`/// <summary>`
`20`	`19`	`/// Creates and add new <see cref="EmailRecipient{TModel}"/> in the <see cref="EmailRecipientCollection{TModel}"/>.`