fix: check if a repo exists in task detail (#107)

jonathanlab · web-flow · commit 0e9fcdbd11da · 2025-10-31T17:01:58.000+01:00
diff --git a/src/renderer/features/tasks/components/TaskDetail.tsx b/src/renderer/features/tasks/components/TaskDetail.tsx
@@ -14,6 +14,7 @@ import { GearIcon, GlobeIcon } from "@radix-ui/react-icons";
 import {
   Box,
   Button,
+  Callout,
   Code,
   DataList,
   Flex,
@@ -24,7 +25,9 @@ import {
   Tooltip,
 } from "@radix-ui/themes";
 import type { Task } from "@shared/types";
+import { cloneStore } from "@stores/cloneStore";
 import { useLayoutStore } from "@stores/layoutStore";
+import { repositoryWorkspaceStore } from "@stores/repositoryWorkspaceStore";
 import { useTabStore } from "@stores/tabStore";
 import { expandTildePath } from "@utils/path";
 import { format, formatDistanceToNow } from "date-fns";
@@ -63,12 +66,13 @@ export function TaskDetail({ task: initialTask }: TaskDetailProps) {
 
   const task = tasks.find((t) => t.id === initialTask.id) || initialTask;
 
-  const taskState = getTaskState(task.id);
+  const taskState = getTaskState(task.id, task);
 
   const {
     isRunning,
     logs,
     repoPath,
+    repoExists,
     runMode,
     progress,
     planModePhase,
@@ -96,6 +100,15 @@ export function TaskDetail({ task: initialTask }: TaskDetailProps) {
     return `${expandedWorkspace}/${task.repository_config.repository}`;
   }, [task.repository_config, defaultWorkspace]);
 
+  // Check if repository is being cloned using existing cloneStore method
+  const isCloningRepo = cloneStore((state) =>
+    task.repository_config
+      ? state.isCloning(
+          `${task.repository_config.organization}/${task.repository_config.repository}`,
+        )
+      : false,
+  );
+
   useEffect(() => {
     resetForm({
       title: task.title,
@@ -136,6 +149,21 @@ export function TaskDetail({ task: initialTask }: TaskDetailProps) {
     clearTaskLogs(task.id);
   };
 
+  const handleCloneRepository = async () => {
+    if (!task.repository_config) return;
+    await repositoryWorkspaceStore
+      .getState()
+      .selectRepository(task.repository_config);
+  };
+
+  const getRunButtonLabel = () => {
+    if (isRunning) return "Running...";
+    if (isCloningRepo) return "Cloning...";
+    if (runMode === "cloud") return "Run (Cloud)";
+    if (repoExists === false) return "Clone repository";
+    return "Run (Local)";
+  };
+
   const handleAnswersComplete = async (
     answers: Array<{
       questionId: string;
@@ -361,6 +389,17 @@ export function TaskDetail({ task: initialTask }: TaskDetailProps) {
             </Flex>
 
             <Flex direction="column" gap="3" mt="4">
+              {/* Repository status */}
+              {repoExists === false &&
+                task.repository_config &&
+                runMode === "local" && (
+                  <Callout.Root color="gray" size="2">
+                    <Callout.Text size="1">
+                      Repository not in workspace. Clone to run agent locally.
+                    </Callout.Text>
+                  </Callout.Root>
+                )}
+
               {/* Task Artifacts */}
               {repoPath && (
                 <TaskArtifacts
@@ -374,23 +413,23 @@ export function TaskDetail({ task: initialTask }: TaskDetailProps) {
               <Flex gap="2">
                 <Button
                   variant="classic"
-                  onClick={handleRunTask}
-                  disabled={isRunning}
+                  onClick={
+                    runMode === "local" && repoExists === false
+                      ? handleCloneRepository
+                      : handleRunTask
+                  }
+                  disabled={isRunning || isCloningRepo}
                   size="2"
                   style={{ flex: 1 }}
                 >
-                  {isRunning
-                    ? "Running..."
-                    : runMode === "cloud"
-                      ? "Run (Cloud)"
-                      : "Run (Local)"}
+                  {getRunButtonLabel()}
                 </Button>
                 <Tooltip content="Toggle between Local or Cloud Agent">
                   <IconButton
                     size="2"
                     variant="classic"
                     color={runMode === "cloud" ? "blue" : "gray"}
-                    disabled={isRunning}
+                    disabled={isRunning || isCloningRepo}
                     onClick={() =>
                       handleRunModeChange(
                         runMode === "local" ? "cloud" : "local",
diff --git a/src/renderer/features/tasks/stores/taskExecutionStore.ts b/src/renderer/features/tasks/stores/taskExecutionStore.ts
@@ -83,6 +83,7 @@ interface TaskExecutionState {
   isRunning: boolean;
   logs: AgentEvent[];
   repoPath: string | null;
+  repoExists: boolean | null;
   currentTaskId: string | null;
   runMode: "local" | "cloud";
   unsubscribe: (() => void) | null;
@@ -102,7 +103,7 @@ interface TaskExecutionStore {
   taskStates: Record<string, TaskExecutionState>;
 
   // Basic state accessors
-  getTaskState: (taskId: string) => TaskExecutionState;
+  getTaskState: (taskId: string, task?: Task) => TaskExecutionState;
   updateTaskState: (
     taskId: string,
     updates: Partial<TaskExecutionState>,
@@ -140,6 +141,7 @@ interface TaskExecutionStore {
 
   // Auto-initialization and artifact processing
   initializeRepoPath: (taskId: string, task: Task) => void;
+  revalidateRepo: (taskId: string) => Promise<void>;
   processLogsForArtifacts: (taskId: string) => void;
   checkPlanCompletion: (taskId: string) => Promise<void>;
 }
@@ -148,6 +150,7 @@ const defaultTaskState: TaskExecutionState = {
   isRunning: false,
   logs: [],
   repoPath: null,
+  repoExists: null,
   currentTaskId: null,
   runMode: "local",
   unsubscribe: null,
@@ -166,8 +169,11 @@ export const useTaskExecutionStore = create<TaskExecutionStore>()(
     (set, get) => ({
       taskStates: {},
 
-      getTaskState: (taskId: string) => {
+      getTaskState: (taskId: string, task?: Task) => {
         const state = get();
+        if (task) {
+          state.initializeRepoPath(taskId, task);
+        }
         return state.taskStates[taskId] || { ...defaultTaskState };
       },
 
@@ -582,6 +588,32 @@ export const useTaskExecutionStore = create<TaskExecutionStore>()(
           task.repository_config.repository,
         );
         store.setRepoPath(taskId, path);
+
+        // Validate repo exists
+        window.electronAPI
+          ?.validateRepo(path)
+          .then((exists) => {
+            store.updateTaskState(taskId, { repoExists: exists });
+          })
+          .catch(() => {
+            store.updateTaskState(taskId, { repoExists: false });
+          });
+      },
+
+      revalidateRepo: async (taskId: string) => {
+        const store = get();
+        const taskState = store.getTaskState(taskId);
+
+        if (!taskState.repoPath) return;
+
+        try {
+          const exists = await window.electronAPI?.validateRepo(
+            taskState.repoPath,
+          );
+          store.updateTaskState(taskId, { repoExists: exists });
+        } catch {
+          store.updateTaskState(taskId, { repoExists: false });
+        }
       },
 
       processLogsForArtifacts: (taskId: string) => {
diff --git a/src/renderer/stores/cloneStore.ts b/src/renderer/stores/cloneStore.ts
@@ -1,3 +1,4 @@
+import { useTaskExecutionStore } from "@features/tasks/stores/taskExecutionStore";
 import type { RepositoryConfig } from "@shared/types";
 import { toast } from "@utils/toast";
 import { create } from "zustand";
@@ -35,12 +36,30 @@ const getRepoKey = (repo: RepositoryConfig) =>
   `${repo.organization}/${repo.repository}`;
 
 export const cloneStore = create<CloneStore>((set, get) => {
+  const updateTaskRepoExists = (targetPath: string, exists: boolean) => {
+    const taskStore = useTaskExecutionStore.getState();
+    Object.keys(taskStore.taskStates).forEach((taskId) => {
+      const taskState = taskStore.taskStates[taskId];
+      if (taskState?.repoPath === targetPath) {
+        taskStore.updateTaskState(taskId, { repoExists: exists });
+      }
+
+      taskStore.revalidateRepo(taskId);
+    });
+  };
+
   const handleComplete = (
     cloneId: string,
     repoKey: string,
     toastId: string | number,
   ) => {
     toast.success(`${repoKey} cloned successfully`, { id: toastId });
+
+    const operation = get().operations[cloneId];
+    if (operation) {
+      updateTaskRepoExists(operation.targetPath, true);
+    }
+
     window.setTimeout(
       () => get().removeClone(cloneId),
       REMOVE_DELAY_SUCCESS_MS,
@@ -57,6 +76,12 @@ export const cloneStore = create<CloneStore>((set, get) => {
       id: toastId,
       description: message,
     });
+
+    const operation = get().operations[cloneId];
+    if (operation) {
+      updateTaskRepoExists(operation.targetPath, false);
+    }
+
     window.setTimeout(() => get().removeClone(cloneId), REMOVE_DELAY_ERROR_MS);
   };
 
