refactor: move updates service to trprc, type emitted :events (#282)

Author: jonathanlab

apps/array/src/main/di/container.ts

@@ -9,6 +9,7 @@ import { FsService } from "../services/fs/service.js";
 import { GitService } from "../services/git/service.js";
 import { OAuthService } from "../services/oauth/service.js";
 import { ShellService } from "../services/shell/service.js";
+import { UpdatesService } from "../services/updates/service.js";
 import { MAIN_TOKENS } from "./tokens.js";
 
 export const container = new Container({
@@ -24,3 +25,4 @@ container.bind(MAIN_TOKENS.FsService).to(FsService);
 container.bind(MAIN_TOKENS.GitService).to(GitService);
 container.bind(MAIN_TOKENS.OAuthService).to(OAuthService);
 container.bind(MAIN_TOKENS.ShellService).to(ShellService);
+container.bind(MAIN_TOKENS.UpdatesService).to(UpdatesService);

apps/array/src/main/di/tokens.ts

@@ -15,4 +15,5 @@ export const MAIN_TOKENS = Object.freeze({
   GitService: Symbol.for("Main.GitService"),
   OAuthService: Symbol.for("Main.OAuthService"),
   ShellService: Symbol.for("Main.ShellService"),
+  UpdatesService: Symbol.for("Main.UpdatesService"),
 });

apps/array/src/main/index.ts

@@ -41,7 +41,7 @@ import {
   shutdownPostHog,
   trackAppEvent,
 } from "./services/posthog-analytics.js";
-import { registerAutoUpdater } from "./services/updates.js";
+import type { UpdatesService } from "./services/updates/service.js";
 import { registerWorkspaceIpc } from "./services/workspace/index.js";
 
 const __filename = fileURLToPath(import.meta.url);
@@ -152,12 +152,19 @@ function createWindow(): void {
           },
         },
         { type: "separator" },
-        {
-          label: "Check for Updates...",
-          click: () => {
-            mainWindow?.webContents.send("check-for-updates-menu");
-          },
-        },
+        ...(app.isPackaged
+          ? [
+              {
+                label: "Check for Updates...",
+                click: () => {
+                  const updatesService = container.get<UpdatesService>(
+                    MAIN_TOKENS.UpdatesService,
+                  );
+                  updatesService.triggerMenuCheck();
+                },
+              },
+            ]
+          : []),
         { type: "separator" },
         {
           label: "Settings...",
@@ -249,8 +256,9 @@ app.whenReady().then(() => {
   createWindow();
   ensureClaudeConfigDir();
 
-  // Initialize dock badge service for notification badges
+  // Initialize services that need early startup
   container.get<DockBadgeService>(MAIN_TOKENS.DockBadgeService);
+  container.get<UpdatesService>(MAIN_TOKENS.UpdatesService);
 
   // Initialize PostHog analytics
   initializePostHog();
@@ -284,9 +292,6 @@ app.on("activate", () => {
   }
 });
 
-// Background services
-registerAutoUpdater(() => mainWindow);
-
 ipcMain.handle("app:get-version", () => app.getVersion());
 
 // Register IPC handlers via services

apps/array/src/main/preload.ts

@@ -167,22 +167,6 @@ contextBridge.exposeInMainWorld("electronAPI", {
   onClearStorage: (listener: () => void): (() => void) =>
     createVoidIpcListener("clear-storage", listener),
   getAppVersion: (): Promise<string> => ipcRenderer.invoke("app:get-version"),
-  onUpdateReady: (listener: () => void): (() => void) =>
-    createVoidIpcListener("updates:ready", listener),
-  installUpdate: (): Promise<{ installed: boolean }> =>
-    ipcRenderer.invoke("updates:install"),
-  checkForUpdates: (): Promise<{
-    success: boolean;
-    error?: string;
-  }> => ipcRenderer.invoke("updates:check"),
-  onUpdateStatus: (
-    listener: IpcEventListener<{
-      checking?: boolean;
-      upToDate?: boolean;
-    }>,
-  ): (() => void) => createIpcListener("updates:status", listener),
-  onCheckForUpdatesMenu: (listener: () => void): (() => void) =>
-    createVoidIpcListener("check-for-updates-menu", listener),
   // Workspace API
   workspace: {
     create: (options: CreateWorkspaceOptions): Promise<WorkspaceInfo> =>

apps/array/src/main/services/file-watcher/schemas.ts

@@ -27,9 +27,28 @@ export const FileWatcherEvent = {
   GitStateChanged: "git-state-changed",
 } as const;
 
+export type DirectoryChangedPayload = {
+  repoPath: string;
+  dirPath: string;
+};
+
+export type FileChangedPayload = {
+  repoPath: string;
+  filePath: string;
+};
+
+export type FileDeletedPayload = {
+  repoPath: string;
+  filePath: string;
+};
+
+export type GitStateChangedPayload = {
+  repoPath: string;
+};
+
 export interface FileWatcherEvents {
-  [FileWatcherEvent.DirectoryChanged]: { repoPath: string; dirPath: string };
-  [FileWatcherEvent.FileChanged]: { repoPath: string; filePath: string };
-  [FileWatcherEvent.FileDeleted]: { repoPath: string; filePath: string };
-  [FileWatcherEvent.GitStateChanged]: { repoPath: string };
+  [FileWatcherEvent.DirectoryChanged]: DirectoryChangedPayload;
+  [FileWatcherEvent.FileChanged]: FileChangedPayload;
+  [FileWatcherEvent.FileDeleted]: FileDeletedPayload;
+  [FileWatcherEvent.GitStateChanged]: GitStateChangedPayload;
 }

apps/array/src/main/services/index.ts

@@ -8,4 +8,3 @@ import "./posthog-analytics.js";
 import "./session-manager.js";
 import "./settingsStore.js";
 import "./transcription-prompts.js";
-import "./updates.js";

apps/array/src/main/services/shell/schemas.ts

@@ -41,7 +41,17 @@ export const ShellEvent = {
   Exit: "exit",
 } as const;
 
+export type ShellDataPayload = {
+  sessionId: string;
+  data: string;
+};
+
+export type ShellExitPayload = {
+  sessionId: string;
+  exitCode: number;
+};
+
 export interface ShellEvents {
-  [ShellEvent.Data]: { sessionId: string; data: string };
-  [ShellEvent.Exit]: { sessionId: string; exitCode: number };
+  [ShellEvent.Data]: ShellDataPayload;
+  [ShellEvent.Exit]: ShellExitPayload;
 }

apps/array/src/main/services/updates.ts

@@ -0,0 +1,37 @@
+import { z } from "zod";
+
+export const isEnabledOutput = z.object({
+  enabled: z.boolean(),
+});
+
+export const checkForUpdatesOutput = z.object({
+  success: z.boolean(),
+  error: z.string().optional(),
+});
+
+export const installUpdateOutput = z.object({
+  installed: z.boolean(),
+});
+
+export type IsEnabledOutput = z.infer<typeof isEnabledOutput>;
+
+export type CheckForUpdatesOutput = z.infer<typeof checkForUpdatesOutput>;
+export type InstallUpdateOutput = z.infer<typeof installUpdateOutput>;
+
+export const UpdatesEvent = {
+  Ready: "ready",
+  Status: "status",
+  CheckFromMenu: "check-from-menu",
+} as const;
+
+export type UpdatesStatusPayload = {
+  checking: boolean;
+  upToDate?: boolean;
+  version?: string;
+};
+
+export interface UpdatesEvents {
+  [UpdatesEvent.Ready]: undefined;
+  [UpdatesEvent.Status]: UpdatesStatusPayload;
+  [UpdatesEvent.CheckFromMenu]: undefined;
+}