refactor: replace track* functions with generic typed track function

Author: jonathanlab

pnpm-lock.yaml

@@ -9,14 +9,15 @@ import { TaskDetail } from "@features/tasks/components/TaskDetail";
 import { TaskList } from "@features/tasks/components/TaskList";
 import { useIntegrations } from "@hooks/useIntegrations";
 import { Box, Flex } from "@radix-ui/themes";
-import { trackTaskView } from "@renderer/lib/analytics";
+import { track } from "@renderer/lib/analytics";
 import type { Task } from "@shared/types";
 import { useLayoutStore } from "@stores/layoutStore";
 import { useTabStore } from "@stores/tabStore";
 import { useCallback, useEffect, useState } from "react";
 import { useHotkeys } from "react-hotkeys-hook";
 import { Toaster } from "sonner";
 import { NotetakerView } from "@/renderer/features/notetaker/components/NotetakerView";
+import { ANALYTICS_EVENTS } from "@/types/analytics";
 
 export function MainLayout() {
   const { activeTabId, tabs, createTab, setActiveTab, closeTab } =
@@ -98,7 +99,7 @@ export function MainLayout() {
       });
 
       // Track task view
-      trackTaskView({
+      track(ANALYTICS_EVENTS.TASK_VIEWED, {
         task_id: task.id,
         has_repository: !!task.repository_config,
       });

src/renderer/components/MainLayout.tsx

@@ -1,10 +1,5 @@
 import { PostHogAPIClient } from "@api/posthogClient";
-import {
-  identifyUser,
-  resetUser,
-  trackUserLoggedIn,
-  trackUserLoggedOut,
-} from "@renderer/lib/analytics";
+import { identifyUser, resetUser, track } from "@renderer/lib/analytics";
 import { queryClient } from "@renderer/lib/queryClient";
 import { useTabStore } from "@renderer/stores/tabStore";
 import type { CloudRegion } from "@shared/types/oauth";
@@ -14,6 +9,7 @@ import {
   getCloudUrlFromRegion,
   TOKEN_REFRESH_BUFFER_MS,
 } from "@/constants/oauth";
+import { ANALYTICS_EVENTS } from "@/types/analytics";
 
 const RECALL_API_URL = "https://us-west-2.recall.ai";
 
@@ -137,7 +133,7 @@ export const useAuthStore = create<AuthState>()(
             project_id: projectId.toString(),
             region,
           });
-          trackUserLoggedIn({
+          track(ANALYTICS_EVENTS.USER_LOGGED_IN, {
             project_id: projectId.toString(),
             region,
           });
@@ -389,7 +385,7 @@ export const useAuthStore = create<AuthState>()(
       },
       logout: () => {
         // Track logout before clearing state
-        trackUserLoggedOut();
+        track(ANALYTICS_EVENTS.USER_LOGGED_OUT);
         resetUser();
 
         if (refreshTimeoutId) {

src/renderer/features/auth/stores/authStore.ts

@@ -3,11 +3,12 @@ import { GitBranch as GitBranchIcon } from "@phosphor-icons/react";
 import { ChevronDownIcon } from "@radix-ui/react-icons";
 import { Box, Button, Flex, Popover, Text, TextField } from "@radix-ui/themes";
 import { useRepositoryIntegration } from "@renderer/hooks/useIntegrations";
-import { trackRepositorySelect } from "@renderer/lib/analytics";
+import { track } from "@renderer/lib/analytics";
 import type { RepositoryConfig } from "@shared/types";
 import { cloneStore } from "@stores/cloneStore";
 import { useMemo, useRef, useState } from "react";
 import { useHotkeys } from "react-hotkeys-hook";
+import { ANALYTICS_EVENTS } from "@/types/analytics";
 
 interface RepositoryPickerProps {
   value: RepositoryConfig | null;
@@ -93,7 +94,7 @@ export function RepositoryPicker({
     setOpen(false);
 
     // Track repository selection
-    trackRepositorySelect({
+    track(ANALYTICS_EVENTS.REPOSITORY_SELECTED, {
       repository_provider: "github", // Currently only GitHub is supported
       source: "task-creation",
     });

src/renderer/features/repository-picker/components/RepositoryPicker.tsx

@@ -1,9 +1,10 @@
 import { useTaskExecutionStore } from "@features/tasks/stores/taskExecutionStore";
 import { useAuthenticatedMutation } from "@hooks/useAuthenticatedMutation";
 import { useAuthenticatedQuery } from "@hooks/useAuthenticatedQuery";
-import { trackTaskCreate } from "@renderer/lib/analytics";
+import { track } from "@renderer/lib/analytics";
 import type { Task } from "@shared/types";
 import { useQueryClient } from "@tanstack/react-query";
+import { ANALYTICS_EVENTS } from "@/types/analytics";
 
 const taskKeys = {
   all: ["tasks"] as const,
@@ -53,7 +54,7 @@ export function useCreateTask() {
         queryClient.invalidateQueries({ queryKey: taskKeys.lists() });
 
         // Track task creation
-        trackTaskCreate({
+        track(ANALYTICS_EVENTS.TASK_CREATED, {
           has_repository: !!variables.repositoryConfig,
           auto_run: variables.autoRun || false,
           created_from: variables.createdFrom || "cli",

src/renderer/features/tasks/hooks/useTasks.ts

@@ -1,7 +1,7 @@
 import { useAuthStore } from "@features/auth/stores/authStore";
 import { useSettingsStore } from "@features/settings/stores/settingsStore";
 import type { AgentEvent } from "@posthog/agent";
-import { trackTaskRun } from "@renderer/lib/analytics";
+import { track } from "@renderer/lib/analytics";
 import type {
   ClarifyingQuestion,
   ExecutionMode,
@@ -19,6 +19,7 @@ import type {
   ExecutionMode as AnalyticsExecutionMode,
   ExecutionType,
 } from "@/types/analytics";
+import { ANALYTICS_EVENTS } from "@/types/analytics";
 
 interface ArtifactEvent {
   type: string;
@@ -379,7 +380,7 @@ export const useTaskExecutionStore = create<TaskExecutionStore>()(
           currentTaskState.executionMode;
         const hasRepository = !!task.repository_config;
 
-        trackTaskRun({
+        track(ANALYTICS_EVENTS.TASK_RUN, {
           task_id: taskId,
           execution_type: executionType,
           execution_mode: executionMode,

src/renderer/features/tasks/stores/taskExecutionStore.ts

@@ -1,12 +1,7 @@
 import posthog from "posthog-js/dist/module.full.no-external";
-import {
-  ANALYTICS_EVENTS,
-  type RepositorySelectProperties,
-  type TaskCreateProperties,
-  type TaskListViewProperties,
-  type TaskRunProperties,
-  type TaskViewProperties,
-  type UserIdentifyProperties,
+import type {
+  EventPropertyMap,
+  UserIdentifyProperties,
 } from "../../types/analytics";
 
 let isInitialized = false;
@@ -47,44 +42,14 @@ export function resetUser() {
   posthog.reset();
 }
 
-export function trackTaskListView(properties?: TaskListViewProperties) {
-  if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.TASK_LIST_VIEWED, properties);
-}
-
-export function trackTaskCreate(properties: TaskCreateProperties) {
-  if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.TASK_CREATED, properties);
-}
-
-export function trackTaskView(properties: TaskViewProperties) {
-  if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.TASK_VIEWED, properties);
-}
-
-export function trackTaskRun(properties: TaskRunProperties) {
-  if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.TASK_RUN, properties);
-}
-
-export function trackRepositorySelect(properties: RepositorySelectProperties) {
-  if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.REPOSITORY_SELECTED, properties);
-}
-
-export function trackUserLoggedIn(properties?: UserIdentifyProperties) {
-  if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.USER_LOGGED_IN, properties);
-}
-
-export function trackUserLoggedOut() {
+export function track<K extends keyof EventPropertyMap>(
+  eventName: K,
+  ...args: EventPropertyMap[K] extends never
+    ? []
+    : EventPropertyMap[K] extends undefined
+      ? [properties?: EventPropertyMap[K]]
+      : [properties: EventPropertyMap[K]]
+) {
   if (!isInitialized) return;
-
-  posthog.capture(ANALYTICS_EVENTS.USER_LOGGED_OUT);
+  posthog.capture(eventName, args[0]);
 }

src/renderer/lib/analytics.ts

@@ -65,3 +65,14 @@ export const ANALYTICS_EVENTS = {
 
 export type AnalyticsEvent =
   (typeof ANALYTICS_EVENTS)[keyof typeof ANALYTICS_EVENTS];
+
+// Event property mapping
+export type EventPropertyMap = {
+  [ANALYTICS_EVENTS.TASK_LIST_VIEWED]: TaskListViewProperties | undefined;
+  [ANALYTICS_EVENTS.TASK_CREATED]: TaskCreateProperties;
+  [ANALYTICS_EVENTS.TASK_VIEWED]: TaskViewProperties;
+  [ANALYTICS_EVENTS.TASK_RUN]: TaskRunProperties;
+  [ANALYTICS_EVENTS.REPOSITORY_SELECTED]: RepositorySelectProperties;
+  [ANALYTICS_EVENTS.USER_LOGGED_IN]: UserIdentifyProperties | undefined;
+  [ANALYTICS_EVENTS.USER_LOGGED_OUT]: never;
+};