address my own pr comments

Author: jonathanlab

apps/array/src/api/posthogClient.ts …/array/src/renderer/api/posthogClient.tsapps/array/src/api/posthogClient.ts renamed to apps/array/src/renderer/api/posthogClient.ts apps/array/src/api/posthogClient.ts renamed to apps/array/src/renderer/api/posthogClient.ts

@@ -1,9 +1,9 @@
+import { buildApiFetcher } from "@api/fetcher";
+import { createApiClient, type Schemas } from "@api/generated";
 import type { AgentEvent } from "@posthog/agent";
 import { logger } from "@renderer/lib/logger";
 import type { Task, TaskRun } from "@shared/types";
 import type { StoredLogEntry } from "@shared/types/session-events";
-import { buildApiFetcher } from "./fetcher";
-import { createApiClient, type Schemas } from "./generated";
 
 const log = logger.scope("posthog-client");
 

apps/array/src/renderer/components/ErrorBoundary.tsx

@@ -1,6 +1,5 @@
 import { Button, Card, Flex, Text } from "@radix-ui/themes";
 import { logger } from "@renderer/lib/logger";
-import { toast } from "@utils/toast";
 import type { ReactNode } from "react";
 import { ErrorBoundary as ReactErrorBoundary } from "react-error-boundary";
 
@@ -9,7 +8,13 @@ interface Props {
   fallback?: ReactNode;
 }
 
-function DefaultFallback({ onReset }: { onReset: () => void }) {
+function DefaultFallback({
+  error,
+  onReset,
+}: {
+  error: Error;
+  onReset: () => void;
+}) {
   return (
     <Flex align="center" justify="center" minHeight="100vh" p="4">
       <Card size="3" style={{ maxWidth: 400 }}>
@@ -18,7 +23,7 @@ function DefaultFallback({ onReset }: { onReset: () => void }) {
             Something went wrong
           </Text>
           <Text size="2" color="gray" align="center">
-            An unexpected error occurred. Please try again.
+            {error.message}
           </Text>
           <Button onClick={onReset} variant="soft">
             Try again
@@ -32,16 +37,17 @@ function DefaultFallback({ onReset }: { onReset: () => void }) {
 export function ErrorBoundary({ children, fallback }: Props) {
   return (
     <ReactErrorBoundary
-      fallbackRender={({ resetErrorBoundary }) =>
-        fallback ?? <DefaultFallback onReset={resetErrorBoundary} />
+      fallbackRender={({ error, resetErrorBoundary }) =>
+        fallback ?? (
+          <DefaultFallback error={error} onReset={resetErrorBoundary} />
+        )
       }
       onError={(error, info) => {
         logger.error("React error boundary caught error", {
           error: error.message,
           stack: error.stack,
           componentStack: info.componentStack,
         });
-        toast.error("Something went wrong", { description: error.message });
       }}
     >
       {children}

apps/array/src/renderer/features/auth/stores/authStore.ts

@@ -1,4 +1,4 @@
-import { PostHogAPIClient } from "@api/posthogClient";
+import { PostHogAPIClient } from "@renderer/api/posthogClient";
 import { identifyUser, resetUser, track } from "@renderer/lib/analytics";
 import { electronStorage } from "@renderer/lib/electronStorage";
 import { logger } from "@renderer/lib/logger";

apps/array/src/renderer/hooks/useAuthenticatedMutation.ts

@@ -1,5 +1,5 @@
-import type { PostHogAPIClient } from "@api/posthogClient";
 import { useAuthStore } from "@features/auth/stores/authStore";
+import type { PostHogAPIClient } from "@renderer/api/posthogClient";
 import type {
   UseMutationOptions,
   UseMutationResult,

apps/array/src/renderer/hooks/useAuthenticatedQuery.ts

@@ -1,5 +1,5 @@
-import type { PostHogAPIClient } from "@api/posthogClient";
 import { useAuthStore } from "@features/auth/stores/authStore";
+import type { PostHogAPIClient } from "@renderer/api/posthogClient";
 import type {
   QueryKey,
   UseQueryOptions,

apps/array/src/renderer/lib/error-handling.ts

@@ -1,10 +1,10 @@
 import { formatArgsToString } from "@shared/utils/format";
 import { toast } from "@utils/toast";
+import { IS_DEV } from "@/constants/environment";
 import { logger } from "./logger";
 
-const isDev = import.meta.env.DEV;
 const devErrorToastsEnabled =
-  isDev && import.meta.env.VITE_DEV_ERROR_TOASTS !== "false";
+  IS_DEV && import.meta.env.VITE_DEV_ERROR_TOASTS !== "false";
 
 export function initializeRendererErrorHandling(): void {
   if (devErrorToastsEnabled) {

apps/array/src/renderer/lib/logger.ts

@@ -2,12 +2,12 @@ import type { Logger, ScopedLogger } from "@shared/lib/create-logger";
 import { createLogger } from "@shared/lib/create-logger";
 import { toast } from "@utils/toast";
 import log from "electron-log/renderer";
+import { IS_DEV } from "@/constants/environment";
 
 log.transports.console.level = "debug";
 
-const isDev = import.meta.env.DEV;
 const devErrorToastsEnabled =
-  isDev && import.meta.env.VITE_DEV_ERROR_TOASTS !== "false";
+  IS_DEV && import.meta.env.VITE_DEV_ERROR_TOASTS !== "false";
 
 const emitToast = devErrorToastsEnabled
   ? (title: string, description?: string) => toast.error(title, { description })

apps/array/src/renderer/sagas/task/task-creation.ts

@@ -1,7 +1,7 @@
-import type { PostHogAPIClient } from "@api/posthogClient";
 import { buildPromptBlocks } from "@features/editor/utils/prompt-builder";
 import { getSessionActions } from "@features/sessions/stores/sessionStore";
 import { useWorkspaceStore } from "@features/workspace/stores/workspaceStore";
+import type { PostHogAPIClient } from "@renderer/api/posthogClient";
 import { logger } from "@renderer/lib/logger";
 import { useTaskDirectoryStore } from "@renderer/stores/taskDirectoryStore";
 import { trpcVanilla } from "@renderer/trpc";

apps/array/tsconfig.node.json

@@ -12,8 +12,7 @@
   },
   "exclude": [
     "src/renderer/**/*",
-    "src/main/preload.ts",
-    "src/api/posthogClient.ts"
+    "src/main/preload.ts"
   ],
   "extends": "./tsconfig.json",
   "include": ["src/main/**/*", "src/shared/**/*", "src/api/**/*"]