refactor: remove noise comments and move SDK init to auth store

1. Remove redundant comments from recallRecording.ts that just
   restate what the code already says clearly
2. Move Recall SDK initialization from React useEffect to zustand
   auth store, where it naturally belongs alongside credential
   management. SDK now initializes automatically when credentials
   are set or retrieved, without React lifecycle coupling.

Author: lucasheriques

src/main/services/recallRecording.ts

@@ -12,9 +12,6 @@ const activeSessions = new Map<string, RecordingSession>();
 let posthogClient: PostHogAPIClient | null = null;
 let sdkInitialized = false;
 
-/**
- * Check if Recall SDK has already been initialized
- */
 export function isRecallSDKInitialized(): boolean {
   return sdkInitialized;
 }
@@ -24,17 +21,14 @@ export function initializeRecallSDK(
   posthogKey: string,
   posthogHost: string,
 ) {
-  // Guard: Prevent multiple initializations
   if (sdkInitialized) {
     return;
   }
 
   console.log("[Recall SDK] Initializing...");
 
-  // Create PostHog API client for making API calls
   posthogClient = new PostHogAPIClient(posthogKey, posthogHost);
 
-  // Initialize Recall SDK
   RecallAiSdk.init({
     apiUrl: recallApiUrl,
     acquirePermissionsOnStartup: [
@@ -45,7 +39,6 @@ export function initializeRecallSDK(
     restartOnError: true,
   });
 
-  // Mark as initialized
   sdkInitialized = true;
 
   console.log("[Recall SDK] Ready. Listening for meetings...");
@@ -72,17 +65,14 @@ export function initializeRecallSDK(
         throw new Error("PostHog client not initialized");
       }
 
-      // Create upload token via PostHog API
       const { upload_token, recording_id } =
         await posthogClient.createDesktopRecordingUpload(platform);
 
-      // Start recording with Recall SDK
       await RecallAiSdk.startRecording({
         windowId: evt.window.id,
         uploadToken: upload_token,
       });
 
-      // Store session info
       activeSessions.set(evt.window.id, {
         windowId: evt.window.id,
         recordingId: recording_id,
@@ -97,21 +87,15 @@ export function initializeRecallSDK(
 
   RecallAiSdk.addEventListener("sdk-state-change", async (evt) => {
     const state = evt.sdk.state.code;
-    // Only log non-recording states for debugging
     if (state !== "recording") {
       console.log(`[Recall SDK] State: ${state}`);
     }
   });
 
-  RecallAiSdk.addEventListener("recording-started", async (_evt) => {
-    // Handled by meeting-detected event
-  });
-
   RecallAiSdk.addEventListener("recording-ended", async (evt) => {
     try {
       console.log("[Recall SDK] Recording ended, uploading...");
 
-      // Upload the recording
       await RecallAiSdk.uploadRecording({
         windowId: evt.window.id,
       });
@@ -124,25 +108,18 @@ export function initializeRecallSDK(
     if (evt.progress === 100) {
       console.log("[Recall SDK] Upload complete");
     }
-    // TODO: Send progress to renderer for UI updates
   });
 
   RecallAiSdk.addEventListener("meeting-closed", async (evt) => {
     console.log("[Recall SDK] Meeting closed");
     activeSessions.delete(evt.window.id);
   });
 
-  RecallAiSdk.addEventListener("meeting-updated", async (_evt) => {
-    // Metadata updates are too frequent to log
-  });
+  RecallAiSdk.addEventListener("meeting-updated", async (_evt) => {});
 
-  RecallAiSdk.addEventListener("media-capture-status", async (_evt) => {
-    // Capture status changes are too frequent to log
-  });
+  RecallAiSdk.addEventListener("media-capture-status", async (_evt) => {});
 
-  RecallAiSdk.addEventListener("realtime-event", async (_evt) => {
-    // TODO: Handle real-time transcript segments (Phase 2)
-  });
+  RecallAiSdk.addEventListener("realtime-event", async (_evt) => {});
 
   RecallAiSdk.addEventListener("error", async (evt) => {
     console.error(
@@ -160,9 +137,6 @@ export function initializeRecallSDK(
   });
 }
 
-/**
- * Detect meeting platform from window metadata
- */
 function detectPlatform(window: { url?: string; title?: string }): string {
   const url = window.url?.toLowerCase() || "";
   const title = window.title?.toLowerCase() || "";
@@ -186,32 +160,20 @@ function detectPlatform(window: { url?: string; title?: string }): string {
   return "desktop_audio";
 }
 
-/**
- * Request a specific permission
- */
 export function requestRecallPermission(
   permission: "accessibility" | "screen-capture" | "microphone",
 ) {
   RecallAiSdk.requestPermission(permission);
 }
 
-/**
- * Shutdown the Recall SDK
- */
 export function shutdownRecallSDK() {
   RecallAiSdk.shutdown();
 }
 
-/**
- * Get active recording sessions
- */
 export function getActiveSessions() {
   return Array.from(activeSessions.values());
 }
 
-/**
- * Register IPC handlers for Recall SDK
- */
 export function registerRecallIPCHandlers() {
   ipcMain.handle(
     "recall:initialize",

src/renderer/App.tsx

@@ -4,27 +4,14 @@ import { AuthScreen } from "./components/AuthScreen";
 import { MainLayout } from "./components/MainLayout";
 import { useAuthStore } from "./stores/authStore";
 
-const RECALL_API_URL = "https://us-west-2.recall.ai";
-
 function App() {
-  const { isAuthenticated, checkAuth, apiKey, apiHost } = useAuthStore();
+  const { isAuthenticated, checkAuth } = useAuthStore();
   const [isLoading, setIsLoading] = useState(true);
 
   useEffect(() => {
     checkAuth().finally(() => setIsLoading(false));
   }, [checkAuth]);
 
-  // Initialize Recall SDK when authenticated (main process prevents duplicate inits)
-  useEffect(() => {
-    if (isAuthenticated && apiKey && apiHost) {
-      window.electronAPI
-        .recallInitialize(RECALL_API_URL, apiKey, apiHost)
-        .catch((error) => {
-          console.error("[App] Failed to initialize Recall SDK:", error);
-        });
-    }
-  }, [isAuthenticated, apiKey, apiHost]);
-
   if (isLoading) {
     return (
       <Flex align="center" justify="center" minHeight="100vh">

src/renderer/stores/authStore.ts

@@ -2,6 +2,8 @@ import { PostHogAPIClient } from "@api/posthogClient";
 import { create } from "zustand";
 import { persist } from "zustand/middleware";
 
+const RECALL_API_URL = "https://us-west-2.recall.ai";
+
 interface AuthState {
   apiKey: string | null;
   apiHost: string;
@@ -43,6 +45,12 @@ export const useAuthStore = create<AuthState>()(
             isAuthenticated: true,
             client,
           });
+
+          window.electronAPI
+            .recallInitialize(RECALL_API_URL, apiKey, apiHost)
+            .catch((error) => {
+              console.error("[Auth] Failed to initialize Recall SDK:", error);
+            });
         } catch (_error) {
           throw new Error("Invalid API key or host");
         }
@@ -75,6 +83,15 @@ export const useAuthStore = create<AuthState>()(
                 isAuthenticated: true,
                 client,
               });
+
+              window.electronAPI
+                .recallInitialize(RECALL_API_URL, decryptedKey, state.apiHost)
+                .catch((error) => {
+                  console.error(
+                    "[Auth] Failed to initialize Recall SDK:",
+                    error,
+                  );
+                });
             } catch {
               set({ encryptedKey: null, isAuthenticated: false });
             }