fix: it works! somehow

Author: k11kirky

apps/array/forge.config.ts

@@ -127,7 +127,8 @@ function copySync(dependency: string, destinationRoot: string, source: string) {
 const config: ForgeConfig = {
   packagerConfig: {
     asar: {
-      unpack: "{**/*.node,**/spawn-helper,**/.vite/build/claude-cli/**}",
+      unpack:
+        "{**/*.node,**/spawn-helper,**/.vite/build/claude-cli/**,**/node_modules/node-pty/**}",
     },
     prune: false,
     name: "Array",

apps/array/src/main/services/agent.ts

@@ -1,5 +1,6 @@
 import { randomUUID } from "node:crypto";
-import { rmSync } from "node:fs";
+import { mkdirSync, rmSync, symlinkSync } from "node:fs";
+import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { Agent, PermissionMode } from "@posthog/agent";
 import {
@@ -128,6 +129,15 @@ export function registerAgentIpc(
           ts: Date.now(),
           message: `[Claude stderr] ${text}`,
         });
+
+        // Propagate spawn errors specifically to help debugging
+        if (text.includes("spawn") && text.includes("ENOENT")) {
+          emitToRenderer({
+            type: "error",
+            ts: Date.now(),
+            message: `Critical Agent Error: ${text}`,
+          });
+        }
       };
 
       const agent = new Agent({
@@ -191,14 +201,35 @@ export function registerAgentIpc(
       (async () => {
         const resolvedPermission = resolvePermissionMode(permissionMode);
         try {
+          // Create a temporary directory to mock 'node' in PATH
+          // Electron apps don't have 'node' in PATH, and process.execPath points to the App binary
+          // We symlink 'node' -> process.execPath and add this dir to PATH
+          const mockNodeDir = join(tmpdir(), `array-agent-node-${taskId}`);
+          try {
+            mkdirSync(mockNodeDir, { recursive: true });
+            const nodeSymlinkPath = join(mockNodeDir, "node");
+            // Remove existing symlink if it exists
+            try {
+              rmSync(nodeSymlinkPath, { force: true });
+            } catch {}
+            symlinkSync(process.execPath, nodeSymlinkPath);
+          } catch (err) {
+            console.warn("[agent] Failed to setup mock node environment", err);
+          }
+
+          const newPath = `${mockNodeDir}:${process.env.PATH || ""}`;
+
           const envOverrides = {
             ...process.env,
+            PATH: newPath,
             POSTHOG_API_KEY: apiKey,
             POSTHOG_API_HOST: apiHost,
             POSTHOG_AUTH_HEADER: `Bearer ${apiKey}`,
             ANTHROPIC_API_KEY: apiKey,
             ANTHROPIC_AUTH_TOKEN: apiKey,
             ANTHROPIC_BASE_URL: `${apiHost}/api/projects/${projectId}/llm_gateway`,
+            // Ensure we can run node in the packaged app
+            ELECTRON_RUN_AS_NODE: "1",
           };
 
           const mcpOverrides = {};
@@ -216,9 +247,16 @@ export function registerAgentIpc(
               env: envOverrides,
               mcpServers: mcpOverrides,
               pathToClaudeCodeExecutable: getClaudeCliPath(),
+              // Still pass this, but the PATH hack above is the real fix
+              nodePath: process.execPath,
             },
           });
 
+          // Clean up mock node dir
+          try {
+            rmSync(mockNodeDir, { recursive: true, force: true });
+          } catch {}
+
           emitToRenderer({ type: "done", success: true, ts: Date.now() });
         } catch (err) {
           console.error("[agent] task execution failed", err);

packages/agent/src/agent.ts

@@ -247,15 +247,20 @@ export class Agent {
     });
 
     const results = [];
-    for await (const message of response) {
-      this.logger.debug("Received message in direct run", message);
-      // Emit raw SDK event
-      this.emitEvent(this.adapter.createRawSDKEvent(message));
-      const transformedEvents = this.adapter.transform(message);
-      for (const event of transformedEvents) {
-        this.emitEvent(event);
+    try {
+      for await (const message of response) {
+        this.logger.debug("Received message in direct run", message);
+        // Emit raw SDK event
+        this.emitEvent(this.adapter.createRawSDKEvent(message));
+        const transformedEvents = this.adapter.transform(message);
+        for (const event of transformedEvents) {
+          this.emitEvent(event);
+        }
+        results.push(message);
       }
-      results.push(message);
+    } catch (error) {
+      this.logger.error("Error during direct run", error);
+      throw error;
     }
 
     return { results };

packages/agent/src/workflow/steps/build.ts

@@ -87,20 +87,25 @@ export const buildStep: WorkflowStepRunner = async ({ step, context }) => {
   // Track todos from TodoWrite tool calls
   const todoManager = new TodoManager(context.fileManager, stepLogger);
 
-  for await (const message of response) {
-    emitEvent(adapter.createRawSDKEvent(message));
-    const transformedEvents = adapter.transform(message);
-    for (const event of transformedEvents) {
-      emitEvent(event);
-    }
-
-    const todoList = await todoManager.checkAndPersistFromMessage(
-      message,
-      task.id,
-    );
-    if (todoList) {
-      emitEvent(adapter.createArtifactEvent("todos", todoList));
+  try {
+    for await (const message of response) {
+      emitEvent(adapter.createRawSDKEvent(message));
+      const transformedEvents = adapter.transform(message);
+      for (const event of transformedEvents) {
+        emitEvent(event);
+      }
+
+      const todoList = await todoManager.checkAndPersistFromMessage(
+        message,
+        task.id,
+      );
+      if (todoList) {
+        emitEvent(adapter.createArtifactEvent("todos", todoList));
+      }
     }
+  } catch (error) {
+    stepLogger.error("Error during build step query", error);
+    throw error;
   }
 
   // Finalize: commit any remaining changes and optionally push

packages/agent/src/workflow/steps/plan.ts

@@ -110,29 +110,34 @@ export const planStep: WorkflowStepRunner = async ({ step, context }) => {
   const todoManager = new TodoManager(fileManager, stepLogger);
 
   let planContent = "";
-  for await (const message of response) {
-    emitEvent(adapter.createRawSDKEvent(message));
-    const transformedEvents = adapter.transform(message);
-    for (const event of transformedEvents) {
-      emitEvent(event);
-    }
+  try {
+    for await (const message of response) {
+      emitEvent(adapter.createRawSDKEvent(message));
+      const transformedEvents = adapter.transform(message);
+      for (const event of transformedEvents) {
+        emitEvent(event);
+      }
 
-    const todoList = await todoManager.checkAndPersistFromMessage(
-      message,
-      task.id,
-    );
-    if (todoList) {
-      emitEvent(adapter.createArtifactEvent("todos", todoList));
-    }
+      const todoList = await todoManager.checkAndPersistFromMessage(
+        message,
+        task.id,
+      );
+      if (todoList) {
+        emitEvent(adapter.createArtifactEvent("todos", todoList));
+      }
 
-    // Extract text content for plan
-    if (message.type === "assistant" && message.message?.content) {
-      for (const block of message.message.content) {
-        if (block.type === "text" && block.text) {
-          planContent += `${block.text}\n`;
+      // Extract text content for plan
+      if (message.type === "assistant" && message.message?.content) {
+        for (const block of message.message.content) {
+          if (block.type === "text" && block.text) {
+            planContent += `${block.text}\n`;
+          }
         }
       }
     }
+  } catch (error) {
+    stepLogger.error("Error during plan step query", error);
+    throw error;
   }
 
   if (planContent.trim()) {

packages/agent/src/workflow/steps/research.ts

@@ -87,19 +87,24 @@ export const researchStep: WorkflowStepRunner = async ({ step, context }) => {
   });
 
   let jsonContent = "";
-  for await (const message of response) {
-    emitEvent(adapter.createRawSDKEvent(message));
-    const transformedEvents = adapter.transform(message);
-    for (const event of transformedEvents) {
-      emitEvent(event);
-    }
-    if (message.type === "assistant" && message.message?.content) {
-      for (const c of message.message.content) {
-        if (c.type === "text" && c.text) {
-          jsonContent += c.text;
+  try {
+    for await (const message of response) {
+      emitEvent(adapter.createRawSDKEvent(message));
+      const transformedEvents = adapter.transform(message);
+      for (const event of transformedEvents) {
+        emitEvent(event);
+      }
+      if (message.type === "assistant" && message.message?.content) {
+        for (const c of message.message.content) {
+          if (c.type === "text" && c.text) {
+            jsonContent += c.text;
+          }
         }
       }
     }
+  } catch (error) {
+    stepLogger.error("Error during research step query", error);
+    throw error;
   }
 
   if (!jsonContent.trim()) {