Skip to content

Commit e976126

Browse files
committed
clean-up
1 parent fd2ca68 commit e976126

File tree

3 files changed

+206
-177
lines changed

3 files changed

+206
-177
lines changed

src/renderer/components/TaskItem.tsx

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ function TaskItemComponent({
4747
const duplicateTask = useTaskStore((state) => state.duplicateTask);
4848
const setSelectedIndex = useTaskStore((state) => state.setSelectedIndex);
4949
const setHoveredIndex = useTaskStore((state) => state.setHoveredIndex);
50-
const setContextMenuIndex = useTaskStore((state) => state.setContextMenuIndex);
50+
const setContextMenuIndex = useTaskStore(
51+
(state) => state.setContextMenuIndex,
52+
);
5153
const selectedIndex = useTaskStore((state) => state.selectedIndex);
5254
const contextMenuIndex = useTaskStore((state) => state.contextMenuIndex);
5355
const createdAt = new Date(task.created_at);
@@ -223,16 +225,33 @@ function TaskItemComponent({
223225
<ContextMenu.Sub>
224226
<ContextMenu.SubTrigger>Move</ContextMenu.SubTrigger>
225227
<ContextMenu.SubContent>
226-
<ContextMenu.Item onSelect={() => onMoveTask(index, 0)} shortcut="⌥ ⇧ ↑">
228+
<ContextMenu.Item
229+
onSelect={() => onMoveTask(index, 0)}
230+
shortcut="⌥ ⇧ ↑"
231+
>
227232
Move to top
228233
</ContextMenu.Item>
229-
<ContextMenu.Item onSelect={() => onMoveTask(index, Math.max(0, index - 1))} shortcut="⌥ ↑">
234+
<ContextMenu.Item
235+
onSelect={() => onMoveTask(index, Math.max(0, index - 1))}
236+
shortcut="⌥ ↑"
237+
>
230238
Move up
231239
</ContextMenu.Item>
232-
<ContextMenu.Item onSelect={() => onMoveTask(index, Math.min(filteredTasksLength - 1, index + 1))} shortcut="⌥ ↓">
240+
<ContextMenu.Item
241+
onSelect={() =>
242+
onMoveTask(
243+
index,
244+
Math.min(filteredTasksLength - 1, index + 1),
245+
)
246+
}
247+
shortcut="⌥ ↓"
248+
>
233249
Move down
234250
</ContextMenu.Item>
235-
<ContextMenu.Item onSelect={() => onMoveTask(index, filteredTasksLength - 1)} shortcut="⌥ ⇧ ↓">
251+
<ContextMenu.Item
252+
onSelect={() => onMoveTask(index, filteredTasksLength - 1)}
253+
shortcut="⌥ ⇧ ↓"
254+
>
236255
Move to bottom
237256
</ContextMenu.Item>
238257
</ContextMenu.SubContent>

src/renderer/components/TaskList.tsx

Lines changed: 17 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,14 @@ export function TaskList({ onSelectTask, onNewTask }: TaskListInternalProps) {
3939
// Move drag state to local state for better performance
4040
const [draggedTaskId, setDraggedTaskIdLocal] = useState<string | null>(null);
4141
const [dragOverIndex, setDragOverIndexLocal] = useState<number | null>(null);
42-
const [dropPosition, setDropPositionLocal] = useState<"top" | "bottom" | null>(null);
42+
const [dropPosition, setDropPositionLocal] = useState<
43+
"top" | "bottom" | null
44+
>(null);
4345

4446
const fetchTasks = useTaskStore((state) => state.fetchTasks);
45-
const deleteTask = useTaskStore((state) => state.deleteTask);
46-
const duplicateTask = useTaskStore((state) => state.duplicateTask);
4747
const moveTask = useTaskStore((state) => state.moveTask);
4848
const setSelectedIndex = useTaskStore((state) => state.setSelectedIndex);
4949
const setHoveredIndex = useTaskStore((state) => state.setHoveredIndex);
50-
const setContextMenuIndex = useTaskStore(
51-
(state) => state.setContextMenuIndex,
52-
);
5350
const setFilter = useTaskStore((state) => state.setFilter);
5451

5552
const { setStatusBar, reset } = useStatusBarStore();
@@ -94,29 +91,23 @@ export function TaskList({ onSelectTask, onNewTask }: TaskListInternalProps) {
9491
[filteredTasks, moveTask],
9592
);
9693

97-
const handleDragStart = useCallback(
98-
(e: React.DragEvent, taskId: string) => {
99-
setDraggedTaskIdLocal(taskId);
100-
e.dataTransfer.effectAllowed = "move";
101-
e.dataTransfer.setData("text/plain", taskId);
102-
},
103-
[],
104-
);
94+
const handleDragStart = useCallback((e: React.DragEvent, taskId: string) => {
95+
setDraggedTaskIdLocal(taskId);
96+
e.dataTransfer.effectAllowed = "move";
97+
e.dataTransfer.setData("text/plain", taskId);
98+
}, []);
10599

106-
const handleDragOver = useCallback(
107-
(e: React.DragEvent, index: number) => {
108-
e.preventDefault();
109-
e.dataTransfer.dropEffect = "move";
100+
const handleDragOver = useCallback((e: React.DragEvent, index: number) => {
101+
e.preventDefault();
102+
e.dataTransfer.dropEffect = "move";
110103

111-
const rect = e.currentTarget.getBoundingClientRect();
112-
const midpoint = rect.top + rect.height / 2;
113-
const mouseY = e.clientY;
104+
const rect = e.currentTarget.getBoundingClientRect();
105+
const midpoint = rect.top + rect.height / 2;
106+
const mouseY = e.clientY;
114107

115-
setDragOverIndexLocal(index);
116-
setDropPositionLocal(mouseY < midpoint ? "top" : "bottom");
117-
},
118-
[],
119-
);
108+
setDragOverIndexLocal(index);
109+
setDropPositionLocal(mouseY < midpoint ? "top" : "bottom");
110+
}, []);
120111

121112
const handleDragLeave = useCallback(() => {
122113
setDragOverIndexLocal(null);
@@ -163,7 +154,6 @@ export function TaskList({ onSelectTask, onNewTask }: TaskListInternalProps) {
163154
setDropPositionLocal(null);
164155
}, []);
165156

166-
167157
useEffect(() => {
168158
setStatusBar({
169159
statusText: `${filteredTasks.length} task${filteredTasks.length === 1 ? "" : "s"}`,

0 commit comments

Comments
 (0)