Skip to content

Commit 60e3180

Browse files
authored
Merge pull request #39 from PostHog/fix/detach-ducklake-on-close
Detach DuckLake on client disconnect to prevent RDS connection leaks
2 parents 53a8ba3 + cb6f05b commit 60e3180

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

server/conn.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,12 @@ func (c *clientConn) serve() error {
8686
c.db = db
8787
defer func() {
8888
if c.db != nil {
89+
// Detach DuckLake to release the RDS metadata connection
90+
if c.server.cfg.DuckLake.MetadataStore != "" {
91+
if _, err := c.db.Exec("DETACH ducklake"); err != nil {
92+
log.Printf("Warning: failed to detach DuckLake for user %q: %v", c.username, err)
93+
}
94+
}
8995
c.db.Close()
9096
}
9197
}()

0 commit comments

Comments
 (0)