feat: implement global concurrent connection limit and set default to CPUs * 2#222
Merged
fuziontech merged 3 commits intomainfrom Feb 17, 2026
Merged
Conversation
The all-or-nothing defaulting logic was silently overwriting the test harness's MaxConnections: 100 because MaxFailedAttempts was zero, causing CI to reject connections on low-CPU runners. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Duckgres limits connections per IP (default 100) and limits workers in control-plane mode based on memory budget.
This PR:
RateLimiter.runtime.NumCPU() * 2.max_workersin control-plane mode toruntime.NumCPU() * 2for consistency.max-connectionsvia CLI flag andDUCKGRES_MAX_CONNECTIONSenvironment variable.