Merge pull request #41 from PostHog/fix-uri-format

Correct URI generation for next steps; introduce resources explicitly

Author: daniloc

llm-prompts/basic-integration/1.1-edit.md

@@ -11,7 +11,7 @@ If a file already has existing integration code for other tools or services, don
 
 For each event, add useful properties, and use your access to the PostHog source code to ensure correctness. You also have access to documentation about creating new events with PostHog. Consider this documentation carefully and follow it closely before adding events. Your integration should be based on documented best practices. Carefully consider how the user project's framework version may impact the correct PostHog integration approach.
 
-Remember that you can find the source code for any dependency in the node_modules directory. This may be necessary to properly populate property names.
+Remember that you can find the source code for any dependency in the node_modules directory. This may be necessary to properly populate property names. There are also example project code files available via the PostHog MCP; use these for reference.
 
 Where possible, add calls for PostHog's identify() function on the client side. On the server side, make sure events have a matching distinct ID where relevant. Use the same ID for identify on the client as you use distinct ID on the server. Logins and signups are a great opportunity to identify users. Use the contents of login and signup forms to identify users on submit.
 

scripts/build-examples-mcp-resources.js

@@ -35,6 +35,25 @@ const MANIFEST_VERSION = '1.0';
 const BUILD_VERSION = process.env.BUILD_VERSION || 'dev';
 const URI_SCHEME = 'posthog://';
 
+/**
+ * URI pattern constants - SINGLE SOURCE OF TRUTH for all URI formats
+ */
+const URI_PATTERNS = {
+    workflow: (category, name) => `${URI_SCHEME}workflows/${category}/${name}`,
+    doc: (id) => `${URI_SCHEME}docs/${id}`,
+    frameworkDocs: `${URI_SCHEME}docs/frameworks/{framework}`,
+    examples: `${URI_SCHEME}examples/{framework}`,
+};
+
+/**
+ * Generate a workflow URI from a workflow object
+ * @param {Object} workflow - Workflow object with category and name properties
+ * @returns {string} The full URI for the workflow
+ */
+function getWorkflowUri(workflow) {
+    return URI_PATTERNS.workflow(workflow.category, workflow.name);
+}
+
 /**
  * Documentation URLs configuration
  * These docs are fetched at runtime by the MCP server
@@ -505,18 +524,23 @@ function discoverPrompts(promptsPath) {
  * This generates ALL URIs - the MCP server purely reflects what's here
  */
 function generateManifest(discoveredWorkflows, exampleIds, discoveredPrompts) {
+    // Helper to get next step URI by looking up the workflow
+    const getNextStepUri = (nextStepId) => {
+        if (!nextStepId) return undefined;
+        const nextWorkflow = discoveredWorkflows.find(w => w.id === nextStepId);
+        return nextWorkflow ? getWorkflowUri(nextWorkflow) : undefined;
+    };
+
     // Generate workflow resources with hierarchical URIs
     const workflows = discoveredWorkflows.map(workflow => ({
         id: workflow.id,
         name: workflow.title,
         description: workflow.description,
         file: workflow.file,
         order: workflow.order,
-        uri: `${URI_SCHEME}workflows/${workflow.category}/${workflow.name}`,
+        uri: getWorkflowUri(workflow),
         nextStepId: workflow.nextStepId,
-        nextStepUri: workflow.nextStepId
-            ? `${URI_SCHEME}workflows/${workflow.category}/${discoveredWorkflows.find(w => w.id === workflow.nextStepId)?.name}`
-            : undefined,
+        nextStepUri: getNextStepUri(workflow.nextStepId),
     }));
 
     // TEMPORARY: Backward compatibility alias for legacy URI
@@ -531,9 +555,7 @@ function generateManifest(discoveredWorkflows, exampleIds, discoveredPrompts) {
             order: beginWorkflow.order,
             uri: 'posthog://integration/workflow/setup/begin', // Old hardcoded URI
             nextStepId: beginWorkflow.nextStepId,
-            nextStepUri: beginWorkflow.nextStepId
-                ? `${URI_SCHEME}workflows/${beginWorkflow.category}/${discoveredWorkflows.find(w => w.id === beginWorkflow.nextStepId)?.name}`
-                : undefined,
+            nextStepUri: getNextStepUri(beginWorkflow.nextStepId),
         });
     }
 
@@ -544,7 +566,7 @@ function generateManifest(discoveredWorkflows, exampleIds, discoveredPrompts) {
             id: DOCS_CONFIG.identify.id,
             name: DOCS_CONFIG.identify.name,
             description: DOCS_CONFIG.identify.description,
-            uri: `${URI_SCHEME}docs/${DOCS_CONFIG.identify.id}`,
+            uri: URI_PATTERNS.doc(DOCS_CONFIG.identify.id),
             url: DOCS_CONFIG.identify.url,
         },
     ];
@@ -573,8 +595,8 @@ function generateManifest(discoveredWorkflows, exampleIds, discoveredPrompts) {
     }
 
     // Add static template mappings for docs and examples
-    uriMap['docs.frameworks'] = 'posthog://docs/frameworks/{framework}';
-    uriMap['examples'] = 'posthog://examples/{framework}';
+    uriMap['docs.frameworks'] = URI_PATTERNS.frameworkDocs;
+    uriMap['examples'] = URI_PATTERNS.examples;
 
     /**
      * Helper to replace template variables in prompt text
@@ -599,7 +621,7 @@ function generateManifest(discoveredWorkflows, exampleIds, discoveredPrompts) {
     const templates = [
         {
             name: 'PostHog example projects',
-            uriPattern: 'posthog://examples/{framework}',
+            uriPattern: URI_PATTERNS.examples,
             description: 'Example project code showing PostHog integration for various frameworks',
             parameterName: 'framework',
             items: exampleIds.map(id => ({
@@ -609,7 +631,7 @@ function generateManifest(discoveredWorkflows, exampleIds, discoveredPrompts) {
         },
         {
             name: 'PostHog framework integration documentation',
-            uriPattern: 'posthog://docs/frameworks/{framework}',
+            uriPattern: URI_PATTERNS.frameworkDocs,
             description: 'PostHog integration documentation for various frameworks',
             parameterName: 'framework',
             items: Object.values(DOCS_CONFIG.frameworks).map(framework => ({
@@ -669,8 +691,15 @@ function processWorkflowFiles(discoveredWorkflows, outputDir) {
         let content = fs.readFileSync(workflow.fullPath, 'utf8');
 
         if (workflow.nextStepId) {
-            // Generate next step URI
-            const nextStepUri = `${URI_SCHEME}workflows/${workflow.nextStepId}`;
+            // Find the next workflow to generate its URI
+            const nextWorkflow = discoveredWorkflows.find(w => w.id === workflow.nextStepId);
+            if (!nextWorkflow) {
+                console.warn(`[WARNING] Next step workflow not found: ${workflow.nextStepId}`);
+                continue;
+            }
+
+            // Generate next step URI using the single source of truth
+            const nextStepUri = getWorkflowUri(nextWorkflow);
 
             // Append next step message
             content += `\n\n---\n\n**Upon completion, access the following resource to continue:** ${nextStepUri}`;