Skip to content

Commit eaac7cc

Browse files
committed
fix: Prevent default log errors when flags is not bundled
1 parent 60847a5 commit eaac7cc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/browser/src/__tests__/remote-config.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('RemoteConfigLoader', () => {
2828
_send_request: jest.fn().mockImplementation(({ callback }) => callback?.({ config: {} })),
2929
_shouldDisableFlags: () =>
3030
posthog.config.advanced_disable_flags || posthog.config.advanced_disable_decide || false,
31-
featureFlags: {
31+
_featureFlags: {
3232
ensureFlagsLoaded: jest.fn(),
3333
},
3434
reloadFeatureFlags: jest.fn(),
@@ -121,9 +121,9 @@ describe('RemoteConfigLoader', () => {
121121
new RemoteConfigLoader(posthog).load()
122122

123123
if (shouldReload) {
124-
expect(posthog.featureFlags.ensureFlagsLoaded).toHaveBeenCalled()
124+
expect(posthog._featureFlags?.ensureFlagsLoaded).toHaveBeenCalled()
125125
} else {
126-
expect(posthog.featureFlags.ensureFlagsLoaded).not.toHaveBeenCalled()
126+
expect(posthog._featureFlags?.ensureFlagsLoaded).not.toHaveBeenCalled()
127127
}
128128
})
129129

@@ -140,7 +140,7 @@ describe('RemoteConfigLoader', () => {
140140
// Should still call _onRemoteConfig with empty object so extensions start
141141
expect(posthog._onRemoteConfig).toHaveBeenCalledWith({})
142142
// Should still attempt to load flags
143-
expect(posthog.featureFlags.ensureFlagsLoaded).toHaveBeenCalled()
143+
expect(posthog._featureFlags?.ensureFlagsLoaded).toHaveBeenCalled()
144144
})
145145

146146
it('does not call ensureFlagsLoaded when advanced_disable_feature_flags_on_first_load is true', () => {
@@ -156,7 +156,7 @@ describe('RemoteConfigLoader', () => {
156156
new RemoteConfigLoader(posthog).load()
157157

158158
expect(posthog._onRemoteConfig).toHaveBeenCalledWith({ ...config, hasFeatureFlags: true })
159-
expect(posthog.featureFlags.ensureFlagsLoaded).not.toHaveBeenCalled()
159+
expect(posthog._featureFlags?.ensureFlagsLoaded).not.toHaveBeenCalled()
160160
})
161161
})
162162

packages/browser/src/remote-config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export class RemoteConfigLoader {
125125

126126
if (config?.hasFeatureFlags !== false) {
127127
if (!this._instance.config.advanced_disable_feature_flags_on_first_load) {
128-
this._instance.featureFlags.ensureFlagsLoaded()
128+
this._instance._featureFlags?.ensureFlagsLoaded()
129129
}
130130
}
131131
}

0 commit comments

Comments
 (0)