Optimize random number

Author: Twixes

src/__tests__/index.test.js

@@ -2,14 +2,7 @@ const { createEvent, createIdentify, getMeta, resetMeta, clone } = require('@pos
 
 const { processEvent } = require('..')
 
-global.fetch = jest.fn(() =>
-    Promise.resolve({
-        text: () => Promise.resolve(80805),
-    })
-)
-
 beforeEach(() => {
-    fetch.mockClear()
     resetMeta({
         config: {
             greeting: 'Dzień dobry!',
@@ -29,7 +22,7 @@ test('processEvent adds properties', async () => {
             ...event0.properties,
             greeting: 'Dzień dobry!',
             greeting_counter: 0,
-            random: 80805,
+            random_number: 4,
         },
     })
 
@@ -53,10 +46,15 @@ test('processEvent adds properties', async () => {
 })
 
 test('processEvent does not crash with identify', async () => {
+    const defaultHelloWorldProperties = Object.freeze({
+        greeting: 'Dzień dobry!',
+        greeting_counter: 0,
+        random_number: 4,
+    })
     // create a random event
     const event0 = createIdentify()
-
     // must clone the event since `processEvent` will mutate it otherwise
-    const event1 = await processEvent(clone(event0), getMeta())
-    expect(event1).toEqual({ ...event0, greeting: 'Dzień dobry!', greeting_counter: 0, random: 80805 })
+    const { properties, ...restOfEvent1 } = await processEvent(clone(event0), getMeta())
+    expect(restOfEvent1).toEqual(event0)
+    expect(properties).toEqual(defaultHelloWorldProperties)
 })

src/index.ts

@@ -4,8 +4,9 @@ import type { RequestInfo, RequestInit, Response } from 'node-fetch'
 // fetch only declared, as it's provided as a plugin VM global
 declare function fetch(url: RequestInfo, init?: RequestInit): Promise<Response>
 
-// Internal library function
-async function fetchTrulyRandomInteger(): Promise<number> {
+// Some internal library function
+async function getRandomNumber(): Promise<number> {
+    return 4 // remove this line to get an actual random number from random.org – caution, rate limited to 10 events/s!
     const response = await fetch(
         'https://www.random.org/integers/?num=1&min=1&max=1000000000&col=1&base=10&format=plain&rnd=new'
     )
@@ -26,7 +27,7 @@ const helloWorld: Plugin = {
         }
         event.properties['greeting'] = config.greeting
         event.properties['greeting_counter'] = counterValue
-        event.properties['random'] = await fetchTrulyRandomInteger()
+        event.properties['random_number'] = await getRandomNumber()
         return event
     },
 }