Skip to content

Commit 221d7f0

Browse files
authored
Do not start Feature Flag polling if no API Key (#15)
* jetbrains idea .gitignore * do not start the poller if no personal api key
1 parent 98d2d4c commit 221d7f0

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,5 @@ env
1212
flake8.out
1313
pylint.out
1414
posthog-analytics
15+
.idea
16+

posthog/client.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,6 @@ def shutdown(self):
228228
self.join()
229229

230230
def _load_feature_flags(self):
231-
if not self.personal_api_key:
232-
self.log.warning('[FEATURE FLAGS] You have to specify a personal_api_key to use feature flags.')
233-
self.feature_flags = []
234-
return
235-
236231
try:
237232
self.feature_flags = get(self.personal_api_key, '/api/feature_flag/', self.host)['results']
238233
except APIError as e:
@@ -250,6 +245,11 @@ def _load_feature_flags(self):
250245
self._last_feature_flag_poll = datetime.utcnow().replace(tzinfo=tzutc())
251246

252247
def load_feature_flags(self):
248+
if not self.personal_api_key:
249+
self.log.warning('[FEATURE FLAGS] You have to specify a personal_api_key to use feature flags.')
250+
self.feature_flags = []
251+
return
252+
253253
self._load_feature_flags()
254254
poller = Poller(interval=timedelta(seconds=self.poll_interval), execute=self._load_feature_flags)
255255
poller.start()

0 commit comments

Comments
 (0)