Skip to content

Commit 2387494

Browse files
committed
refactor: clean up mypy errors
1 parent b6033e4 commit 2387494

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

posthog/client.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,8 @@ def __init__(
227227
self.timeout = timeout
228228
self._feature_flags = None # private variable to store flags
229229
self.feature_flags_by_key = None
230-
self.group_type_mapping = None
231-
self.cohorts = None
230+
self.group_type_mapping: Optional[dict[str, str]] = None
231+
self.cohorts: Optional[dict[str, Any]] = None
232232
self.poll_interval = poll_interval
233233
self.feature_flags_request_timeout_seconds = (
234234
feature_flags_request_timeout_seconds
@@ -1213,9 +1213,9 @@ def _update_flag_state(
12131213
self, data: FlagDefinitionCacheData, old_flags_by_key: Optional[dict] = None
12141214
) -> None:
12151215
"""Update internal flag state from cache data and invalidate evaluation cache if changed."""
1216-
self.feature_flags = data.get("flags") or []
1217-
self.group_type_mapping = data.get("group_type_mapping") or {}
1218-
self.cohorts = data.get("cohorts") or {}
1216+
self.feature_flags = data.get("flags", [])
1217+
self.group_type_mapping = data.get("group_type_mapping", {})
1218+
self.cohorts = data.get("cohorts", {})
12191219

12201220
# Invalidate evaluation cache if flag definitions changed
12211221
if (
@@ -1417,7 +1417,8 @@ def _compute_flag_locally(
14171417
flag_filters = feature_flag.get("filters") or {}
14181418
aggregation_group_type_index = flag_filters.get("aggregation_group_type_index")
14191419
if aggregation_group_type_index is not None:
1420-
group_name = self.group_type_mapping.get(str(aggregation_group_type_index))
1420+
group_type_mapping = self.group_type_mapping or {}
1421+
group_name = group_type_mapping.get(str(aggregation_group_type_index))
14211422

14221423
if not group_name:
14231424
self.log.warning(

0 commit comments

Comments
 (0)