Feature: Enable multi variate feature flags for Python library (#60)

* Capturing $feature_flag_called at the end of client.feature_enabled method

* Enabling multi-variants for feature flags

Co-authored-by: Utku Zihnioglu <[email protected]>
Co-authored-by: Tim Glaser <[email protected]>

Author: 3 people

posthog/client.py

@@ -380,8 +380,7 @@ def feature_enabled(self, key, distinct_id, default=False, *, groups={}):
                 )
                 self.log.warning(e)
             else:
-                response = True if key in resp_data["featureFlags"] else default
-
+                response = resp_data["featureFlags"].get(key, default)
         self.capture(distinct_id, "$feature_flag_called", {"$feature_flag": key, "$feature_flag_response": response})
         return response
 

posthog/request.py

@@ -68,7 +68,7 @@ def _process_response(
 
 def decide(api_key: str, host: Optional[str] = None, gzip: bool = False, timeout: int = 15, **kwargs) -> Any:
     """Post the `kwargs to the decide API endpoint"""
-    res = post(api_key, host, "/decide/", gzip, timeout, **kwargs)
+    res = post(api_key, host, "/decide/?v=2", gzip, timeout, **kwargs)
     return _process_response(res, success_message="Feature flags decided successfully")
 
 

posthog/test/test_client.py

@@ -434,13 +434,22 @@ def test_feature_enabled_simple_with_project_api_key(self, patch_get):
 
     @mock.patch("posthog.client.decide")
     def test_feature_enabled_request(self, patch_decide):
-        patch_decide.return_value = {"featureFlags": ["beta-feature"]}
+        patch_decide.return_value = {"featureFlags": {"beta-feature": True}}
         client = Client(TEST_API_KEY)
         client.feature_flags = [
             {"id": 1, "name": "Beta Feature", "key": "beta-feature", "is_simple_flag": False, "rollout_percentage": 100}
         ]
         self.assertTrue(client.feature_enabled("beta-feature", "distinct_id"))
 
+    @mock.patch("posthog.client.decide")
+    def test_feature_enabled_request_multi_variate(self, patch_decide):
+        patch_decide.return_value = {"featureFlags": {"beta-feature": "variant-1"}}
+        client = Client(TEST_API_KEY)
+        client.feature_flags = [
+            {"id": 1, "name": "Beta Feature", "key": "beta-feature", "is_simple_flag": False, "rollout_percentage": 100}
+        ]
+        self.assertEqual(client.feature_enabled("beta-feature", "distinct_id"), "variant-1")
+
     @mock.patch("posthog.client.get")
     def test_feature_enabled_simple_without_rollout_percentage(self, patch_get):
         client = Client(TEST_API_KEY)
@@ -458,7 +467,7 @@ def test_feature_enabled_simple_with_none_rollout_percentage(self, patch_get):
     @mock.patch("posthog.client.Poller")
     @mock.patch("posthog.client.decide")
     def test_feature_enabled_doesnt_exist(self, patch_decide, patch_poll):
-        patch_decide.return_value = {"featureFlags": []}
+        patch_decide.return_value = {"featureFlags": {}}
         client = Client(TEST_API_KEY, personal_api_key="test")
         client.feature_flags = []
 
@@ -471,7 +480,7 @@ def test_personal_api_key_doesnt_exist(self, patch_decide, patch_poll):
         client = Client(TEST_API_KEY)
         client.feature_flags = []
 
-        patch_decide.return_value = {"featureFlags": ["feature-flag"]}
+        patch_decide.return_value = {"featureFlags": {"feature-flag": True}}
 
         self.assertTrue(client.feature_enabled("feature-flag", "distinct_id"))