Closer

Author: pauldambra

posthog/test/test_client.py

@@ -5,6 +5,7 @@
 
 import mock
 import six
+from parameterized import parameterized
 
 from posthog.client import Client
 from posthog.request import APIError
@@ -54,10 +55,11 @@ def test_basic_capture(self):
         self.assertEqual(msg["distinct_id"], "distinct_id")
         self.assertEqual(msg["properties"]["$lib"], "posthog-python")
         self.assertEqual(msg["properties"]["$lib_version"], VERSION)
-        assert msg["properties"]["$python_runtime"] == "CPython"
-        assert msg["properties"]["$python_version"] == "3.11.11"
-        assert msg["properties"]["$os"] == "Mac OS X"
-        assert msg["properties"]["$os_version"] == "15.3.1"
+        # these will change between platforms so just asssert on presence here
+        assert msg["properties"]["$python_runtime"] == mock.ANY
+        assert msg["properties"]["$python_version"] == mock.ANY
+        assert msg["properties"]["$os"] == mock.ANY
+        assert msg["properties"]["$os_version"] == mock.ANY
 
     def test_basic_capture_with_uuid(self):
         client = self.client
@@ -1128,3 +1130,88 @@ def test_default_properties_get_added_properly(self, patch_decide):
             group_properties={},
             disable_geoip=False,
         )
+
+    @parameterized.expand([
+        # name, sys_platform, version_info, expected_runtime, expected_version, expected_os, expected_os_version, platform_method, platform_return, distro_info
+        (
+            "macOS",
+            "darwin",
+            (3, 8, 10),
+            "MockPython",
+            "3.8.10",
+            "Mac OS X",
+            "10.15.7",
+            "mac_ver",
+            ("10.15.7", "", ""),
+            None,
+        ),
+        (
+            "Windows",
+            "win32",
+            (3, 8, 10),
+            "MockPython",
+            "3.8.10",
+            "Windows",
+            "10",
+            "win32_ver",
+            ("10", "", "", ""),
+            None,
+        ),
+        (
+            "Linux",
+            "linux",
+            (3, 8, 10),
+            "MockPython",
+            "3.8.10",
+            "Linux",
+            "20.04",
+            None,
+            None,
+            {"version": "20.04"},
+        ),
+    ])
+    def test_mock_system_context(
+        self, 
+        _name, 
+        sys_platform, 
+        version_info, 
+        expected_runtime, 
+        expected_version, 
+        expected_os, 
+        expected_os_version, 
+        platform_method, 
+        platform_return, 
+        distro_info
+    ):
+        """Test that we can mock platform and sys for testing system_context"""
+        with mock.patch('posthog.client.platform') as mock_platform:
+            with mock.patch('posthog.client.sys') as mock_sys:
+                # Set up common mocks
+                mock_platform.python_implementation.return_value = expected_runtime
+                mock_sys.version_info = version_info
+                mock_sys.platform = sys_platform
+                
+                # Set up platform-specific mocks
+                if platform_method:
+                    getattr(mock_platform, platform_method).return_value = platform_return
+                
+                # Special handling for Linux which uses distro module
+                if sys_platform == "linux":
+                    with mock.patch.dict('sys.modules', {'distro': mock.MagicMock()}):
+                        import sys
+                        mock_distro = sys.modules['distro']
+                        mock_distro.info.return_value = distro_info
+                        
+                        # Get system context
+                        from posthog.client import system_context
+                        context = system_context()
+                else:
+                    # Get system context for non-Linux platforms
+                    from posthog.client import system_context
+                    context = system_context()
+                
+                # Verify results
+                self.assertEqual(context["$python_runtime"], expected_runtime)
+                self.assertEqual(context["$python_version"], expected_version)
+                self.assertEqual(context["$os"], expected_os)
+                self.assertEqual(context["$os_version"], expected_os_version)

setup.py

@@ -58,6 +58,7 @@
         "langchain-openai>=0.2.0",
         "langchain-anthropic>=0.2.0",
         "pydantic",
+        "parameterized>=0.8.1",
     ],
     "sentry": ["sentry-sdk", "django"],
     "langchain": ["langchain>=0.2.0"],