fix: resolve mypy errors in otel and pydantic_ai exporters

Author: andrewm4894

posthog/ai/otel/exporter.py

@@ -8,23 +8,25 @@
 
 import json
 import logging
-from typing import Any, Dict, Optional, Sequence, Union
+from typing import TYPE_CHECKING, Any, Dict, Optional, Sequence, Union
 
 from posthog.client import Client as PostHogClient
 
+if TYPE_CHECKING:
+    from opentelemetry.sdk.trace import ReadableSpan
+    from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
+    from opentelemetry.trace import StatusCode
+
 try:
     from opentelemetry.sdk.trace import ReadableSpan
     from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
     from opentelemetry.trace import StatusCode
 
     OTEL_AVAILABLE = True
+    _BASE_CLASS = SpanExporter
 except ImportError:
     OTEL_AVAILABLE = False
-    # Define stub types for type hints when OTel is not installed
-    ReadableSpan = Any  # type: ignore
-    SpanExporter = object  # type: ignore
-    SpanExportResult = Any  # type: ignore
-    StatusCode = Any  # type: ignore
+    _BASE_CLASS = object
 
 logger = logging.getLogger(__name__)
 
@@ -77,7 +79,7 @@ class GenAIAttributes:
     SERVER_PORT = "server.port"
 
 
-class PostHogSpanExporter(SpanExporter if OTEL_AVAILABLE else object):
+class PostHogSpanExporter(_BASE_CLASS):  # type: ignore[valid-type,misc]
     """
     OpenTelemetry SpanExporter that sends AI/LLM spans to PostHog.
 
@@ -284,7 +286,7 @@ def _is_agent_span(self, span_name: str, attrs: Dict[str, Any]) -> bool:
         """Check if span represents an agent run."""
         return span_name in ("agent run", "invoke_agent") or attrs.get(
             GenAIAttributes.AGENT_NAME
-        )
+        ) is not None
 
     def _is_tool_span(self, span_name: str, attrs: Dict[str, Any]) -> bool:
         """Check if span represents a tool/function execution."""

posthog/ai/pydantic_ai/exporter.py

@@ -5,24 +5,27 @@
 Pydantic AI-specific transformations like message format normalization.
 """
 
-from typing import Any, Dict, List, Optional, Sequence
+from typing import TYPE_CHECKING, Any, Dict, List, Optional, Sequence
+
+if TYPE_CHECKING:
+    from opentelemetry.sdk.trace import ReadableSpan
+    from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
 
 try:
     from opentelemetry.sdk.trace import ReadableSpan
     from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
 
     OTEL_AVAILABLE = True
+    _BASE_CLASS = SpanExporter
 except ImportError:
     OTEL_AVAILABLE = False
-    ReadableSpan = Any  # type: ignore
-    SpanExporter = object  # type: ignore
-    SpanExportResult = Any  # type: ignore
+    _BASE_CLASS = object
 
 from posthog.ai.otel import PostHogSpanExporter
 from posthog.client import Client as PostHogClient
 
 
-class PydanticAISpanExporter(SpanExporter if OTEL_AVAILABLE else object):
+class PydanticAISpanExporter(_BASE_CLASS):  # type: ignore[valid-type,misc]
     """
     SpanExporter for Pydantic AI that normalizes messages to OpenAI format.